refactor: Remove redundant addrman time checks #25303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nTime is always initialized on deserialization or default-initialized with TIME_INIT, so special casing 0 does not make sense.
fa777c3 to
fa8bdb7
Compare
All other places calculate "now - nLastTry", which is safe and correct to do when nLastTry is 0. So do the same here.
fa8bdb7 to
8888bd4
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
re-ACK 8888bd4 |
This was referenced Jun 8, 2022
|
utACK 8888bd4 |
|
Post-merge utACK 8888bd4 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 13, 2022
8888bd4 Remove redundant nLastTry check (MarcoFalke) 00001e5 Remove redundant nTime checks (MarcoFalke) Pull request description: Split out from bitcoin#24697 because it makes sense on its own. ACKs for top commit: dergoegge: re-ACK 8888bd4 naumenkogs: utACK 8888bd4 Tree-SHA512: 32c6cde1c71e943c76b7991c2c24caf29ae467ab4ea2d758483a0cee64625190d1a833b468e8eab1f834beeb2c365af96552c14b05270f08cf63790e0707581d
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 5, 2024
Summary: > Remove redundant nTime checks > > nTime is always initialized on deserialization or default-initialized > with TIME_INIT, so special casing 0 does not make sense. > Remove redundant nLastTry check > > All other places calculate "now - nLastTry", which is safe and correct > to do when nLastTry is 0. So do the same here. This is a backport of [[bitcoin/bitcoin#25303 | core#25303]] Depends on D15088 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D15089
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 17, 2024
8888bd4 Remove redundant nLastTry check (MarcoFalke) 00001e5 Remove redundant nTime checks (MarcoFalke) Pull request description: Split out from bitcoin#24697 because it makes sense on its own. ACKs for top commit: dergoegge: re-ACK 8888bd4 naumenkogs: utACK 8888bd4 Tree-SHA512: 32c6cde1c71e943c76b7991c2c24caf29ae467ab4ea2d758483a0cee64625190d1a833b468e8eab1f834beeb2c365af96552c14b05270f08cf63790e0707581d
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 19, 2024
8888bd4 Remove redundant nLastTry check (MarcoFalke) 00001e5 Remove redundant nTime checks (MarcoFalke) Pull request description: Split out from bitcoin#24697 because it makes sense on its own. ACKs for top commit: dergoegge: re-ACK 8888bd4 naumenkogs: utACK 8888bd4 Tree-SHA512: 32c6cde1c71e943c76b7991c2c24caf29ae467ab4ea2d758483a0cee64625190d1a833b468e8eab1f834beeb2c365af96552c14b05270f08cf63790e0707581d
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 19, 2024
8888bd4 Remove redundant nLastTry check (MarcoFalke) 00001e5 Remove redundant nTime checks (MarcoFalke) Pull request description: Split out from bitcoin#24697 because it makes sense on its own. ACKs for top commit: dergoegge: re-ACK 8888bd4 naumenkogs: utACK 8888bd4 Tree-SHA512: 32c6cde1c71e943c76b7991c2c24caf29ae467ab4ea2d758483a0cee64625190d1a833b468e8eab1f834beeb2c365af96552c14b05270f08cf63790e0707581d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #24697 because it makes sense on its own.