doc: Fix spelling errors identified by codespell in comments #25200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
May 24, 2022
There was a problem hiding this comment.
A couple more minor fixups that can be squashed in here, for your consideration:
diff --git a/doc/fuzzing.md b/doc/fuzzing.md
index 9abfbc9213..7a2191f859 100644
--- a/doc/fuzzing.md
+++ b/doc/fuzzing.md
@@ -105,7 +105,7 @@ Fuzzing on a harness compiled with `--with-sanitizers=address,fuzzer,undefined`
## Reproduce a fuzzer crash reported by the CI
-- `cd` into the `qa-assets` directory and update it with `git pull qa-assets`
+- `cd` into the `qa-assets` directory and update it with `git pull`
diff --git a/src/bench/bench.cpp b/src/bench/bench.cpp
index d26b52410c..26975bb59d 100644
--- a/src/bench/bench.cpp
+++ b/src/bench/bench.cpp
@@ -58,7 +58,7 @@ void benchmark::BenchRunner::RunAll(const Args& args)
if (args.sanity_check) {
- std::cout << "Running with --sanity check option, benchmark results will be useless." << std::endl;
+ std::cout << "Running with --sanity-check option, benchmark results will be useless." << std::endl;Seems ok to add "nd" to test/lint/spelling.ignore-words.txt.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
From the output here: src/qt/test/addressbooktests.cpp:185: wilcard ==> wildcard src/qt/test/addressbooktests.cpp:191: wilcard ==> wildcard src/test/miniscript_tests.cpp:227: nd ==> and, 2nd src/test/versionbits_tests.cpp:260: everytime ==> every time src/util/time.h:89: precicion ==> precision src/util/time.h:90: precicion ==> precision ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt https://cirrus-ci.com/task/5275612980969472?logs=lint#L849 I added 'nd' to the spelling.ignored-words.txt, as it's valid miniscript.
|
@jonatack picked up the latter fixup, added nd to the ignore list. |
dunxen
approved these changes
May 31, 2022
Note to contributors, strikethrough formatting in the PR description doesn't seem to translate very well in the merge commit. Probably best to just remove it. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 31, 2022
… in comments f565b28 Fixup option name in bench message (Ben Woosley) bf209ac doc: Fix spelling errors identified by codespell in coments (Ben Woosley) Pull request description: From the output [here](https://cirrus-ci.com/task/5275612980969472?logs=lint#L849): ``` src/qt/test/addressbooktests.cpp:185: wilcard ==> wildcard src/qt/test/addressbooktests.cpp:191: wilcard ==> wildcard src/test/miniscript_tests.cpp:227: nd ==> and, 2nd src/test/versionbits_tests.cpp:260: everytime ==> every time src/util/time.h:89: precicion ==> precision src/util/time.h:90: precicion ==> precision ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt ``` ~~I left the 'nd' in miniscript_tests as-is, as it's valid miniscript, and I'm wary of whitelisting it.~~ ACKs for top commit: dunxen: ACK f565b28 Tree-SHA512: 501a426c5f6f9761e2c8f980d5d955611428a827321888f53e0ae9526b0fecd43f9d1fa845fc70ae2489d77be6dc0b5b371dff55c5146f4b39ed874f4a1ea917
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the output here:
I left the 'nd' in miniscript_tests as-is, as it's valid miniscript,and I'm wary of whitelisting it.