doc: remove passing --disable-external-signer in OpenBSD build guide
#25178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Boost.Process usage check was added to the build system (commit abc057c), passing the option `--disable-external-signer` explicitly is not needed anymore on OpenBSD; The configure script will automatically detect that including <boost/process.hpp> leads to a compile error and disable external signer support accordingly.
fanquake
approved these changes
May 23, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 28, 2022
…in OpenBSD build guide 9ecb0a3 doc: remove passing `--disable-external-signer` in OpenBSD build guide (Sebastian Falbesoner) Pull request description: Since we have a Boost.Process usage check in the build system (bitcoin#24254, commit abc057c), passing the option `--disable-external-signer` explicitly is not needed anymore on OpenBSD; the configure script will automatically detect that including `<boost/process.hpp>` leads to a compile error and disable external signer support accordingly: ``` $ ./configure MAKE=gmake ... checking whether Boost.Process can be used... no ... Options used to compile and link: external signer = no ... $ ./configure --enable-external-signer MAKE=gmake ... checking whether Boost.Process can be used... no configure: error: External signing is not supported for this Boost version ``` The PR basically reverts bitcoin#22335 but keeps the part mentioning that external signer support is not available on OpenBSD. Also bumps the guide to version 7.1 (released [about a month ago](https://www.openbsd.org/71.html)), where I could verify that the instructions are still accurate. ACKs for top commit: fanquake: ACK 9ecb0a3 Tree-SHA512: a5f7e89a5a78f062a06e0047802c42ad49d89e0f0afb963886caa684966ea2e9c8a660320eedd98a5aa5eee0a9c2bb8bf7f5772338c4b49738a69c00e9367a15
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have a Boost.Process usage check in the build system (#24254, commit abc057c), passing the option
--disable-external-signerexplicitly is not needed anymore on OpenBSD; the configure script will automatically detect that including<boost/process.hpp>leads to a compile error and disable external signer support accordingly:The PR basically reverts #22335 but keeps the part mentioning that external signer support is not available on OpenBSD. Also bumps the guide to version 7.1 (released about a month ago), where I could verify that the instructions are still accurate.