test: Remove boost::split from rpc_tests.cpp #25025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da6a448 to
fad35e9
Compare
fanquake
approved these changes
Apr 29, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 29, 2022
fad35e9 test: Remove boost::split from rpc_tests.cpp (MacroFake) Pull request description: No need for boost, as there are no tabs. Can be tested with: ```diff diff --git a/src/test/rpc_tests.cpp b/src/test/rpc_tests.cpp index 50b5078..ad6a888ad0 100644 --- a/src/test/rpc_tests.cpp +++ b/src/test/rpc_tests.cpp @@ -29,6 +29,7 @@ public: UniValue RPCTestingSetup::CallRPC(std::string args) { +Assert(args.find('\t')==std::string::npos); std::vector<std::string> vArgs; boost::split(vArgs, args, boost::is_any_of(" \t")); std::string strMethod = vArgs[0]; ACKs for top commit: fanquake: utACK fad35e9 Tree-SHA512: 3df789a222b407d61ad549adc4bbded00705d7c3db07472c31ce0e82216fe3ae27724b7f0ee3e85084bdf405cc28185e85487c9a7001620d6654fda77bab8eb3
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 21, 2022
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 26, 2022
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 3, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 13, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 15, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jan 19, 2023
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jan 19, 2023
backport: merge bitcoin#18289, bitcoin#19090, bitcoin#22859, bitcoin#18758, bitcoin#21016, bitcoin#22953, bitcoin#25027, bitcoin#20461, bitcoin#25025, bitcoin#25057, bitcoin#25068 (deboostification)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need for boost, as there are no tabs.
Can be tested with: