netgroup: Follow-up for #22910 #24976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should we ever introduce a new address type that makes use of `nStartByte` and adds fractional bytes to the group, then nStartByte should be used as the offset for the last byte.
|
Code review ACK e5d1831 Thanks! |
jnewbery
approved these changes
May 4, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 4, 2022
e5d1831 [netgroup] Use nStartByte as offset for the last byte of the group (dergoegge) Pull request description: This addresses my review [comments](bitcoin#22910 (comment)) I left on bitcoin#22910. This has no effect on the current logic as `nStartByte` is only used for internal addresses which only ever add 10 whole bytes to the returned group. However to avoid future bugs, I think we should use `nStartByte` as offset for the last byte as well, in case we ever add a new address type that makes makes use of `nStartByte` and adds fractional bytes to the group. ACKs for top commit: jnewbery: Code review ACK e5d1831 theStack: Concept and code-review ACK e5d1831 Tree-SHA512: 4c08c7d6cb38b553e998798b3e3b790177aaa2141a48e277dfd538e01a7fccadf644329e93c5b0fb5e7e4037494c8dfe061b94eb52c6b31dc21bdf99eb0e311a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses my review comments I left on #22910.
This has no effect on the current logic as
nStartByteis only used for internal addresses which only ever add 10 whole bytes to the returned group. However to avoid future bugs, I think we should usenStartByteas offset for the last byte as well, in case we ever add a new address type that makes makes use ofnStartByteand adds fractional bytes to the group.