lint: Convert lint-python-utf8-encoding.sh to Python #24916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38564e4 to
9365b68
Compare
9365b68 to
1d52224
Compare
anibilthare
reviewed
Apr 19, 2022
|
Tested ACK! (One thing to note is that, with bad styling, CI will fail even with |
laanwj
reviewed
Apr 21, 2022
| fileopens = list() | ||
|
|
||
| try: | ||
| fileopens = check_output(["git", "grep", r" open(", "--", "*.py", ":(exclude)src/crc32c/"], universal_newlines=True, encoding="utf8").splitlines() |
There was a problem hiding this comment.
Please unify the excludes in one place at the top, like you did for the other PRs.
1d52224 to
171e106
Compare
171e106 to
035eef4
Compare
|
Thanks for addressing my comment. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 26, 2022
…thon 035eef4 lint: Convert lint-python-utf8-encoding.sh to Python (Dimitri) Pull request description: A port of `test/lint/lint-python-utf8-encoding.sh` to a Python-script as part of the request of bitcoin#24783. Checked for output-consistency. ACKs for top commit: laanwj: Code review ACK 035eef4 Tree-SHA512: a8a2f505bf7953d318837182101346c44e73cfd1bf3b5342ff1400fb1c67c5292519fa99db1035da87cf27fb5f5ac5d28871bf55a1c085b5f8a3bb33ff0fa3fb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A port of
test/lint/lint-python-utf8-encoding.shto a Python-script as part of the request of #24783. Checked for output-consistency.