Skip to content

Conversation

Kvaciral
Copy link
Contributor

@Kvaciral Kvaciral commented Apr 16, 2022

A port of test/lint/lint-includes.sh to a Python-script as part of the request of #24783. Checked for output-consistency.

@DrahtBot DrahtBot added the Tests label Apr 16, 2022
@Kvaciral Kvaciral force-pushed the lint-includes-port branch from 4946115 to 1821bf2 Compare April 16, 2022 18:08
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #22417 (util/system: Close non-std fds when execing slave processes by luke-jr)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@laanwj laanwj mentioned this pull request Apr 18, 2022
25 tasks
@Kvaciral Kvaciral force-pushed the lint-includes-port branch 2 times, most recently from 6f636ea to ac6b2dd Compare April 18, 2022 17:52
@Kvaciral Kvaciral force-pushed the lint-includes-port branch from ac6b2dd to 67b4167 Compare April 19, 2022 00:24
@KevinMusgrave
Copy link
Contributor

Tested ACK 67b4167

It matches the old output. Example:

Duplicate include(s) in src/bench/addrman.cpp:
#include <vector>

Duplicate include(s) in src/bench/base58.cpp:
#include <array>

The following files #include .cpp files:
src/bench/base58.cpp:#include <bench/bench.cpp>
src/bench/bench_bitcoin.cpp:#include <bench/bench.cpp>
src/bench/bench_bitcoin.cpp:#include <clientversion.cpp>

A new Boost dependency in the form of "boost/algorithm/cats.hpp" appears to have been introduced:
src/bench/block_assemble.cpp:#include <boost/algorithm/cats.hpp>

A new Boost dependency in the form of "boost/algorithm/dogs.hpp" appears to have been introduced:
src/bench/bech32.cpp:#include <boost/algorithm/dogs.hpp>

Please use bracket syntax includes ("#include <foo.h>") instead of quote syntax includes:
src/bench/bech32.cpp:#include "vector"
src/bench/block_assemble.cpp:#include "crypto/sha256.h"

@maflcko maflcko merged commit fc99f8c into bitcoin:master Apr 20, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 22, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants