Skip to content

lint: Convert lint-git-commit-check.sh to Python #24853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2022
Merged

lint: Convert lint-git-commit-check.sh to Python #24853

merged 1 commit into from
Apr 18, 2022
+63 −48

Conversation

Kvaciral
Copy link
Contributor

A port of /test/lint/lint-git-commit-check.sh to a Python-script as part of the request of #24783 . Checked for output-consistency.

@laanwj laanwj mentioned this pull request Apr 14, 2022
Closed
25 tasks
@DrahtBot DrahtBot added the Tests label Apr 14, 2022
@Kvaciral Kvaciral force-pushed the lint-git-commit-check-port branch from 2cf29ee to a694efa Compare April 14, 2022 13:00
@laanwj
Copy link
Member

laanwj commented Apr 14, 2022 •
edited
Loading

Tested ACK 2e6cfc7
re-ACK f27fcd9

$ git commit --allow-empty -m $'invalid\ncommit\nmessage'
[pull/24853/local-merge 8e2cddbb3a6163d47c728bdbb93bd57867bd180c] invalid commit message
$ test/lint/lint-git-commit-check.py
The subject line of commit hash 8e2cddbb3a6163d47c728bdbb93bd57867bd180c is followed by a non-empty line. Subject lines should always be followed by a blank line.
$ git reset --hard HEAD~1
$ test/lint/lint-git-commit-check.py

@Kvaciral Kvaciral force-pushed the lint-git-commit-check-port branch from a694efa to 2e6cfc7 Compare April 14, 2022 14:56
anibilthare
anibilthare reviewed Apr 16, 2022
View reviewed changes
@Kvaciral Kvaciral force-pushed the lint-git-commit-check-port branch from 2e6cfc7 to f27fcd9 Compare April 16, 2022 13:43
anibilthare
anibilthare reviewed Apr 17, 2022
View reviewed changes
@laanwj laanwj merged commit 5fdf37e into bitcoin:master Apr 18, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 19, 2022
@laanwj
Merge bitcoin#24853: lint: Convert lint-git-commit-check.sh to Python
d100a1c 
f27fcd9 lint: Convert lint-git-commit-check.sh to Python (Dimitri)

Pull request description:

  A port of `/test/lint/lint-git-commit-check.sh` to a Python-script as part of the request of bitcoin#24783 . Checked for output-consistency.

ACKs for top commit:
  laanwj:
    re-ACK f27fcd9

Tree-SHA512: afc4a662f4aec1796c023b98a875c1591940ecdfc709eefe2df29d33e51e807c3c2e2b5c410aa3ad1cd3f6f8207f5c15b638637ff9f5659cafa7543bbe8a0bae
@bitcoin bitcoin deleted a comment Apr 27, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@anibilthare anibilthare anibilthare left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kvaciral @laanwj @anibilthare @DrahtBot