Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 13, 2022

Dependency changes in vcpkg 2022.04.12:

  • zeromq 4.3.4#4 -> 4.3.4#5

This allows to revert our workaround because of an upstream patch.

@DrahtBot DrahtBot added the Tests label Apr 13, 2022
@hebasto
Copy link
Member Author

hebasto commented Apr 14, 2022

cc @sipsorcery

@sipsorcery
Copy link
Contributor

ACK b2c3d10.

@maflcko maflcko merged commit 012d33f into bitcoin:master Apr 15, 2022
@hebasto hebasto deleted the 220413-vcpkg branch April 15, 2022 09:18
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 18, 2022
maflcko pushed a commit to bitcoin-core/gui that referenced this pull request Jun 27, 2022
…ualstudio2022`

05b2d9f build: Bump default `PlatformToolset` for Visual Studio 2022 (Hennadii Stepanov)
460c6c7 doc: Make Windows build docs match the CI task (Hennadii Stepanov)
849cf96 ci: Increase CPU number for "Win64 native" task (Hennadii Stepanov)
a18c4c1 ci: Bump vcpkg to the latest version (Hennadii Stepanov)
b9a5a9b ci: Limit ccache cache size properly on "Win64 native" task (Hennadii Stepanov)
156bc89 ci: Update Windows task image up to visualstudio2022 (Hennadii Stepanov)

Pull request description:

  Besides upgrading Visual Studio, which seems [inevitable](bitcoin/bitcoin#24531 (comment)), this PR also:
  - bumps vcpkg to the latest version (previous one was in bitcoin/bitcoin#24847)
  - fixes cache size limit for `ccache`

ACKs for top commit:
  sipsorcery:
    reACK 05b2d9f.
  hebasto:
    > ACK [05b2d9f](bitcoin/bitcoin@05b2d9f)
  jarolrod:
    ACK 05b2d9f

Tree-SHA512: 6338e74a3f1907f09ca29540e9e2cf7ac3be3b9e28271e8a20e71b67a9c3d5ebb8d34528b9677bcd1d9bc0ad723d68fd2ba7db368443ed1854cca3a3961f294b
@bitcoin bitcoin locked and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants