net: improve and address issues in makeseeds.py #24818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
11 tasks
|
Thanks for working on this. |
laanwj
reviewed
Apr 13, 2022
|
ACK after squashing commits. |
|
Squashed, thanks again for the help reviewing. |
|
Concept and code review ACK c457fb1 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 18, 2022
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 5, 2022
Summary: Backport of [[ bitcoin/bitcoin#24818 | core#24818 ]] This patch increases the number of ipv6 seeds from 2 to 10 per ASN and increases MIN_BLOCKS to 730000. Most of the refactors are not big improvements in clarity but it does bring our code more inline with Bitcoin Core. Test Plan: python3 makeseeds.py < seeds_main.txt > nodes_main.txt python3 makeseeds.py < seeds_test.txt > nodes_test.txt git diff Diff should be more additions than removals and retain most of the old entries. Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D12141
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address some of the areas of improvement raised in #17020 . Concretely, my proposed change is fairly minor but addresses the following changes to
makeseeds.py:MIN_BLOCKSto 730000.With the different ASN limits for IPv4 and IPv6, and the new minimum block requirement, the current stats look look like:
The new ASN max seeds of 10 allows for 512 IPv6 addresses to be included, up from the ~150 that was filtered by the previous version.
While there is more to do for #17020 , these changes I think are fairly isolated from the rest and should make it a bit easier for others to get up to speed with what the functions in the script do.