Skip to content

Conversation

dscotese
Copy link
Contributor

@dscotese dscotese commented Apr 6, 2022

This is a single commit to replace the three commits from #23916

I propose this change so that Windows users can more easily import signers' keys.

This is a single commit to replace the three commits from bitcoin/bitcoin PR bitcoin#23619.
@laanwj
Copy link
Member

laanwj commented Apr 7, 2022

Please do not open new PRs to squash commits. This creates unnecessary noise. There are instructions in https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits.

@fanquake
Copy link
Member

@sipsorcery want to sanity check?

@sipsorcery
Copy link
Contributor

tACK 1075820.

Works for me, albeit all keys on the openpgp.org server seem to be expired.

@fanquake fanquake merged commit 094d9fd into bitcoin:master Apr 20, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 22, 2022
1075820 doc: Add gpg key import instructions for Windows (Dave Scotese)

Pull request description:

  This is a single commit to replace the three commits from bitcoin#23916

  I propose this change so that Windows users can more easily import signers' keys.

ACKs for top commit:
  sipsorcery:
    tACK 1075820.

Tree-SHA512: 7d4ec77ce10f751748c49f1453fa8baf0976b15af4f87dc27f4e2715ad73fbd7dc1f07fcf3e660d63a6b9eb895a5e4105774613d39a2328f73b92d9e6cff4ebd
@dscotese dscotese deleted the dscotese-patch-1 branch April 22, 2022 21:23
@bitcoin bitcoin locked and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants