lint: Convert Python dead code linter test to Python #24778
Conversation
| vulture_args = ['vulture', '--min-confidence=100'] + files | ||
|
|
||
| try: | ||
| check_output(vulture_args, stderr=STDOUT) |
There was a problem hiding this comment.
Will this print the error? I'd guess no
There was a problem hiding this comment.
Hm, for me it does. It doesn't for you?
(faked to get an alert)
$ test/lint/lint-python-dead-code.py
/Users/FJ/projects/clones/bitcoin/test/lint/lint-python-dead-code.py:26: unsatisfiable 'if' condition (100% confidence)
Python dead code detection found some issues
There was a problem hiding this comment.
Thanks for testing and confirming. I just assumed that redirecting stderr to stdout and then capturing stdout, which is done by check_output, which discards the return value here, would also drop the stderr.
This is also what the documentation says:
https://docs.python.org/3/library/subprocess.html#subprocess.check_output
To also capture standard error in the result, use
stderr=subprocess.STDOUT
Not sure what to do now. Are you trying to trick me into installing vulture? 🤔
There was a problem hiding this comment.
Oh, sorry. I missed the e.output.decode two lines below. 🤦♂️
|
review ACK 076cd68 The three (3) CI failures are unrelated and can be ignored (:smiling_face_with_tear:) |
…thon 076cd68 lint: Convert Python dead code linter to Python (Fabian Jahr) Pull request description: The new python version should produce the exact same output as the bash version but be easier to maintain. ACKs for top commit: MarcoFalke: review ACK 076cd68 Tree-SHA512: 6d71a5230d612a981958fb6e178214240b09e842ffe35e207cbbda870ca35476626bf832f55d96f2fc7323a2875935edfee30cacef659a8e6ec4bbb28ff6e36a
The new python version should produce the exact same output as the bash version but be easier to maintain.