ci: Add clang-tidy task #24753
Merged
ci: Add clang-tidy task #24753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK |
|
Concept ACK (given that this doesn't cause false positives or spurious failures) |
|
If this task fails because clang-tidy doesn't work, we'll need to revert 67f654e as well. If there are silent merge conflicts, I think we can handle them as they arise. Worst case is we ignore the red status of the task for a few days. |
|
(And before merging this pull, make sure to re-run the tidy task to be sure about silent mere conflicts) |
fanquake
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
ACK fab24f8
(And before merging this pull, make sure to re-run the tidy task to be sure about silent mere conflicts)
Rebooted in https://cirrus-ci.com/task/5864889825624064.
|
Concept ACK |
🟢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24747