refactor: followup of remove -deprecatedrpc=addresses flag #24673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Mar 26, 2022
maflcko
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
review ACK 9aad284 😼
Show signature
Signature:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
review ACK 9aad2844aa7047121e72cb0bd416cc14101e2b7c 😼
-----BEGIN PGP SIGNATURE-----
iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUigxAwAuyqNsS2+EPh36vJ7QjbJzWcX1/55TU4yjULBwisAqfcoU06nfp5nmlWB
lJ7y4iJJ/ZgcS/XP5Lf3yCKz6KmnViT1T6CGrEVsIFnZQ70cyzMm+Ikt2NkeDZE5
f8QqOW6wucqWC4kt8Cu9557cuwYQy7lkk7fZdNcOQhN8PC0J2MKp6VOf3Q63cQYF
HJmM5cXeo0e5+O+k+aAKABxOEjV5dJH8dKXZfPVgb8jeZuHlm1PTvRsIulWYWPRg
WbZXkRcN/+v0EEetVa8IhYV4tWpoiWzHXrGLnTo4MzDttsL7PFVKba3Pv01iXflx
eY+wbE6W4wwYfTn9S+UwHFA5MolNeuwMnC2N1MWuI6HBMqQ2SilP1zbb5bX2QZby
VLiJ4UB8pMDWqY2mBsDEfGKscgdOR6qK38zH8iFmfWIwKphFT5sRzTHR2f3rALmN
u3NnyMcmn+YvWyDgyTWC/e2g2TQeIAHeux9wQHrcyAXqvOw9qtTab5EE1FexLk/T
JdbYgGFz
=/ATi
-----END PGP SIGNATURE-----
|
re-ACK 9563a64 🕓 Show signatureSignature: |
|
Post merge review ACK 9563a64 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've cherry-picked some of the commits out of #22924, and made minor changes (like fixing named args).