refactor: remove unused boost include in bitcoin-util.cpp #24674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This header was included since the introduction of bitcoin-util in commit 13762bc, but boost was actually never used (see `git log -S boost ./src/bitcoin-util.cpp`).
|
review ACK 3bb9627 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 2, 2022
…-util.cpp 3bb9627 refactor: remove unused boost header include in bitcoin-util.cpp (Sebastian Falbesoner) Pull request description: This header was included since the introduction of bitcoin-util in commit 13762bc, but boost was actually never used (see `git log -S boost ./src/bitcoin-util.cpp`). Cherry-picked out of bitcoin#22953, which currently needs rebase. This commit could just be merged on its own. ACKs for top commit: MarcoFalke: review ACK 3bb9627 Tree-SHA512: 201ee1aa4d49074056654203db73a473479c2b92c49df8dbf8e35979f85178013c66540a665f0f6dc0a2efef88eb091e2b088bebff85d840033dffd8ae719349
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This header was included since the introduction of bitcoin-util in
commit 13762bc, but boost was
actually never used (see
git log -S boost ./src/bitcoin-util.cpp).Cherry-picked out of #22953, which currently needs rebase. This commit could just be merged on its own.