Skip to content

build: fix copypasta in OpenBSD C{XX} flags #24604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2022
Merged

build: fix copypasta in OpenBSD C{XX} flags #24604

merged 1 commit into from
Mar 25, 2022

Conversation

fanquake
Copy link
Member

Introduced in #23998.

@laanwj
Copy link
Member

laanwj commented Mar 17, 2022

Concept ACK. It's kind of curious that it worked fine without this, so I'm not sure how to test.

@fanquake fanquake mentioned this pull request Mar 17, 2022
Merged
hebasto
hebasto approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 28f17c1, I have reviewed the code and it looks OK, not tested on OpenBSD though.

It's kind of curious that it worked fine without this, so I'm not sure how to test.

I think changes in CFLAGS and CXXFLAGS are not so critical at all.

@fanquake
Copy link
Member Author

Concept ACK. It's kind of curious that it worked fine without this, so I'm not sure how to test.

The missing -pipe isn't a big issue as it may only provide some speedup:

-pipe
Use pipes rather than temporary files for communication between the various stages of compilation. This fails to work on some systems where the assembler is unable to read from a pipe; but the GNU assembler has no trouble.

The missing -O2 was likely compensated for by autotools automatically using -O2 when building just about all packages.

@fanquake fanquake merged commit 4aaa74e into bitcoin:master Mar 25, 2022
@fanquake fanquake deleted the openbsd_copy_pasta branch March 25, 2022 08:31
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 2, 2022
@fanquake
Merge bitcoin#24604: build: fix copypasta in OpenBSD C{XX} flags
7449f8c 
28f17c1 build: fix copypasta in OpenBSD C{XX} flags (fanquake)

Pull request description:

  Introduced in bitcoin#23998.

ACKs for top commit:
  hebasto:
    ACK 28f17c1, I have reviewed the code and it looks OK, not tested on OpenBSD though.

Tree-SHA512: d905161534075f518c8924d3c42cca7ff8d4898e559f1daa9bd03dac95b109b2c3e76790fb8bc65b9e45e8a59566825afbf4dc3734ad74617dfdf797430e486b
@bitcoin bitcoin locked and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto approved these changes

Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanquake @laanwj @hebasto