Move txoutproof RPCs to txoutproof.cpp #24582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
fa60026 to
fac9669
Compare
This was referenced Mar 17, 2022
fac9669 to
fa2d176
Compare
|
ACK fa2d176 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 24, 2022
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 24, 2023
Summary: The txoutproof RPCs don't really fit into rawtransaction.cpp, as they deal with txids, not with raw transactions. As they are placed in the blockchain RPC category, they could be moved there. However, blockchain.cpp already takes about 20 seconds to compile (and rawtransaction.cpp even longer), so move them to a separate file. Can be reviewed with `--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space` This is a backport of [[bitcoin/bitcoin#24582 | core#24582]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D13051
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The txoutproof RPCs don't really fit into
rawtransaction.cpp, as they deal with txids, not with raw transactions. As they are placed in theblockchainRPC category, they could be moved there. However,blockchain.cppalready takes about 20 seconds to compile (andrawtransaction.cppeven longer), so move them to a separate file.Can be reviewed with
--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space.