-
Notifications
You must be signed in to change notification settings - Fork 37.8k
build: Move guix time machine to prelude #24489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Move guix time machine to prelude #24489
Conversation
This deduplicates some code, and enforces consistency of the time machine configuration between scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK. The two removed sections are the same as the added section.
--keep-failed \ | ||
--fallback \ | ||
${SUBSTITUTE_URLS:+--substitute-urls="$SUBSTITUTE_URLS"} \ | ||
${ADDITIONAL_GUIX_COMMON_FLAGS} ${ADDITIONAL_GUIX_TIMEMACHINE_FLAGS} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked and all these flags come from the user (and are documented in README.md
), not from the script itself.
Guix Build: bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
155fcdd2203668e57bd0015cabdc39ae3baf235f94a3f3d02fcc7bcde3de981e guix-build-6833aceac97d/output/aarch64-linux-gnu/SHA256SUMS.part
d520853cd5be19e6d760fa4cca78ecb48382e652b5d810872d164fa3b7f0e7be guix-build-6833aceac97d/output/aarch64-linux-gnu/bitcoin-6833aceac97d-aarch64-linux-gnu-debug.tar.gz
918a83e18e37685e11d9618dd3bdfe8697fb176f3e724fc351572bb84436326f guix-build-6833aceac97d/output/aarch64-linux-gnu/bitcoin-6833aceac97d-aarch64-linux-gnu.tar.gz
f3eb59ae3d8a262cbece8c3d7ec2e7710fe4c6b6e71eaed59e2211935404104b guix-build-6833aceac97d/output/arm-linux-gnueabihf/SHA256SUMS.part
f0add7e0e11b39561ec2913684b782c85a452036463970aa83be747a0356c37e guix-build-6833aceac97d/output/arm-linux-gnueabihf/bitcoin-6833aceac97d-arm-linux-gnueabihf-debug.tar.gz
fe997e7cb644b50c2566e68ef2492c00f5d4f8f04ca256af95417f0de029437e guix-build-6833aceac97d/output/arm-linux-gnueabihf/bitcoin-6833aceac97d-arm-linux-gnueabihf.tar.gz
417cb920b8e8ca441b22c17000e0f5d9142c989cbcb1ba0e5e4d5eaef7ce2dce guix-build-6833aceac97d/output/arm64-apple-darwin/SHA256SUMS.part
1722e9c7c390057c245c07afa4b91e89090122be5fe50a352135dfe604cad524 guix-build-6833aceac97d/output/arm64-apple-darwin/bitcoin-6833aceac97d-arm64-apple-darwin.tar.gz
5f835ef3eb75fda045efb388665edaad7bfc48b4ab37f0e1aa427491b8cc7c20 guix-build-6833aceac97d/output/arm64-apple-darwin/bitcoin-6833aceac97d-osx-unsigned.dmg
27b23fa46d020537de5195245ff7f27d1017dd93ea88527fca5a3bf281265b65 guix-build-6833aceac97d/output/arm64-apple-darwin/bitcoin-6833aceac97d-osx-unsigned.tar.gz
42fa984604d9bfd3b34c85a5af5c885de23d2142c15093af4bd37b35ca4bdecf guix-build-6833aceac97d/output/dist-archive/bitcoin-6833aceac97d.tar.gz
d9bff63671e92686a3c473f76545264f844813cfe7fbc7b15fc53b7583230555 guix-build-6833aceac97d/output/powerpc64-linux-gnu/SHA256SUMS.part
cc96356c0c26fa68557e8548a1acb0344980021c14a72ac22684c0a6e9658758 guix-build-6833aceac97d/output/powerpc64-linux-gnu/bitcoin-6833aceac97d-powerpc64-linux-gnu-debug.tar.gz
e7c68fec3e640a7c526ed3eaf3b88e0b4c4b0e722c6841f543001ac546657039 guix-build-6833aceac97d/output/powerpc64-linux-gnu/bitcoin-6833aceac97d-powerpc64-linux-gnu.tar.gz
5f4e99cfd7fb126fb68b5b94b070d2a724b456103f595565b85e2a93b87e6302 guix-build-6833aceac97d/output/powerpc64le-linux-gnu/SHA256SUMS.part
136418256a02dffd457940fb60b23aeacdf7bd7b3088947f22db99f61698177e guix-build-6833aceac97d/output/powerpc64le-linux-gnu/bitcoin-6833aceac97d-powerpc64le-linux-gnu-debug.tar.gz
b366a58685075adf6d9881e8ec4e29bfe5d44c72962c7de9ed61b15099c68c13 guix-build-6833aceac97d/output/powerpc64le-linux-gnu/bitcoin-6833aceac97d-powerpc64le-linux-gnu.tar.gz
e47f602248c0c67fc65a0e704fd3c50ccdc20288e9f37703d08e90af56d764b1 guix-build-6833aceac97d/output/riscv64-linux-gnu/SHA256SUMS.part
524d6236fa3c401effd13f7027b968c1fc9834e8e6f9e67b02553009085c2f9d guix-build-6833aceac97d/output/riscv64-linux-gnu/bitcoin-6833aceac97d-riscv64-linux-gnu-debug.tar.gz
000dcb6106da49c8f200768bcc70b7a00ada5d50d21ffa9afac097c8dc340bd7 guix-build-6833aceac97d/output/riscv64-linux-gnu/bitcoin-6833aceac97d-riscv64-linux-gnu.tar.gz
4c4055ba640481254e84c0cb2802fee9892d85289a76db2b89fd43de41c45f42 guix-build-6833aceac97d/output/x86_64-apple-darwin/SHA256SUMS.part
38b59695bdf2a4ed216c7aabe6da4aefa1b5db2afacac8ee9d92e0eb7229d21d guix-build-6833aceac97d/output/x86_64-apple-darwin/bitcoin-6833aceac97d-osx-unsigned.dmg
b1efd3d59369ddad3cfbb4d437e3a6ee5653738075dfca5c770894e2896c1c1e guix-build-6833aceac97d/output/x86_64-apple-darwin/bitcoin-6833aceac97d-osx-unsigned.tar.gz
df1e822b041024435c6f98fa4dc29429e70946d12710357b90dddbf70b1ea750 guix-build-6833aceac97d/output/x86_64-apple-darwin/bitcoin-6833aceac97d-osx64.tar.gz
96fa2cb73fc2305268e17c3509f8deeae9bc2c947a3f65feb279219e083140ba guix-build-6833aceac97d/output/x86_64-linux-gnu/SHA256SUMS.part
c8a8c4056e2694eba0ac2b2c186e7b793eede84acf237a5db30d99e97f1513a0 guix-build-6833aceac97d/output/x86_64-linux-gnu/bitcoin-6833aceac97d-x86_64-linux-gnu-debug.tar.gz
295d96477e286996de2301993016f133c744153b6895a4c25da6ac9c90a85f7b guix-build-6833aceac97d/output/x86_64-linux-gnu/bitcoin-6833aceac97d-x86_64-linux-gnu.tar.gz
9b73b4e42b13e33c2b10273ac7d30837c1163e770b32e531541ccef4a7097394 guix-build-6833aceac97d/output/x86_64-w64-mingw32/SHA256SUMS.part
56926b9ebe74acfc0e92a57cc9eba065a98ccd1fc4e360b06ff6252ea33cf237 guix-build-6833aceac97d/output/x86_64-w64-mingw32/bitcoin-6833aceac97d-win-unsigned.tar.gz
c402149cc3ffb546e7405a8c3f7883220dec3f86abb7b305f9912942bb026beb guix-build-6833aceac97d/output/x86_64-w64-mingw32/bitcoin-6833aceac97d-win64-debug.zip
85fc02766a30e0b5ab70605cf46a8bb725a1aef9cf802a71af9495eab5d3d4f6 guix-build-6833aceac97d/output/x86_64-w64-mingw32/bitcoin-6833aceac97d-win64-setup-unsigned.exe
dcc110bc55d79f40cc0efb0638bcb84b559a0d94f4745bf418a664f686b00673 guix-build-6833aceac97d/output/x86_64-w64-mingw32/bitcoin-6833aceac97d-win64.zip |
ACK 6833ace |
|
ACK 6833ace |
6833ace build: Move guix time machine to prelude (laanwj) Pull request description: This deduplicates some code, and enforces consistency of the time machine configuration between scripts. ACKs for top commit: achow101: ACK 6833ace dongcarl: ACK 6833ace Tree-SHA512: c02ded154cdb982293101986ef863d46554fc428eb5617bee0288dbef0543f994de5044123ac9958e455d0d24276a1c4512149a10dd1efaca8677c8f6b74b0a9
This deduplicates some code, and enforces consistency of the time machine configuration between scripts.