Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Mar 2, 2022

No strong reason for the bump, but this makes it easier to experiment with cpp20, see #24169 (comment)

@fanquake fanquake added this to the 24.0 milestone Mar 2, 2022
@Empact
Copy link
Contributor

Empact commented Mar 3, 2022

Code Review ACK fa7dada

Compared file with latest here: http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_cxx_compile_stdcxx.m4
Reviewed commits from 44f18a92d5b6956997a9765e62711d5c70d4c2b1 "Unbreak testing for -std=c++11 with clang++" here: http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=history;f=m4/ax_cxx_compile_stdcxx.m4

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa7dada

@fanquake fanquake merged commit cc70f65 into bitcoin:master Mar 4, 2022
@fanquake
Copy link
Member

fanquake commented Mar 4, 2022

Guix build:

bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
ba8ececc3b50a0d36ccc2e9297150a4edd0f77892d532d3de82f789539d866de  guix-build-fa7dada1fc7e/output/aarch64-linux-gnu/SHA256SUMS.part
d46bf632e68ef4510ff62d55d526c14555a18923df023855c4cf9cdb8fb3b23f  guix-build-fa7dada1fc7e/output/aarch64-linux-gnu/bitcoin-fa7dada1fc7e-aarch64-linux-gnu-debug.tar.gz
5b0a8662c16dabbd59ce04df35bd81e41935027e8542073acf5bb22a1a30a869  guix-build-fa7dada1fc7e/output/aarch64-linux-gnu/bitcoin-fa7dada1fc7e-aarch64-linux-gnu.tar.gz
6aadae8fc208c5bea4d037c42c874321ccf5d0de838c290b234a106f639d8cbe  guix-build-fa7dada1fc7e/output/arm-linux-gnueabihf/SHA256SUMS.part
aa188be8580f9339e10a6ffe1a4cc736e94d9e429d155d5c3858ea524183edb5  guix-build-fa7dada1fc7e/output/arm-linux-gnueabihf/bitcoin-fa7dada1fc7e-arm-linux-gnueabihf-debug.tar.gz
a588a4df1da8813446ec0f79afc75e24d5f9c389bd6a764fe47ead3a96423f10  guix-build-fa7dada1fc7e/output/arm-linux-gnueabihf/bitcoin-fa7dada1fc7e-arm-linux-gnueabihf.tar.gz
652c8d2f0c13bd324a755b0c34e1debab6276dacfed032b7039d3648415df9fb  guix-build-fa7dada1fc7e/output/arm64-apple-darwin/SHA256SUMS.part
c41faaa5ff3e661e9eb9cd41ef6beab7176a88980fb7b1eb994385ef3f9b2dc4  guix-build-fa7dada1fc7e/output/arm64-apple-darwin/bitcoin-fa7dada1fc7e-arm64-apple-darwin.tar.gz
c000c91b4af73ee26e6c89050541408b8f4dfa591eadcff6cf5f7a210016ecb2  guix-build-fa7dada1fc7e/output/arm64-apple-darwin/bitcoin-fa7dada1fc7e-osx-unsigned.dmg
59618b8295b8e917524a5fb0cd4562395fd0f7f7a05c6868eb4489a5cdd6d700  guix-build-fa7dada1fc7e/output/arm64-apple-darwin/bitcoin-fa7dada1fc7e-osx-unsigned.tar.gz
eb9104356f3f6f52d7799bd68ca994e1fe5a95960dda922d34f9dec455508123  guix-build-fa7dada1fc7e/output/dist-archive/bitcoin-fa7dada1fc7e.tar.gz
6afa0ff58c38b8abb0cea7cd64a8476f94fc790537fc5b2c16e2368af1c21872  guix-build-fa7dada1fc7e/output/powerpc64-linux-gnu/SHA256SUMS.part
eeff74d3d5aaa9cbe47cda0d64de2b53cb9a0a11ee15f7998b934b3fe7745322  guix-build-fa7dada1fc7e/output/powerpc64-linux-gnu/bitcoin-fa7dada1fc7e-powerpc64-linux-gnu-debug.tar.gz
0915e2c489849c25aee32f7ced239b4ab57060db0247b05cd2e6fe0903ae119a  guix-build-fa7dada1fc7e/output/powerpc64-linux-gnu/bitcoin-fa7dada1fc7e-powerpc64-linux-gnu.tar.gz
1f6a979c3629f8d4d3a5eba7e007702ef844b414b41fc36b34d23f793028c1ad  guix-build-fa7dada1fc7e/output/powerpc64le-linux-gnu/SHA256SUMS.part
cad84c953377bc732ecf6c4476e916809a8c913dbc647555178a402cd1ab81f4  guix-build-fa7dada1fc7e/output/powerpc64le-linux-gnu/bitcoin-fa7dada1fc7e-powerpc64le-linux-gnu-debug.tar.gz
0bbb1b8f6db31587e8e1ad4e8b363c5d889eba4a653644d5a969560540679b62  guix-build-fa7dada1fc7e/output/powerpc64le-linux-gnu/bitcoin-fa7dada1fc7e-powerpc64le-linux-gnu.tar.gz
cf0a15cbf673894c9450a59f2ab5c1f690e2ce0171396ef3d621dcfd4e968a6c  guix-build-fa7dada1fc7e/output/riscv64-linux-gnu/SHA256SUMS.part
2950ec4fd09c14c7e4c8a6bfa60ccd9fd35276f18ce8ab7d506414e2820b481b  guix-build-fa7dada1fc7e/output/riscv64-linux-gnu/bitcoin-fa7dada1fc7e-riscv64-linux-gnu-debug.tar.gz
9adb370b8326f62ce2401533435f9b331e0954e3358998c765bfbc9169a44ac6  guix-build-fa7dada1fc7e/output/riscv64-linux-gnu/bitcoin-fa7dada1fc7e-riscv64-linux-gnu.tar.gz
e03d28314b79701b392cb7ba75e30e52af1ab2f548675a32c6a8f26004b6824b  guix-build-fa7dada1fc7e/output/x86_64-apple-darwin/SHA256SUMS.part
6965ef3c70356f09b7905b3fb32c3238e69b2f38231cde1fe0e70b0152a70b2c  guix-build-fa7dada1fc7e/output/x86_64-apple-darwin/bitcoin-fa7dada1fc7e-osx-unsigned.dmg
7cd4f1a15f85962e6ea89301c8f7d9064ba83f04dc55b0cd8a743a2a3c4104fc  guix-build-fa7dada1fc7e/output/x86_64-apple-darwin/bitcoin-fa7dada1fc7e-osx-unsigned.tar.gz
08db6d3f080c8d7368b49ce09fe639420063541328640f4a005fd7d2e7e91daa  guix-build-fa7dada1fc7e/output/x86_64-apple-darwin/bitcoin-fa7dada1fc7e-osx64.tar.gz
b41d290a357bb2b119d76fc78a77f3cf8bfd8f17ba8d8b9bf8377e174d1fdd22  guix-build-fa7dada1fc7e/output/x86_64-linux-gnu/SHA256SUMS.part
6b7849be55d4a8a549c54a3955bc1beaf5b4b62beae912a5215828896e1639e4  guix-build-fa7dada1fc7e/output/x86_64-linux-gnu/bitcoin-fa7dada1fc7e-x86_64-linux-gnu-debug.tar.gz
02a92d1530fa54943248956e2710e5cbd85ce14a55badf61671329c184d62696  guix-build-fa7dada1fc7e/output/x86_64-linux-gnu/bitcoin-fa7dada1fc7e-x86_64-linux-gnu.tar.gz
7b414f85bbce735658c46eb414cf10f632fa9589468d91464032ba70741dd97c  guix-build-fa7dada1fc7e/output/x86_64-w64-mingw32/SHA256SUMS.part
e62b51ff199d7ca773964ed5e62940e3da409e5228a287466c58676487e53489  guix-build-fa7dada1fc7e/output/x86_64-w64-mingw32/bitcoin-fa7dada1fc7e-win-unsigned.tar.gz
d22fb725fbc996136b1aa181738e8a06739e51bd4fd5314161bab34a73985848  guix-build-fa7dada1fc7e/output/x86_64-w64-mingw32/bitcoin-fa7dada1fc7e-win64-debug.zip
3b16027b61fff319b82b802f239cb19def107235968df0c8d5e1a6f8b6a6f279  guix-build-fa7dada1fc7e/output/x86_64-w64-mingw32/bitcoin-fa7dada1fc7e-win64-setup-unsigned.exe
f6182c2b90d0ae5b8e6c6ad9c3c953ede96c31c60837235efb50e6da53ae5859  guix-build-fa7dada1fc7e/output/x86_64-w64-mingw32/bitcoin-fa7dada1fc7e-win64.zip

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 5, 2022
fa7dada build: update ax_cxx_compile_stdcxx to serial 14 (MarcoFalke)

Pull request description:

  No strong reason for the bump, but this makes it easier to experiment with cpp20, see bitcoin#24169 (comment)

ACKs for top commit:
  Empact:
    Code Review ACK bitcoin@fa7dada
  fanquake:
    ACK fa7dada

Tree-SHA512: bd3e884bae5319d434520a2947608913c3884de89aa563aa46ef17ba4e5b41ba209bd4780c8eaf81648297b2dc9534803be88d1b214ad05a93ee5992bee887c0
@maflcko maflcko deleted the 2203-ax_cxx_compile_stdcxx-😈 branch March 7, 2022 08:36
@bitcoin bitcoin locked and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants