blockman: Properly guard blockfile members #24456
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Mar 2, 2022
Merged
Closed
422f1f3 to
1b95be4
Compare
This was referenced Mar 8, 2022
This was referenced Mar 12, 2022
1b95be4 to
f097cc3
Compare
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Add GUARDED_BY(cs_LastBlockFile) annotations to:
- m_blockfile_info
- m_last_blockfile
- m_check_for_pruning
Add locking annotations as appropriate.
[META] Some of these LOCK annotations will be turned into a
AssertLockHeld+EXCLUSIVE_LOCKS_REQUIRED combo in the next commit
It is only used in CChainState::PreciousBlock with ::cs_main locked.
|
Not going to nurse this PR anymore, feel free to take for yourself! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logically a rebase of: #15191
Based on and split off from: #22564
Last commit arose out of review: #22564 (comment)