validation: Add missing cs_{LastBlockFile,nBlockSequenceId} locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotations. #15191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1b22ec to
a17a089
Compare
|
@MarcoFalke Could this one get a release milestone? :-) |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
a17a089 to
434c356
Compare
|
Rebased! |
|
@MarcoFalke Should this locking PR be closed? Please advice. |
|
Concept ACK |
… UnloadBlockIndex(). Add missing locking annotation for nLastBlockFile and fCheckForPruning.
…). Add missing locking annotation for nBlockSequenceId.
434c356 to
575720c
Compare
| Needs rebase |
|
Wondering if this change is still necessary and conceptually sound? |
|
I haven't looked at this since closing, but IIRC I closed it due to lack of progress only (only one Concept ACK over seven months 😢 ). Feel free to pick it up: I'd be glad to review :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cs_LastBlockFilelocks inPruneAndFlush()andUnloadBlockIndex().nLastBlockFileandfCheckForPruning.nBlockSequenceIdwhich is guarded bycs_nBlockSequenceId.cs_nBlockSequenceIdlock inUnloadBlockIndex().