Skip to content

Avoid implicit-integer-sign-change in VerifyLoadedChainstate #24403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2022
Merged

Avoid implicit-integer-sign-change in VerifyLoadedChainstate #24403

merged 2 commits into from
Feb 28, 2022

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Feb 21, 2022

This happens when checking all blocks (-1).

To test:

./configure CC=clang CXX=clang++ --with-sanitizers=undefined,integer
make
UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1" ./test/functional/rpc_blockchain.py

@maflcko maflcko mentioned this pull request Feb 21, 2022
Merged
theStack
theStack approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-review ACK fa79916

benthecarman
benthecarman reviewed Feb 23, 2022
View reviewed changes
src/node/chainstate.cpp
Comment on lines +132 to +133
int check_blocks,
int check_level,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should assert(check_blocks >= 0) and assert(check_level >= 0) be added?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this will crash the test

brunoerg
brunoerg approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crACK fa79916

@maflcko maflcko merged commit c7da61d into bitcoin:master Feb 28, 2022
@maflcko maflcko deleted the 2202-intB branch February 28, 2022 11:50
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 1, 2022
Merge bitcoin#24403: Avoid implicit-integer-sign-change in VerifyLoad…
089d5bf 
…edChain…
@bitcoin bitcoin locked and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
3 more reviewers

@benthecarman benthecarman benthecarman left review comments

@theStack theStack theStack approved these changes

@brunoerg brunoerg brunoerg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maflcko @theStack @benthecarman @brunoerg