doc: improve -netinfo help based on feedback from users and devs #24360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clarify that the peer counts table is of reachable networks - a few other clarifications
|
Concept ACK |
laanwj
reviewed
Feb 17, 2022
| " 1 - Like 0 but with a peers listing (without address or version columns)\n" | ||
| " 0 - Peer counts for each reachable network as well as for block relay peers\n" | ||
| " and manual peers, and the list of local addresses and ports\n" | ||
| " 1 - Like 0 but preceded by a peers listing (without address and version columns)\n" | ||
| " 2 - Like 1 but with an address column\n" | ||
| " 3 - Like 1 but with a version column\n" | ||
| " 4 - Like 1 but with both address and version columns\n" |
There was a problem hiding this comment.
Heh we kind of went out of hand with the number of combinations here.
|
Code review ACK a4da16f |
kristapsk
approved these changes
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify which networks are displayed by the peer counts table (reachable networks; follow-up to #23324) in response to questions received over the past months, and a few other improvements.