Skip to content

Conversation

anshu-khare-design
Copy link

This PR is to resolve issue 20576. It focuses on introducing different levels of net logging. As a starting point, as mentioned in the issue #20576 , it creates separate lower-frequency, important peer-level events (netpeers) from very high-frequency message-level passing (netmessages).

@DrahtBot DrahtBot added the P2P label Feb 5, 2022
@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 5, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #24456 (blockman: Properly guard blockfile members by dongcarl)
  • #24230 (indexes: Stop using node internal types and locking cs_main, improve sync logic by ryanofsky)
  • #24220 (validation: don't re-acquire cs_main during IBD in CChainState::IsInitialBlockDownload() by jonatack)
  • #24178 (p2p: Respond to getheaders if we have sufficient chainwork by sdaftuar)
  • #24008 (assumeutxo: net_processing changes by jamesob)
  • #23443 (p2p: Erlay support signaling by naumenkogs)
  • #22778 (net processing: Reduce resource usage for inbound block-relay-only connections by jnewbery)
  • #22564 (refactor: Move mutable globals cleared in ::UnloadBlockIndex to BlockManager by dongcarl)
  • #21878 (Make all networking code mockable by vasild)
  • #21160 (net/net processing: Move tx inventory into net_processing by jnewbery)
  • #20799 (net processing: Only support version 2 compact blocks by jnewbery)
  • #20726 (p2p: Add DISABLETX message for negotiating block-relay-only connections by sdaftuar)
  • #20196 (net: fix GetListenPort() to derive the proper port by vasild)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 3, 2022

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

@laanwj
Copy link
Member

laanwj commented Apr 14, 2022

Thanks! But instead of splitting up net specifically, I think a better option is to add logging verbosity in general. Closing in favor of #24464.

@laanwj laanwj closed this Apr 14, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants