build: Make $(package)_*_env available to all $(package)_*_cmds
#24279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccdd459 to
c86da12
Compare
$(package)_*_env available to all $(package)_*_cmds
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Feb 7, 2022
Guix builds: |
c86da12 to
626b79b
Compare
|
Rebased c86da12 -> 626b79b (pr24279.01 -> pr24279.02) on top of the merged #24348. |
Guix builds: |
|
Updated 626b79b -> c8d338d (pr24279.02 -> pr24279.03):
|
Guix builds on
|
|
Guix hashes: x86: arm64: |
|
Are you still working on this? |
I am. This PR fixes a bug in our depends build system, and it's ready for further reviewing. |
|
Friendly ping :) |
fanquake
reviewed
Dec 7, 2022
depends/packages/qt.mk
Outdated
| @@ -263,7 +263,6 @@ endef | |||
|
|
|||
| define $(package)_config_cmds | |||
| export PKG_CONFIG_SYSROOT_DIR=/ && \ | |||
There was a problem hiding this comment.
While we are here, should we also move PKG_CONFIG_SYSROOT_DIR into _config_env?
3f90dde to
affbf58
Compare
|
Updated 3f90dde -> affbf58 (pr24279.04 -> pr24279.05): |
|
Guix builds: |
|
Guix Build (aarch64): 0c15350386dcec6e7a9fb4640c481fdd765571eee3da35ff148899c51555cb46 guix-build-affbf58a1e52/output/aarch64-linux-gnu/SHA256SUMS.part
b152c462526637d0fb9dc46e0c273de843a2abbb02fae4f480e5bd77d8de59bd guix-build-affbf58a1e52/output/aarch64-linux-gnu/bitcoin-affbf58a1e52-aarch64-linux-gnu-debug.tar.gz
f14c25104a3b51bc82cb108683292e64d6c27060acab930412c25425a1a3bd1a guix-build-affbf58a1e52/output/aarch64-linux-gnu/bitcoin-affbf58a1e52-aarch64-linux-gnu.tar.gz
53c66796a2c2f7bad4c8d5f278c84b415e96d63f9e6cbad4236b453cf4d01c2f guix-build-affbf58a1e52/output/arm-linux-gnueabihf/SHA256SUMS.part
84fd91ebfcaa5b87ea56c510e0d0cb058987713973b0d27fc5aca5350f605f9a guix-build-affbf58a1e52/output/arm-linux-gnueabihf/bitcoin-affbf58a1e52-arm-linux-gnueabihf-debug.tar.gz
c343fd593204132a0d7e3df8a6550d3b58912c21f56ab14635cdc27644d780e4 guix-build-affbf58a1e52/output/arm-linux-gnueabihf/bitcoin-affbf58a1e52-arm-linux-gnueabihf.tar.gz
e6470535a01054e783177f7b5ac8873e69a8c2726174c988410ea38e9551afd9 guix-build-affbf58a1e52/output/arm64-apple-darwin/SHA256SUMS.part
adbea1d95a6e57dc6d470c760cb03e7a27cbd44227c497bdfb78382ad4f97ba5 guix-build-affbf58a1e52/output/arm64-apple-darwin/bitcoin-affbf58a1e52-arm64-apple-darwin-unsigned.dmg
fdd0c22d1f34a44234b3e41ed236d9f69ee8f1a9f26f6a158bbcfb16e823977a guix-build-affbf58a1e52/output/arm64-apple-darwin/bitcoin-affbf58a1e52-arm64-apple-darwin-unsigned.tar.gz
7e889d308b77c19303eaf0ae7285b369d4437bf0a23ddf86cdcade66956ae54c guix-build-affbf58a1e52/output/arm64-apple-darwin/bitcoin-affbf58a1e52-arm64-apple-darwin.tar.gz
fa8574dabfa9c866b64f2eedf23e42d70406f1e040d30c33197ebf28842139fc guix-build-affbf58a1e52/output/dist-archive/bitcoin-affbf58a1e52.tar.gz
5a64fb39f4eac60b11591a85797230cd596d217087dfe50d41e556d2b94e99fd guix-build-affbf58a1e52/output/powerpc64-linux-gnu/SHA256SUMS.part
5fc641b36ba2236a2dabd012d406106eef09ecdd569587bd3f5762673b321185 guix-build-affbf58a1e52/output/powerpc64-linux-gnu/bitcoin-affbf58a1e52-powerpc64-linux-gnu-debug.tar.gz
9dc88283445a3ccc16a72a85d2718aee95b190e7c1ce2e7451cc8befd233237d guix-build-affbf58a1e52/output/powerpc64-linux-gnu/bitcoin-affbf58a1e52-powerpc64-linux-gnu.tar.gz
eb73f47ffb50e8d6027d6f0f83cec52669b4b8ea6b5ff4a73305618889183bea guix-build-affbf58a1e52/output/powerpc64le-linux-gnu/SHA256SUMS.part
7022959bce165310b9ffda49ff98f6d098915bb14ec86aa9484045fd92b8dc7f guix-build-affbf58a1e52/output/powerpc64le-linux-gnu/bitcoin-affbf58a1e52-powerpc64le-linux-gnu-debug.tar.gz
646c3e154f7d8d608a2ad93eaf7b4836abf28143270aa19d76068c9307578772 guix-build-affbf58a1e52/output/powerpc64le-linux-gnu/bitcoin-affbf58a1e52-powerpc64le-linux-gnu.tar.gz
0cfab9d97decac6769de24dd9e5e9dc5d4d433c13f14716484cfb5727cd23d9d guix-build-affbf58a1e52/output/riscv64-linux-gnu/SHA256SUMS.part
d4a338f25de0cca8718b677ce95245f6e88f032c283a44bc1c46d5a892037b52 guix-build-affbf58a1e52/output/riscv64-linux-gnu/bitcoin-affbf58a1e52-riscv64-linux-gnu-debug.tar.gz
851beaf6fd881d47bd0954af8ee22e23ef3a074ca63a56709d6e8527cc01313b guix-build-affbf58a1e52/output/riscv64-linux-gnu/bitcoin-affbf58a1e52-riscv64-linux-gnu.tar.gz
496ce8af1b9d042e0c380170818be3b0a4e8ac2131b3878be0900fb4a524047b guix-build-affbf58a1e52/output/x86_64-apple-darwin/SHA256SUMS.part
09b3beafd3fa1d9d026290d75e29876dc9e1ece9e2e85bdfc22296e346705f6a guix-build-affbf58a1e52/output/x86_64-apple-darwin/bitcoin-affbf58a1e52-x86_64-apple-darwin-unsigned.dmg
5f28b4eb9bdc8fa0e5fbbf1a177994253d3e82b4dc4a1cdc1001377fa7ee45b0 guix-build-affbf58a1e52/output/x86_64-apple-darwin/bitcoin-affbf58a1e52-x86_64-apple-darwin-unsigned.tar.gz
d86358a39884cc9e48434f831397191548a51a313c0a95342502584eb4382325 guix-build-affbf58a1e52/output/x86_64-apple-darwin/bitcoin-affbf58a1e52-x86_64-apple-darwin.tar.gz
6e3b1c432fb1d87e0db1a7db17111b5cd548703350bd3acb1abef965f966c546 guix-build-affbf58a1e52/output/x86_64-linux-gnu/SHA256SUMS.part
9ef848a3d5319f75d32cec20eaaedb5575c18f68a2ef4a4de687303c130f5833 guix-build-affbf58a1e52/output/x86_64-linux-gnu/bitcoin-affbf58a1e52-x86_64-linux-gnu-debug.tar.gz
e9d762a013f547fe9bd2d675c9f60fdded54784ea73285bb9cb7ac548299d929 guix-build-affbf58a1e52/output/x86_64-linux-gnu/bitcoin-affbf58a1e52-x86_64-linux-gnu.tar.gz
2ba19870c57f6f6efa02d587ff79085990c9b9824b7708c9925d6a631013405d guix-build-affbf58a1e52/output/x86_64-w64-mingw32/SHA256SUMS.part
62d9567069156a089d70ea802d4b44a3bf3a5ad869fe649ebea564f3a50404fd guix-build-affbf58a1e52/output/x86_64-w64-mingw32/bitcoin-affbf58a1e52-win64-debug.zip
287bce6249347862033d4b403c7a4fc8211b1a5cd86b52e9836768a0d2cbf8c2 guix-build-affbf58a1e52/output/x86_64-w64-mingw32/bitcoin-affbf58a1e52-win64-setup-unsigned.exe
aab154e667389456866543d23b62e7d819bc0d09cf3f81b693aaa31743be5766 guix-build-affbf58a1e52/output/x86_64-w64-mingw32/bitcoin-affbf58a1e52-win64-unsigned.tar.gz
51f7c527bd661647868941fa1cc0de96dd93019720054004a2b2d537ed27ba97 guix-build-affbf58a1e52/output/x86_64-w64-mingw32/bitcoin-affbf58a1e52-win64.zip |
fanquake
approved these changes
Dec 8, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 8, 2022
…`$(package)_*_cmds` affbf58 build: Move environment variables into `$(package)_config_env` (Hennadii Stepanov) d44fcd3 build: Make $(package)_*_env available to all $(package)_*_cmds (Hennadii Stepanov) Pull request description: On master (1e7564e) the depends build system, which is based on pure GNU Make, works, but it lacks robustness, and in some corner cases it fails. For example, see bitcoin#22552. Another [bug](bitcoin#22719) in the depends build system has already become a problem at least two times in the past (bitcoin#16883 (comment) and bitcoin#24134). Each time the problem was solved with other means. The initial [solution](bitcoin#19882) had some discussion. Also it was discussed on the IRC meeting in #bitcoin-core-builds channel. This PR, actually, is a resurrection of it, as the bug silently struck pretty [recently](bitcoin#24134). The bug is well described in bitcoin#22719. Here is another, a bit simpler description, which requires only basic shell (bash, dash etc) experience. After creating targets by this code:https://github.com/bitcoin/bitcoin/blob/1e7564eca8a688f39c75540877ec3bdfdde766b1/depends/funcs.mk#L280 a "draft" line of recipe like `$($(1)_config_env) $(call $(1)_config_cmds, $(1))` becomes a shell command sequence `VAR1=foo VAR2=bar command1 && command2` which is supposed to be executed in a [new sub-shell](https://www.gnu.org/software/make/manual/html_node/Execution.html#Execution). Please note that `VAR1=foo VAR2=bar` part is visible for the first `command1` only (for details see shell docs). Example: ```sh $ VAR1="foo" VAR2="bar" echo "begin" && printenv VAR1 && printenv VAR2 && echo "end" begin $ echo $? 1 ``` Using the `export` command is a trivial solution: ```sh $ export VAR1="foo" VAR2="bar"; echo "begin" && printenv VAR1 && printenv VAR2 && echo "end" begin foo bar end $ echo $? 0 ``` As a [new sub-shell](https://www.gnu.org/software/make/manual/html_node/Execution.html#Execution) is invoked for each line of the recipe, there are no side effects of using `export`. It means this solution should not be considered invasive. Fixes bitcoin#22719. --- Also this PR removes no longer needed crutch from `qt.mk`. ACKs for top commit: fanquake: ACK affbf58 Tree-SHA512: 0ce2cf82870a7774bdf1592fac50857126ae47da902e349f1092d50109223be9d6a8efd5e92ec08c2ca775b17516482aabaf232378950ade36484a883acc177b
fanquake
added a commit
to bitcoin-core/gui
that referenced
this pull request
Feb 7, 2023
…imestamps deterministic 6ebe576 build: Make dependency package archive timestamps deterministic (Hennadii Stepanov) Pull request description: This PR makes testing changes like bitcoin/bitcoin#20641, bitcoin/bitcoin#21593, bitcoin/bitcoin#22142, bitcoin/bitcoin#24279, bitcoin/bitcoin#24285 as easy as comparing hashes. With this PR: ``` $ make -C depends clean $ make -C depends HOST=x86_64-w64-mingw32 $ find depends/built/x86_64-w64-mingw32 -name '*.hash' | sort | xargs cat 1f685a61cbf205f81977ecf88cba91fa1ccdfbe77ab4ec3405dcd33ceb778af4 bdb-4.8.30-ca950bd6d13.tar.gz 08a9acde276e6e5e5c8913e3ad07eeecda184a996882ae226b3ed056c7ec1b01 boost-1.80.0-b537c466dcb.tar.gz 144c6d92e4108fcc90740bee27007db58a88336a97be6367f9c8ba4cc208af27 libevent-2.1.12-stable-e13b2bdd8b8.tar.gz e3c9c9609bf32bfd460432c6ab99a64e9f8750ed775a193925ff4f5aed363e4c libnatpmp-07004b97cf691774efebe70404cf22201e4d330d-82255b84667.tar.gz 62c6a089a4b24a413eccd2f389bf4c8b0716423b0ace5e87e984069635da9f83 miniupnpc-2.2.2-c43fc4cf2f6.tar.gz 78762700066273e597698a78479a506b33532ea565d18ef561614b9fc3820cf5 qrencode-3.4.4-663de0dc628.tar.gz 5e2183faf91838510a48e6dbb4b65ae74a7d48ba1abc070b82767c4076582360 qt-5.15.5-986926343e2.tar.gz 9f8459f8d27fc3af9146712be6ba6577f15741429936504a950cc51c17da1ba8 sqlite-3380500-bec6a4d3299.tar.gz 0eca5d01d427de50be4bd57c8bb100ab69b017792c32b8733e2b20443f4c9c28 zeromq-4.3.4-8ae81bab6f4.tar.gz ``` As an example, here is an evidence that bitcoin/bitcoin#24279 is a strict refactoring change: ``` $ git fetch origin pull/24279/head $ git cherry-pick 706026838d917a3d853e03e83db040f1fd4aeb74 $ git cherry-pick 3f90ddea8a6a2061cfb347a1d77df2c0a6fa238c $ make -C depends clean $ make -C depends HOST=x86_64-w64-mingw32 $ find depends/built/x86_64-w64-mingw32 -name '*.hash' | sort | xargs cat 1f685a61cbf205f81977ecf88cba91fa1ccdfbe77ab4ec3405dcd33ceb778af4 bdb-4.8.30-c7faf31d5ca.tar.gz 08a9acde276e6e5e5c8913e3ad07eeecda184a996882ae226b3ed056c7ec1b01 boost-1.80.0-1af3dd1d99e.tar.gz 144c6d92e4108fcc90740bee27007db58a88336a97be6367f9c8ba4cc208af27 libevent-2.1.12-stable-6228a9f8534.tar.gz e3c9c9609bf32bfd460432c6ab99a64e9f8750ed775a193925ff4f5aed363e4c libnatpmp-07004b97cf691774efebe70404cf22201e4d330d-41aa6194ecc.tar.gz 62c6a089a4b24a413eccd2f389bf4c8b0716423b0ace5e87e984069635da9f83 miniupnpc-2.2.2-6a93027769c.tar.gz 78762700066273e597698a78479a506b33532ea565d18ef561614b9fc3820cf5 qrencode-3.4.4-d40cb2d45c9.tar.gz 5e2183faf91838510a48e6dbb4b65ae74a7d48ba1abc070b82767c4076582360 qt-5.15.5-120c3cb745d.tar.gz 9f8459f8d27fc3af9146712be6ba6577f15741429936504a950cc51c17da1ba8 sqlite-3380500-bbd4d813c69.tar.gz 0eca5d01d427de50be4bd57c8bb100ab69b017792c32b8733e2b20443f4c9c28 zeromq-4.3.4-df0858a19d2.tar.gz ``` ACKs for top commit: TheCharlatan: Code review ACK 6ebe576 Tree-SHA512: 20e0222781f5dcb50126c11677d0671bcdd7be144b2e528c75a02983acc494206552fb35039697ccd094de27a21b3fb439e9965c34feb8a6d74627fa20a9a5e7
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 7, 2023
…s deterministic 6ebe576 build: Make dependency package archive timestamps deterministic (Hennadii Stepanov) Pull request description: This PR makes testing changes like bitcoin#20641, bitcoin#21593, bitcoin#22142, bitcoin#24279, bitcoin#24285 as easy as comparing hashes. With this PR: ``` $ make -C depends clean $ make -C depends HOST=x86_64-w64-mingw32 $ find depends/built/x86_64-w64-mingw32 -name '*.hash' | sort | xargs cat 1f685a61cbf205f81977ecf88cba91fa1ccdfbe77ab4ec3405dcd33ceb778af4 bdb-4.8.30-ca950bd6d13.tar.gz 08a9acde276e6e5e5c8913e3ad07eeecda184a996882ae226b3ed056c7ec1b01 boost-1.80.0-b537c466dcb.tar.gz 144c6d92e4108fcc90740bee27007db58a88336a97be6367f9c8ba4cc208af27 libevent-2.1.12-stable-e13b2bdd8b8.tar.gz e3c9c9609bf32bfd460432c6ab99a64e9f8750ed775a193925ff4f5aed363e4c libnatpmp-07004b97cf691774efebe70404cf22201e4d330d-82255b84667.tar.gz 62c6a089a4b24a413eccd2f389bf4c8b0716423b0ace5e87e984069635da9f83 miniupnpc-2.2.2-c43fc4cf2f6.tar.gz 78762700066273e597698a78479a506b33532ea565d18ef561614b9fc3820cf5 qrencode-3.4.4-663de0dc628.tar.gz 5e2183faf91838510a48e6dbb4b65ae74a7d48ba1abc070b82767c4076582360 qt-5.15.5-986926343e2.tar.gz 9f8459f8d27fc3af9146712be6ba6577f15741429936504a950cc51c17da1ba8 sqlite-3380500-bec6a4d3299.tar.gz 0eca5d01d427de50be4bd57c8bb100ab69b017792c32b8733e2b20443f4c9c28 zeromq-4.3.4-8ae81bab6f4.tar.gz ``` As an example, here is an evidence that bitcoin#24279 is a strict refactoring change: ``` $ git fetch origin pull/24279/head $ git cherry-pick 7060268 $ git cherry-pick 3f90dde $ make -C depends clean $ make -C depends HOST=x86_64-w64-mingw32 $ find depends/built/x86_64-w64-mingw32 -name '*.hash' | sort | xargs cat 1f685a61cbf205f81977ecf88cba91fa1ccdfbe77ab4ec3405dcd33ceb778af4 bdb-4.8.30-c7faf31d5ca.tar.gz 08a9acde276e6e5e5c8913e3ad07eeecda184a996882ae226b3ed056c7ec1b01 boost-1.80.0-1af3dd1d99e.tar.gz 144c6d92e4108fcc90740bee27007db58a88336a97be6367f9c8ba4cc208af27 libevent-2.1.12-stable-6228a9f8534.tar.gz e3c9c9609bf32bfd460432c6ab99a64e9f8750ed775a193925ff4f5aed363e4c libnatpmp-07004b97cf691774efebe70404cf22201e4d330d-41aa6194ecc.tar.gz 62c6a089a4b24a413eccd2f389bf4c8b0716423b0ace5e87e984069635da9f83 miniupnpc-2.2.2-6a93027769c.tar.gz 78762700066273e597698a78479a506b33532ea565d18ef561614b9fc3820cf5 qrencode-3.4.4-d40cb2d45c9.tar.gz 5e2183faf91838510a48e6dbb4b65ae74a7d48ba1abc070b82767c4076582360 qt-5.15.5-120c3cb745d.tar.gz 9f8459f8d27fc3af9146712be6ba6577f15741429936504a950cc51c17da1ba8 sqlite-3380500-bbd4d813c69.tar.gz 0eca5d01d427de50be4bd57c8bb100ab69b017792c32b8733e2b20443f4c9c28 zeromq-4.3.4-df0858a19d2.tar.gz ``` ACKs for top commit: TheCharlatan: Code review ACK 6ebe576 Tree-SHA512: 20e0222781f5dcb50126c11677d0671bcdd7be144b2e528c75a02983acc494206552fb35039697ccd094de27a21b3fb439e9965c34feb8a6d74627fa20a9a5e7
0xB10C
reviewed
Sep 11, 2023
| @@ -261,9 +262,6 @@ define $(package)_preprocess_cmds | |||
| endef | |||
|
|
|||
| define $(package)_config_cmds | |||
| export PKG_CONFIG_SYSROOT_DIR=/ && \ | |||
There was a problem hiding this comment.
fwiw: moving this to depends/funcs.mk broke my Nix depends build. I'm not sure why.
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 14, 2024
Summary: This is a backport of [[bitcoin/bitcoin#24279 | core#24279]] Depends on D15424 Test Plan: guix build, gitian builds Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D15425
HiHat
added a commit
to HiHat/pocketnet.core
that referenced
this pull request
Feb 15, 2024
…other fixes to funcs.mk) Backport from bitcoin/bitcoin#24279 and other
7 tasks
andyoknen
pushed a commit
to pocketnetteam/pocketnet.core
that referenced
this pull request
Feb 19, 2024
…other fixes to funcs.mk) Backport from bitcoin/bitcoin#24279 and other
andyoknen
added a commit
to pocketnetteam/pocketnet.core
that referenced
this pull request
Feb 20, 2024
commit ee62b73 Merge: b0d9b3b 08077f2 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Tue Feb 20 19:38:55 2024 +0800 Merge pull request #674 from pocketnetteam/fix/depends-windres fix: include windres build tool in depends toolchain commit b0d9b3b Merge: 3829be3 1530f7e Author: Andy Oknen <andy.oknen@yandex.ru> Date: Tue Feb 20 18:01:51 2024 +0800 Merge pull request #659 from pocketnetteam/fix/stake_worker_wallet_access fix: loss of the wallet name link in the staker thread commit 08077f2 Author: lostystyg <andrew300399@gmail.com> Date: Mon Feb 19 20:55:38 2024 +0400 Include windres build tool in depends toolchain commit 3829be3 Merge: 82afc9d ee57d4c Author: Andy Oknen <andy.oknen@yandex.ru> Date: Mon Feb 19 12:59:44 2024 +0800 Merge pull request #671 from pocketnetteam/version/0.22.2 version: update version numbers to 0.22.2 commit ee57d4c Author: Andy Oknen <andy.oknen@yandex.ru> Date: Mon Feb 19 12:58:28 2024 +0800 Update version numbers to 0.22.2 commit 82afc9d Merge: 5535854 2f73ad7 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Fri Feb 16 12:54:54 2024 +0800 Merge pull request #670 from HiHat/patch-9 build: add a default build tar in depends #3 commit 5535854 Merge: 9647dcd ff86478 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Fri Feb 16 12:54:43 2024 +0800 Merge pull request #669 from HiHat/patch-8 build: add a default build tar in depends #2 commit 9647dcd Merge: d9b7ffa 3eae4f4 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Fri Feb 16 12:54:29 2024 +0800 Merge pull request #668 from HiHat/patch-7 build: add a default build tar in depends #1 commit 2f73ad7 Author: HiHat <andrey.zotikov@gmail.com> Date: Fri Feb 16 02:15:08 2024 +0300 build: add a default build tar in depends commit ff86478 Author: HiHat <andrey.zotikov@gmail.com> Date: Fri Feb 16 02:12:04 2024 +0300 build: add a default build tar in depends commit 3eae4f4 Author: HiHat <andrey.zotikov@gmail.com> Date: Fri Feb 16 02:10:02 2024 +0300 build: add a default build tar in depends Backport from bitcoin/bitcoin#23998 commit d9b7ffa Merge: 52437d1 620826e Author: Andy Oknen <andy.oknen@yandex.ru> Date: Thu Feb 15 17:09:25 2024 +0800 Merge pull request #666 from HiHat/patch-6 build: Make $(package)_*_env available to all $(package)_*_cmds (and … commit 52437d1 Merge: 25fd325 c6561b0 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Thu Feb 15 17:03:34 2024 +0800 Merge pull request #667 from pocketnetteam/fix/barteron_fead_filter fix: tag handling in Barteron feed getter commit c6561b0 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Thu Feb 15 17:01:50 2024 +0800 Remove unnecessary logging and fix tag handling in BarteronRepository.cpp commit 620826e Author: HiHat <andrey.zotikov@gmail.com> Date: Thu Feb 15 11:25:10 2024 +0300 build: Make $(package)_*_env available to all $(package)_*_cmds (and other fixes to funcs.mk) Backport from bitcoin/bitcoin#24279 and other commit 25fd325 Merge: 2287976 307215c Author: Andy Oknen <andy.oknen@yandex.ru> Date: Tue Feb 13 20:58:14 2024 +0800 Merge pull request #665 from HiHat/patch-5 Bump boost to 1.81.0 commit 2287976 Merge: b550d98 3969688 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Tue Feb 13 20:58:07 2024 +0800 Merge pull request #664 from HiHat/patch-4 Bump openssl from 1.0.1k to 1.1.1w commit 307215c Author: HiHat <andrey.zotikov@gmail.com> Date: Tue Feb 13 15:51:32 2024 +0300 Bump boost to 1.81.0 commit 3969688 Author: HiHat <andrey.zotikov@gmail.com> Date: Tue Feb 13 15:44:33 2024 +0300 Bump openssl from 1.0.1k to 1.1.1w OpenSSL 1.0.1k was released on 08.01.2015 and contains many critical CVEs! commit b550d98 Merge: e44cd02 03caa5a Author: Andy Oknen <andy.oknen@yandex.ru> Date: Tue Feb 13 18:32:48 2024 +0800 Merge pull request #663 from pocketnetteam/fix/activities_comment_answers fix: duplicate responses to comments commit 03caa5a Author: Andy Oknen <andy.oknen@yandex.ru> Date: Tue Feb 13 18:31:20 2024 +0800 Fixed duplicate responses to comments commit e44cd02 Merge: 8c25d45 53531a8 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Wed Feb 7 23:38:22 2024 +0800 Merge pull request #660 from pocketnetteam/fix/comment_content_link fix: link to content in comments query commit 53531a8 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Wed Feb 7 23:32:43 2024 +0800 Fix link to content in comments query commit 1530f7e Author: Andy Oknen <andy.oknen@yandex.ru> Date: Wed Feb 7 23:00:49 2024 +0800 Fixed the loss of the wallet name link in the staker thread
andyoknen
added a commit
to pocketnetteam/pocketnet.core
that referenced
this pull request
Feb 22, 2024
commit ee62b73 Merge: b0d9b3b 08077f2 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Tue Feb 20 19:38:55 2024 +0800 Merge pull request #674 from pocketnetteam/fix/depends-windres fix: include windres build tool in depends toolchain commit b0d9b3b Merge: 3829be3 1530f7e Author: Andy Oknen <andy.oknen@yandex.ru> Date: Tue Feb 20 18:01:51 2024 +0800 Merge pull request #659 from pocketnetteam/fix/stake_worker_wallet_access fix: loss of the wallet name link in the staker thread commit 08077f2 Author: lostystyg <andrew300399@gmail.com> Date: Mon Feb 19 20:55:38 2024 +0400 Include windres build tool in depends toolchain commit 3829be3 Merge: 82afc9d ee57d4c Author: Andy Oknen <andy.oknen@yandex.ru> Date: Mon Feb 19 12:59:44 2024 +0800 Merge pull request #671 from pocketnetteam/version/0.22.2 version: update version numbers to 0.22.2 commit ee57d4c Author: Andy Oknen <andy.oknen@yandex.ru> Date: Mon Feb 19 12:58:28 2024 +0800 Update version numbers to 0.22.2 commit 82afc9d Merge: 5535854 2f73ad7 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Fri Feb 16 12:54:54 2024 +0800 Merge pull request #670 from HiHat/patch-9 build: add a default build tar in depends #3 commit 5535854 Merge: 9647dcd ff86478 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Fri Feb 16 12:54:43 2024 +0800 Merge pull request #669 from HiHat/patch-8 build: add a default build tar in depends #2 commit 9647dcd Merge: d9b7ffa 3eae4f4 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Fri Feb 16 12:54:29 2024 +0800 Merge pull request #668 from HiHat/patch-7 build: add a default build tar in depends #1 commit 2f73ad7 Author: HiHat <andrey.zotikov@gmail.com> Date: Fri Feb 16 02:15:08 2024 +0300 build: add a default build tar in depends commit ff86478 Author: HiHat <andrey.zotikov@gmail.com> Date: Fri Feb 16 02:12:04 2024 +0300 build: add a default build tar in depends commit 3eae4f4 Author: HiHat <andrey.zotikov@gmail.com> Date: Fri Feb 16 02:10:02 2024 +0300 build: add a default build tar in depends Backport from bitcoin/bitcoin#23998 commit d9b7ffa Merge: 52437d1 620826e Author: Andy Oknen <andy.oknen@yandex.ru> Date: Thu Feb 15 17:09:25 2024 +0800 Merge pull request #666 from HiHat/patch-6 build: Make $(package)_*_env available to all $(package)_*_cmds (and … commit 52437d1 Merge: 25fd325 c6561b0 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Thu Feb 15 17:03:34 2024 +0800 Merge pull request #667 from pocketnetteam/fix/barteron_fead_filter fix: tag handling in Barteron feed getter commit c6561b0 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Thu Feb 15 17:01:50 2024 +0800 Remove unnecessary logging and fix tag handling in BarteronRepository.cpp commit 620826e Author: HiHat <andrey.zotikov@gmail.com> Date: Thu Feb 15 11:25:10 2024 +0300 build: Make $(package)_*_env available to all $(package)_*_cmds (and other fixes to funcs.mk) Backport from bitcoin/bitcoin#24279 and other commit 25fd325 Merge: 2287976 307215c Author: Andy Oknen <andy.oknen@yandex.ru> Date: Tue Feb 13 20:58:14 2024 +0800 Merge pull request #665 from HiHat/patch-5 Bump boost to 1.81.0 commit 2287976 Merge: b550d98 3969688 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Tue Feb 13 20:58:07 2024 +0800 Merge pull request #664 from HiHat/patch-4 Bump openssl from 1.0.1k to 1.1.1w commit 307215c Author: HiHat <andrey.zotikov@gmail.com> Date: Tue Feb 13 15:51:32 2024 +0300 Bump boost to 1.81.0 commit 3969688 Author: HiHat <andrey.zotikov@gmail.com> Date: Tue Feb 13 15:44:33 2024 +0300 Bump openssl from 1.0.1k to 1.1.1w OpenSSL 1.0.1k was released on 08.01.2015 and contains many critical CVEs! commit b550d98 Merge: e44cd02 03caa5a Author: Andy Oknen <andy.oknen@yandex.ru> Date: Tue Feb 13 18:32:48 2024 +0800 Merge pull request #663 from pocketnetteam/fix/activities_comment_answers fix: duplicate responses to comments commit 03caa5a Author: Andy Oknen <andy.oknen@yandex.ru> Date: Tue Feb 13 18:31:20 2024 +0800 Fixed duplicate responses to comments commit e44cd02 Merge: 8c25d45 53531a8 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Wed Feb 7 23:38:22 2024 +0800 Merge pull request #660 from pocketnetteam/fix/comment_content_link fix: link to content in comments query commit 53531a8 Author: Andy Oknen <andy.oknen@yandex.ru> Date: Wed Feb 7 23:32:43 2024 +0800 Fix link to content in comments query commit 1530f7e Author: Andy Oknen <andy.oknen@yandex.ru> Date: Wed Feb 7 23:00:49 2024 +0800 Fixed the loss of the wallet name link in the staker thread
andyoknen
added a commit
to pocketnetteam/pocketnet.core
that referenced
this pull request
Mar 5, 2024
commit 44a88ec5b09efbd045fbe4a0c9f9eb3aa8028a5a
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Mar 4 12:08:56 2024 +0800
Fix check blockings
commit 25289a1359602b447b919d31a91f6589e9f62228
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Sat Mar 2 12:09:49 2024 +0800
Fix SQL request timeout handling in BaseRepository.h
commit bcd20d0d3cc2f29ab2d4bd2286a031c6e12ae332
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Mar 1 23:34:09 2024 +0800
revert exception for timeout sql query
commit 29d2bb862d4653c77c1dbd50087e172f1f57b12d
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 27 21:17:38 2024 +0800
Fix join condition in WebRpcRepository.cpp
commit 2e0df67a7b729075a5495e9abcfac30790b4914e
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 27 02:44:11 2024 +0800
Fix cross join issue in WebRpcRepository.cpp
commit 4faac52d3eec0fc2020c019f9bae1487d4ee327b
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 26 14:09:28 2024 +0800
Refactor query in WebRpcRepository.cpp to include additional condition
commit 1919f2a5507d6f7ca15d8c5a3726320ad85613e0
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 26 12:52:17 2024 +0800
Add content address to WebSocketRpc and NotifyProcessor
commit ca09cff8a94d3202a63077bb8977688144d3c2fc
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 26 11:52:50 2024 +0800
Refactor SQL queries to include blocked commenters
commit 8d4d565f8288564e65a6b07724af0f9ec9293edd
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Feb 23 18:15:40 2024 +0800
Fix SQL query in WebRpcRepository.cpp
commit ca0e33dcdc6b136699274e438c3198148eea5a3c
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Feb 23 00:15:58 2024 +0800
Remove debug logging
commit fe52996cc7fb1b768609cb76a680800c3d527e7f
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 22 20:40:27 2024 +0800
Refactor blocking logic in WebRpcRepository.cpp
commit 2910420647c952fd0c2b223f462dee5cfe61d841
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 22 17:42:29 2024 +0800
Update consensus checkpoint height for pip105
commit a42ffbe4cd41ea542e55c5528a6b4b64ec92d780
Merge: ee62b73b 15b618e1
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 22 16:52:45 2024 +0800
Merge pull request #661 from pocketnetteam/fix/moderate_verdict_notify
fix: moderate verdict notify
commit 15b618e12e18b326ff22f516a82ef043d212883f
Merge: 5163e7b9 ee62b73b
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 22 16:52:39 2024 +0800
Merge branch '0.22' into fix/moderate_verdict_notify
commit 5163e7b9128f61548ebe4df2978e4f01f7c3a00f
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 22 16:50:42 2024 +0800
Squashed commit of the following:
commit ee62b73ba2e68c047ebd7ca3aec54dac0e4ddf03
Merge: b0d9b3bd 08077f20
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 20 19:38:55 2024 +0800
Merge pull request #674 from pocketnetteam/fix/depends-windres
fix: include windres build tool in depends toolchain
commit b0d9b3bd2cecd88d86c9aaeec7a6865acf116ce1
Merge: 3829be32 1530f7e3
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 20 18:01:51 2024 +0800
Merge pull request #659 from pocketnetteam/fix/stake_worker_wallet_access
fix: loss of the wallet name link in the staker thread
commit 08077f205ab90b7250a523877580885131d9b1a3
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Feb 19 20:55:38 2024 +0400
Include windres build tool in depends toolchain
commit 3829be32c38bdb9f54779aad314df8e8078af0ca
Merge: 82afc9d9 ee57d4c3
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 19 12:59:44 2024 +0800
Merge pull request #671 from pocketnetteam/version/0.22.2
version: update version numbers to 0.22.2
commit ee57d4c3c19b72211a485bbdddfe9bb503db75e0
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 19 12:58:28 2024 +0800
Update version numbers to 0.22.2
commit 82afc9d90bfb287d1a795978fa50853ca2bf06ec
Merge: 55358546 2f73ad7a
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Feb 16 12:54:54 2024 +0800
Merge pull request #670 from HiHat/patch-9
build: add a default build tar in depends #3
commit 55358546f8d3d0b001d720a6cdf5a494015117f7
Merge: 9647dcdb ff86478c
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Feb 16 12:54:43 2024 +0800
Merge pull request #669 from HiHat/patch-8
build: add a default build tar in depends #2
commit 9647dcdb4d4e0638beafe2d5723d4b390cb0c2f9
Merge: d9b7ffad 3eae4f48
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Feb 16 12:54:29 2024 +0800
Merge pull request #668 from HiHat/patch-7
build: add a default build tar in depends #1
commit 2f73ad7a3b5275faddf4afb26cd2f47932e25c04
Author: HiHat <andrey.zotikov@gmail.com>
Date: Fri Feb 16 02:15:08 2024 +0300
build: add a default build tar in depends
commit ff86478c7a034ea4eee236d2b217525f714c708d
Author: HiHat <andrey.zotikov@gmail.com>
Date: Fri Feb 16 02:12:04 2024 +0300
build: add a default build tar in depends
commit 3eae4f48db15e44812bc1d26145281df82535e09
Author: HiHat <andrey.zotikov@gmail.com>
Date: Fri Feb 16 02:10:02 2024 +0300
build: add a default build tar in depends
Backport from https://github.com/bitcoin/bitcoin/pull/23998
commit d9b7ffade67cac59498a9c31502f00e0fcc64b69
Merge: 52437d10 620826e1
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 15 17:09:25 2024 +0800
Merge pull request #666 from HiHat/patch-6
build: Make $(package)_*_env available to all $(package)_*_cmds (and …
commit 52437d1044d99aa2354f2be9ee0167248eaf8976
Merge: 25fd325d c6561b09
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 15 17:03:34 2024 +0800
Merge pull request #667 from pocketnetteam/fix/barteron_fead_filter
fix: tag handling in Barteron feed getter
commit c6561b091f404d89d40bc7305d0a284fe2e18b8a
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 15 17:01:50 2024 +0800
Remove unnecessary logging and fix tag handling in BarteronRepository.cpp
commit 620826e1195ce92e85cf7494bdb672771ffe32d5
Author: HiHat <andrey.zotikov@gmail.com>
Date: Thu Feb 15 11:25:10 2024 +0300
build: Make $(package)_*_env available to all $(package)_*_cmds (and other fixes to funcs.mk)
Backport from https://github.com/bitcoin/bitcoin/pull/24279 and other
commit 25fd325deebd871c00ff957e62294c72f705007d
Merge: 22879765 307215c8
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 20:58:14 2024 +0800
Merge pull request #665 from HiHat/patch-5
Bump boost to 1.81.0
commit 228797652ec7094b1cae6c84f822486d9196de45
Merge: b550d988 39696880
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 20:58:07 2024 +0800
Merge pull request #664 from HiHat/patch-4
Bump openssl from 1.0.1k to 1.1.1w
commit 307215c88d5393070aeb017fd77580682af6c683
Author: HiHat <andrey.zotikov@gmail.com>
Date: Tue Feb 13 15:51:32 2024 +0300
Bump boost to 1.81.0
commit 396968803c250bb97b082edf5979322778c04952
Author: HiHat <andrey.zotikov@gmail.com>
Date: Tue Feb 13 15:44:33 2024 +0300
Bump openssl from 1.0.1k to 1.1.1w
OpenSSL 1.0.1k was released on 08.01.2015 and contains many critical CVEs!
commit b550d988f8629d48c01275f6f2ce85d492dcf525
Merge: e44cd02f 03caa5a8
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 18:32:48 2024 +0800
Merge pull request #663 from pocketnetteam/fix/activities_comment_answers
fix: duplicate responses to comments
commit 03caa5a8472d605751c5182471a92b96d46fa3a5
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 18:31:20 2024 +0800
Fixed duplicate responses to comments
commit e44cd02fcf47c9ddc690fc5495166fa324a22c80
Merge: 8c25d45b 53531a89
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 7 23:38:22 2024 +0800
Merge pull request #660 from pocketnetteam/fix/comment_content_link
fix: link to content in comments query
commit 53531a89dd43f44e02cad7be7e6b109f00dfeb14
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 7 23:32:43 2024 +0800
Fix link to content in comments query
commit 1530f7e3cfdcde83790284d0cadf1111ad143a63
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 7 23:00:49 2024 +0800
Fixed the loss of the wallet name link in the staker thread
commit 5450fbd01d91b7af5d6a1885ce59be818205c720
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 22 16:41:46 2024 +0800
Refactor Location field to be a vector of strings
commit d8de26a339669279cfdebda52aa373fb7ec672da
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 21 18:55:06 2024 +0800
Change join Payload to left for include deleted accounts in getuserprofile
commit 4a0a8aa3d9528c72deca1bc1d5de8c84cf12d7e0
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 21 18:22:52 2024 +0800
Refactor BarteronRepository.cpp and BarteronRepository.h***
The changes in this commit refactor the BarteronRepository.cpp and BarteronRepository.h files. The changes include:
- Removing the Location variable and replacing it with a vector of strings.
- Modifying the _filters string to handle the new Location vector.
- Updating the Bind function in the BarteronRepository.cpp file to handle the new Location vector.
- Updating the parsing of the "location" argument in the BarteronRpc.cpp file to handle an array of strings.
commit 602f931b3f220a2cea746eab3faafe4991bf631b
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 20 19:41:08 2024 +0800
Squashed commit of the following:
commit ee62b73ba2e68c047ebd7ca3aec54dac0e4ddf03
Merge: b0d9b3bd 08077f20
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 20 19:38:55 2024 +0800
Merge pull request #674 from pocketnetteam/fix/depends-windres
fix: include windres build tool in depends toolchain
commit b0d9b3bd2cecd88d86c9aaeec7a6865acf116ce1
Merge: 3829be32 1530f7e3
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 20 18:01:51 2024 +0800
Merge pull request #659 from pocketnetteam/fix/stake_worker_wallet_access
fix: loss of the wallet name link in the staker thread
commit 08077f205ab90b7250a523877580885131d9b1a3
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Feb 19 20:55:38 2024 +0400
Include windres build tool in depends toolchain
commit 3829be32c38bdb9f54779aad314df8e8078af0ca
Merge: 82afc9d9 ee57d4c3
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 19 12:59:44 2024 +0800
Merge pull request #671 from pocketnetteam/version/0.22.2
version: update version numbers to 0.22.2
commit ee57d4c3c19b72211a485bbdddfe9bb503db75e0
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 19 12:58:28 2024 +0800
Update version numbers to 0.22.2
commit 82afc9d90bfb287d1a795978fa50853ca2bf06ec
Merge: 55358546 2f73ad7a
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Feb 16 12:54:54 2024 +0800
Merge pull request #670 from HiHat/patch-9
build: add a default build tar in depends #3
commit 55358546f8d3d0b001d720a6cdf5a494015117f7
Merge: 9647dcdb ff86478c
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Feb 16 12:54:43 2024 +0800
Merge pull request #669 from HiHat/patch-8
build: add a default build tar in depends #2
commit 9647dcdb4d4e0638beafe2d5723d4b390cb0c2f9
Merge: d9b7ffad 3eae4f48
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Feb 16 12:54:29 2024 +0800
Merge pull request #668 from HiHat/patch-7
build: add a default build tar in depends #1
commit 2f73ad7a3b5275faddf4afb26cd2f47932e25c04
Author: HiHat <andrey.zotikov@gmail.com>
Date: Fri Feb 16 02:15:08 2024 +0300
build: add a default build tar in depends
commit ff86478c7a034ea4eee236d2b217525f714c708d
Author: HiHat <andrey.zotikov@gmail.com>
Date: Fri Feb 16 02:12:04 2024 +0300
build: add a default build tar in depends
commit 3eae4f48db15e44812bc1d26145281df82535e09
Author: HiHat <andrey.zotikov@gmail.com>
Date: Fri Feb 16 02:10:02 2024 +0300
build: add a default build tar in depends
Backport from https://github.com/bitcoin/bitcoin/pull/23998
commit d9b7ffade67cac59498a9c31502f00e0fcc64b69
Merge: 52437d10 620826e1
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 15 17:09:25 2024 +0800
Merge pull request #666 from HiHat/patch-6
build: Make $(package)_*_env available to all $(package)_*_cmds (and …
commit 52437d1044d99aa2354f2be9ee0167248eaf8976
Merge: 25fd325d c6561b09
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 15 17:03:34 2024 +0800
Merge pull request #667 from pocketnetteam/fix/barteron_fead_filter
fix: tag handling in Barteron feed getter
commit c6561b091f404d89d40bc7305d0a284fe2e18b8a
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 15 17:01:50 2024 +0800
Remove unnecessary logging and fix tag handling in BarteronRepository.cpp
commit 620826e1195ce92e85cf7494bdb672771ffe32d5
Author: HiHat <andrey.zotikov@gmail.com>
Date: Thu Feb 15 11:25:10 2024 +0300
build: Make $(package)_*_env available to all $(package)_*_cmds (and other fixes to funcs.mk)
Backport from https://github.com/bitcoin/bitcoin/pull/24279 and other
commit 25fd325deebd871c00ff957e62294c72f705007d
Merge: 22879765 307215c8
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 20:58:14 2024 +0800
Merge pull request #665 from HiHat/patch-5
Bump boost to 1.81.0
commit 228797652ec7094b1cae6c84f822486d9196de45
Merge: b550d988 39696880
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 20:58:07 2024 +0800
Merge pull request #664 from HiHat/patch-4
Bump openssl from 1.0.1k to 1.1.1w
commit 307215c88d5393070aeb017fd77580682af6c683
Author: HiHat <andrey.zotikov@gmail.com>
Date: Tue Feb 13 15:51:32 2024 +0300
Bump boost to 1.81.0
commit 396968803c250bb97b082edf5979322778c04952
Author: HiHat <andrey.zotikov@gmail.com>
Date: Tue Feb 13 15:44:33 2024 +0300
Bump openssl from 1.0.1k to 1.1.1w
OpenSSL 1.0.1k was released on 08.01.2015 and contains many critical CVEs!
commit b550d988f8629d48c01275f6f2ce85d492dcf525
Merge: e44cd02f 03caa5a8
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 18:32:48 2024 +0800
Merge pull request #663 from pocketnetteam/fix/activities_comment_answers
fix: duplicate responses to comments
commit 03caa5a8472d605751c5182471a92b96d46fa3a5
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 18:31:20 2024 +0800
Fixed duplicate responses to comments
commit e44cd02fcf47c9ddc690fc5495166fa324a22c80
Merge: 8c25d45b 53531a89
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 7 23:38:22 2024 +0800
Merge pull request #660 from pocketnetteam/fix/comment_content_link
fix: link to content in comments query
commit 53531a89dd43f44e02cad7be7e6b109f00dfeb14
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 7 23:32:43 2024 +0800
Fix link to content in comments query
commit 1530f7e3cfdcde83790284d0cadf1111ad143a63
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 7 23:00:49 2024 +0800
Fixed the loss of the wallet name link in the staker thread
commit ee62b73ba2e68c047ebd7ca3aec54dac0e4ddf03
Merge: b0d9b3bd 08077f20
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 20 19:38:55 2024 +0800
Merge pull request #674 from pocketnetteam/fix/depends-windres
fix: include windres build tool in depends toolchain
commit df3c91fdcedb1bf579abc0fae0376505036d2105
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 20 18:29:59 2024 +0800
Update version to 0.22.3
commit 892957a240f605b1c38f08520177783c535054f8
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 7 22:58:25 2024 +0800
Add comments and improve code readability
commit b0d9b3bd2cecd88d86c9aaeec7a6865acf116ce1
Merge: 3829be32 1530f7e3
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 20 18:01:51 2024 +0800
Merge pull request #659 from pocketnetteam/fix/stake_worker_wallet_access
fix: loss of the wallet name link in the staker thread
commit 8f4594c0c55650da73f110951efe9c27308e20d3
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 20 15:28:14 2024 +0800
Remove debug logging GetFeed
commit 69011930f1108e4515fc147c5f0921af0cfc2ede
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 20 14:16:11 2024 +0800
Update warning message in BindAddress function
commit 08077f205ab90b7250a523877580885131d9b1a3
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Feb 19 20:55:38 2024 +0400
Include windres build tool in depends toolchain
commit e27f03cdad41974763c4717c4f844964d723405b
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 19 20:14:09 2024 +0800
Fix SQL timeout issue and improve error handling
commit 72ebd95875bd75319a4c44458b4d44af10d6ed67
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 19 18:46:58 2024 +0800
Fix join condition in WebRpcRepository.cpp
commit a967653ca6e43e84316135bd96130771265b1786
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 19 12:58:28 2024 +0800
Update version numbers to 0.22.2
commit 196a7ccee3b576c8c3cb3a7ee63f5e3690bfc11d
Author: HiHat <andrey.zotikov@gmail.com>
Date: Fri Feb 16 02:15:08 2024 +0300
build: add a default build tar in depends
commit 870b92bb52cde6cf4b84880ced05b947abf683ee
Author: HiHat <andrey.zotikov@gmail.com>
Date: Fri Feb 16 02:12:04 2024 +0300
build: add a default build tar in depends
commit 5c795a5238fec9eb893fb87131fa8d5d2cae95cd
Author: HiHat <andrey.zotikov@gmail.com>
Date: Fri Feb 16 02:10:02 2024 +0300
build: add a default build tar in depends
Backport from https://github.com/bitcoin/bitcoin/pull/23998
commit 542f60a0be14666c3d6bf4a6fea114fddc49a88c
Author: HiHat <andrey.zotikov@gmail.com>
Date: Thu Feb 15 11:25:10 2024 +0300
build: Make $(package)_*_env available to all $(package)_*_cmds (and other fixes to funcs.mk)
Backport from https://github.com/bitcoin/bitcoin/pull/24279 and other
commit 6d8c7596a1bfe4551734e738fa9cc0e6b60b2bf3
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 15 17:01:50 2024 +0800
Remove unnecessary logging and fix tag handling in BarteronRepository.cpp
commit af063096d000e2add7996e7c56405c8ceda3258d
Author: HiHat <andrey.zotikov@gmail.com>
Date: Tue Feb 13 15:51:32 2024 +0300
Bump boost to 1.81.0
commit b8c6a04e209e149677c2cc25fa02ef974045f737
Author: HiHat <andrey.zotikov@gmail.com>
Date: Tue Feb 13 15:44:33 2024 +0300
Bump openssl from 1.0.1k to 1.1.1w
OpenSSL 1.0.1k was released on 08.01.2015 and contains many critical CVEs!
commit c64b2d99775dbd64b960929352c4f0a4af20325b
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 18:31:20 2024 +0800
Fixed duplicate responses to comments
commit b3a8741afa7c3783443d1f2cd141a37343670702
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 7 23:32:43 2024 +0800
Fix link to content in comments query
commit a0d49ee508d84cf3957e3c7dcb77b370752fc04c
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 19 18:29:50 2024 +0800
Extend getmissedinfo with JuryVerdict events + refacto link to Jury in moderation events
commit 3829be32c38bdb9f54779aad314df8e8078af0ca
Merge: 82afc9d9 ee57d4c3
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 19 12:59:44 2024 +0800
Merge pull request #671 from pocketnetteam/version/0.22.2
version: update version numbers to 0.22.2
commit ee57d4c3c19b72211a485bbdddfe9bb503db75e0
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Feb 19 12:58:28 2024 +0800
Update version numbers to 0.22.2
commit 82afc9d90bfb287d1a795978fa50853ca2bf06ec
Merge: 55358546 2f73ad7a
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Feb 16 12:54:54 2024 +0800
Merge pull request #670 from HiHat/patch-9
build: add a default build tar in depends #3
commit 55358546f8d3d0b001d720a6cdf5a494015117f7
Merge: 9647dcdb ff86478c
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Feb 16 12:54:43 2024 +0800
Merge pull request #669 from HiHat/patch-8
build: add a default build tar in depends #2
commit 9647dcdb4d4e0638beafe2d5723d4b390cb0c2f9
Merge: d9b7ffad 3eae4f48
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Feb 16 12:54:29 2024 +0800
Merge pull request #668 from HiHat/patch-7
build: add a default build tar in depends #1
commit 2f73ad7a3b5275faddf4afb26cd2f47932e25c04
Author: HiHat <andrey.zotikov@gmail.com>
Date: Fri Feb 16 02:15:08 2024 +0300
build: add a default build tar in depends
commit ff86478c7a034ea4eee236d2b217525f714c708d
Author: HiHat <andrey.zotikov@gmail.com>
Date: Fri Feb 16 02:12:04 2024 +0300
build: add a default build tar in depends
commit 3eae4f48db15e44812bc1d26145281df82535e09
Author: HiHat <andrey.zotikov@gmail.com>
Date: Fri Feb 16 02:10:02 2024 +0300
build: add a default build tar in depends
Backport from https://github.com/bitcoin/bitcoin/pull/23998
commit d9b7ffade67cac59498a9c31502f00e0fcc64b69
Merge: 52437d10 620826e1
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 15 17:09:25 2024 +0800
Merge pull request #666 from HiHat/patch-6
build: Make $(package)_*_env available to all $(package)_*_cmds (and …
commit 52437d1044d99aa2354f2be9ee0167248eaf8976
Merge: 25fd325d c6561b09
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 15 17:03:34 2024 +0800
Merge pull request #667 from pocketnetteam/fix/barteron_fead_filter
fix: tag handling in Barteron feed getter
commit c6561b091f404d89d40bc7305d0a284fe2e18b8a
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Feb 15 17:01:50 2024 +0800
Remove unnecessary logging and fix tag handling in BarteronRepository.cpp
commit 620826e1195ce92e85cf7494bdb672771ffe32d5
Author: HiHat <andrey.zotikov@gmail.com>
Date: Thu Feb 15 11:25:10 2024 +0300
build: Make $(package)_*_env available to all $(package)_*_cmds (and other fixes to funcs.mk)
Backport from https://github.com/bitcoin/bitcoin/pull/24279 and other
commit 25fd325deebd871c00ff957e62294c72f705007d
Merge: 22879765 307215c8
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 20:58:14 2024 +0800
Merge pull request #665 from HiHat/patch-5
Bump boost to 1.81.0
commit 228797652ec7094b1cae6c84f822486d9196de45
Merge: b550d988 39696880
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 20:58:07 2024 +0800
Merge pull request #664 from HiHat/patch-4
Bump openssl from 1.0.1k to 1.1.1w
commit 307215c88d5393070aeb017fd77580682af6c683
Author: HiHat <andrey.zotikov@gmail.com>
Date: Tue Feb 13 15:51:32 2024 +0300
Bump boost to 1.81.0
commit 396968803c250bb97b082edf5979322778c04952
Author: HiHat <andrey.zotikov@gmail.com>
Date: Tue Feb 13 15:44:33 2024 +0300
Bump openssl from 1.0.1k to 1.1.1w
OpenSSL 1.0.1k was released on 08.01.2015 and contains many critical CVEs!
commit b550d988f8629d48c01275f6f2ce85d492dcf525
Merge: e44cd02f 03caa5a8
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 18:32:48 2024 +0800
Merge pull request #663 from pocketnetteam/fix/activities_comment_answers
fix: duplicate responses to comments
commit 03caa5a8472d605751c5182471a92b96d46fa3a5
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Feb 13 18:31:20 2024 +0800
Fixed duplicate responses to comments
commit e44cd02fcf47c9ddc690fc5495166fa324a22c80
Merge: 8c25d45b 53531a89
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 7 23:38:22 2024 +0800
Merge pull request #660 from pocketnetteam/fix/comment_content_link
fix: link to content in comments query
commit 53531a89dd43f44e02cad7be7e6b109f00dfeb14
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 7 23:32:43 2024 +0800
Fix link to content in comments query
commit 1530f7e3cfdcde83790284d0cadf1111ad143a63
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Feb 7 23:00:49 2024 +0800
Fixed the loss of the wallet name link in the staker thread
commit 944ba864ac4240b618db311f3116474c7a22d71b
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 29 18:06:31 2024 +0800
Fix cross join in NotifierRepository.cpp
commit f5f4287090b43507b65c8681420f8dd88de57b30
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 29 17:17:47 2024 +0800
Fix ValidateBlocking override in BoostContent and Comment
commit 43f8dbbcf5660bb1928de04bfcb9a28bdc29dfa7
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 29 17:16:30 2024 +0800
Fix CommentEditConsensus_checkpoint_check_author validation
commit 539763618be5b746a0bc506e906c0481fc356b7d
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 29 17:07:41 2024 +0800
Refactor BoostContentConsensus_checkpoint_pip_105 class in BoostContent.hpp
commit 6d2935d40c95e4e361ba4dd7a266acc5e8b5532e
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 29 17:00:14 2024 +0800
Fix method name in Social.h
commit e74aeaf3b99e1c8f1c35c747767b7539cf96a5ad
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 29 17:00:08 2024 +0800
Refactor ValidateBlocking method in BoostContentConsensus
commit c822ea6dad22e2fae206a852162b683c90e98a0f
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 26 14:45:19 2024 +0800
Refactor ValidateBlocking method in ScoreContentConsensus
commit 8c832358b1983180e1d4ca18ad27925100f5fbe7
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 26 14:41:21 2024 +0800
Refactor ScoreComment.hpp
commit 4e7117a8dd53d11fc1c5697bfe92ed789fe98e84
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 26 14:41:10 2024 +0800
Fix ValidateBlocking function call in Comment.hpp
commit fa2a9819da1f59432c44604a3f35d1a99206d4f2
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 26 14:40:59 2024 +0800
Fix CheckBlocking logic in Social.h
commit 926ef2bb91a4d101fe79f0adffad843bc675d4a3
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 25 17:09:19 2024 +0800
Refactor CommentConsensus class and add new checkpoint for PIP-105
commit d3fc6f1784d5c74f370287c06a7c9fb9e75e4df8
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 25 17:09:14 2024 +0800
Add PIP 105 to doc/pips.md
commit 4cd376210894d02cc1aafcaec74a83fb70e1474f
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 25 15:39:46 2024 +0800
Add CheckBlocking function to Social.h and ExistBlocking function to ConsensusRepository.cpp
commit 979dfd1597cb49671c79af61bdb8bd1d85a99dbd
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 25 15:20:56 2024 +0800
Disable prohibition of transactions for banned accounts temporarily
commit 8c25d45bd9bfa6e6ca07114a3e1df0d3740a44d3
Merge: 0389ba86 2ef03139
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 22 10:30:40 2024 +0800
Merge pull request #656 from pocketnetteam/fix/block_write_to_sql_empty_payload
fix: block write to sql empty payload
commit 0389ba86dc343a6e9d6cfada473379abb194293c
Merge: ec0df968 274f7ac3
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 22 10:30:29 2024 +0800
Merge pull request #657 from pocketnetteam/fix/empty_maptx_in_expiry
fix: time calculation in CTxMemPoolEntry class
commit 2ef03139a80c2922a8a0148ab217b397e95ba6d2
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 22 10:28:33 2024 +0800
Fix payload assignment in
TransactionRepository.cpp
commit 274f7ac30c42b19e6e048a52bbe6a37888a1182a
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 22 10:27:51 2024 +0800
Fix time calculation in CTxMemPoolEntry class
commit ec0df96841021783fc1976692838bef5a54d2182
Merge: 4dc79d13 5da3ed1d
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 18 14:28:23 2024 +0800
Merge pull request #654 from pocketnetteam/fix/drop_old_web_db_version
fix: drop old web db version
commit 5da3ed1d4c3f110f3f74af8d334be0bd2eeb0675
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 18 14:24:35 2024 +0800
Add user_version=1 pragma to pre-processing SQL
commit 138df496b6eed3dc49f419fc3e152fb5994ed534
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 18 14:21:10 2024 +0800
Fix SQLite database version and drop web database if old version
commit bc25ae42cdda196a55595bfac5c34d0602052670
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 18 14:20:52 2024 +0800
Delete old migration functions
commit 4dc79d132c0f89da0049e16d492c066b0d7fcbc8
Merge: ff4e7ada e67464c7
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Wed Jan 17 20:15:55 2024 +0800
Merge pull request #653 from pocketnetteam/feat/moderation_ws_notifications
Feat/moderation ws notifications
commit e67464c73115d49157f90104fa1f67f47f4369e0
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Jan 16 20:10:08 2024 +0800
Refactor BarteronRepository.cpp query structure
commit 35a808e3bfd8a64b0f31ffca25e22e6a0fe7cb09
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Jan 16 19:15:22 2024 +0800
Add moderation events to websocket messages
commit 7a3cf0c3fe202b117c9add076303692b05e093d0
Merge: 1cf778bc ff4e7ada
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Jan 16 15:11:35 2024 +0800
Merge remote-tracking branch 'origin/0.22' into feat/moderation_ws_notifications
commit ff4e7adae82deb002623dad5fdea410c24a419c8
Merge: dfae0474 9d0bc622
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Jan 16 15:10:51 2024 +0800
Merge pull request #652 from pocketnetteam/fix/barteron_op_return
fix: deserialize payload in SocialTransaction layer
commit 9d0bc622eaacfcd4f8b71ca3b85ef28ddbe82350
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Jan 16 01:42:55 2024 +0800
Add DeserializePayload method to SocialTransaction
and remove unnecessary line in Vote.cpp
commit ed5aeb4392a26d764a44038e3f8ec858e431f5c4
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Jan 16 00:58:14 2024 +0800
Add overrided DeserializePayload method to SocialTransaction
class
commit 7a98067583bbb2b0a9d2465ef272422016dea87d
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 15 22:59:40 2024 +0800
Remove unnecessary log statement in
ValidateMempool function
commit 1cf778bc34403a14cb21329bf2d66ad35e1d97a1
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 15 15:25:16 2024 +0800
Moving Notifications repository methods to NotificationRespository
commit dfae04748188aaa1a587b6092da0931fb74293d5
Merge: 5143d348 82c280bf
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 11 19:40:57 2024 +0800
Merge pull request #651 from pocketnetteam/fix/profile_lost_bans_in_full_form
fix: profile lost bans in full form
commit 82c280bf1606283b4c77e710360542e94587f3d8
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 11 19:39:07 2024 +0800
Fix periodic collection of account statistics
commit 01f666ad74cdc4db9ab5663063015d74ae66a45c
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 11 19:39:00 2024 +0800
Fix bug in getuserprofile functionality
commit 5143d348d79aaae3e0545c98cda684e222a1528c
Merge: 35af54bb 701417e2
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 11 18:11:30 2024 +0800
Merge pull request #627 from pocketnetteam/feature/barteron
feat: barteron
commit 35af54bb77ded6545e994e61db54f0e1d9e709e9
Merge: 7bbe372d 763941c4
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 11 18:09:16 2024 +0800
Merge pull request #635 from pocketnetteam/feat/delayed_transactions
"Extend mempool expiry and add locktime handling in transactions"
commit 763941c4df114caba18326772e0bf032aefc1848
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 11 17:42:14 2024 +0800
Add DelayedTransactionsTest to test delayed
transactions functionality
commit df8260031775e36b37946623f4b8f66559d55e10
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 11 17:42:01 2024 +0800
Update GenerateTransaction function parameters to
include locktime
commit 27a32c4390738e419cd2a27a1481bba31d50672e
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Jan 11 17:35:05 2024 +0800
Remove check First for mempoolCount queries
commit 7bbe372ddac6d5167c06e7407c58c0e1537ed217
Merge: c99a1848 df53c660
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 8 05:55:23 2024 +0800
Merge pull request #650 from pocketnetteam/fix/intro
fix: disable prune checkbox at intro screen
commit df53c6605926e8d81f8a8acd0a7bb786e3015108
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 8 05:31:44 2024 +0800
Update blockchain size year
commit e1fd025348b4c7a7a86dbece6f5f64a8c81fdae0
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 8 05:31:39 2024 +0800
Hide prune checkbox
commit c99a1848c5694067682539b1ad2a15f90b533197
Merge: 01add31a f15d5365
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 8 05:15:37 2024 +0800
Merge pull request #649 from pocketnetteam/nodes/95.31.45.162
seeds: add new fixed node ip by Issue #645
commit 01add31af21a73b2f879ab48ae7ae63dddd39bb1
Merge: b7c1ac21 43a72733
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 8 05:15:24 2024 +0800
Merge pull request #648 from pocketnetteam/version/0.22.1
version: 0.22.1
commit b7c1ac211e02014d0089e0da23ead3eca93d2c69
Merge: 84ae9685 f6214b6a
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 8 05:12:47 2024 +0800
Merge pull request #647 from pocketnetteam/fix/address_transactions
fix: speeding up the execution of GetAddressTransactions requests
commit f15d53653e889d91a0c596cc6b35d8d3af05d72b
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 8 05:10:45 2024 +0800
Add new IP address to nodes_main.txt and
chainparamsseeds.h
commit 43a72733ddb7109460e33b6c9b1a6834dd394cb0
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 8 04:55:07 2024 +0800
Update copyright year to 2024
commit 50d3f1a5b60da2b61c069b526a572e464cc3e6b5
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 8 04:46:21 2024 +0800
Update assumed blockchain size to 150
commit cc1860138ebff449d2d76ad9f27d729228cf49ec
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 8 04:41:47 2024 +0800
Update consensus minimum chainwork
commit aafba58186b506e89843a7eb6f34aec3a4208310
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Jan 8 04:39:14 2024 +0800
Update version revision to 1
commit f6214b6a2ac3d3dca86588b02e5fac59e6695409
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Sat Jan 6 14:19:27 2024 +0800
Update indexes in main.cpp and repository files
commit 3bc53abcc757a32a12d51c6356444ba48fc4a72b
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Sat Jan 6 14:06:30 2024 +0800
Refactor ExplorerRepository.cpp to improve query GetAddressTransactions performance
commit 84ae9685d1eaab708566b01b14ce26822585d709
Merge: 0785c317 ebd98232
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Sat Jan 6 13:56:29 2024 +0800
Merge pull request #646 from pocketnetteam/feat/force_chain_access
feature: force ChainActive access without mutex lock cs_main
commit ebd982327e65d61b9b4a3918c712bb3e23b184ae
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 5 23:50:48 2024 +0800
Revert "Add debug logs for SearchUsers function"
This reverts commit 92de2675a7127e690c7c184f7407673d1692ae7e.
commit 92de2675a7127e690c7c184f7407673d1692ae7e
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 5 23:11:45 2024 +0800
Add debug logs for SearchUsers function
commit d1585cd4a023c87a2f961f8fcc5e8d17c89d27e5
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 5 22:18:19 2024 +0800
Fix formatting in RPC log message
commit 35b655564602788ae0326bc4fa62e899f9c49783
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Dec 29 18:32:11 2023 +0800
Fix wrong JuryVerdict primary key
commit f7639c9f985ddef5b66a57d9ded9661863da3dcf
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Dec 29 17:35:32 2023 +0800
Filter feeds by active jury
commit 23dabad6e7aa2b8c5cfed96fd7948d1c74d4f3d3
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Dec 29 17:35:13 2023 +0800
Return contentId for getbans
commit 4d3d6095ed6b9204f916701650763c13a8813db2
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Dec 29 14:26:36 2023 +0800
Fix returned tx hash instead inner id
commit 55ad6f51231fdb091bb70e804e8c362188004150
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Dec 29 14:24:11 2023 +0800
Added list of bans in getuserprofiles in short form
commit 0016584cd0c82183fc6502ca944487271bef4ea7
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Dec 28 22:24:14 2023 +0800
Refactor WebRpcRepository.cpp to exclude posts
from banned users
commit e94ff7169dc614a9d364bcb9f6a3fbeb56af6214
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Dec 26 18:04:34 2023 +0800
Remove unused IP addresses and update
chainparamsseeds.h
commit eb581e865a6367e47d06401d9c943563dc9c92d0
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Dec 26 18:04:02 2023 +0800
Request to add an IP address to the source code #569
commit 0785c317e9e46c38d5cec8e7363d66f10e804b36
Merge: 41ee46e0 a394978f
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 5 21:51:26 2024 +0800
Merge pull request #644 from pocketnetteam/fix/feeds_sql
fix: hide banned accounts from feeds
commit 41ee46e013a799c49ecd794c7432102b12741809
Merge: bcc840c9 8ac373c7
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 5 21:51:12 2024 +0800
Merge pull request #643 from pocketnetteam/seeds/issue_569
seeds: add new fixed node ip by Issue #569
commit bc58922fff66f2aef79e63c466a4eed7a5cda712
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 5 21:30:45 2024 +0800
Fix RPCCacheEntry::Size() method
commit 800b5fa544e5c0a653d81743e20afc3b248568c4
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 5 21:28:16 2024 +0800
Fix RPCCacheEntry constructor bug
commit f3d63c07c8f63c6d4aa9cb9c930d15f9565e3e13
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 5 16:35:46 2024 +0800
Safe method for get current Height without mutex on cs_main
commit f4a422bd4dc6d4789340d0a02c118b45187c6ee0
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 5 16:33:24 2024 +0800
Fix cache size calculation and add size member to
RPCCacheEntry class
commit f6f2e4f62f07918aafd507fce906622794b4c8f1
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Jan 5 16:32:53 2024 +0800
Fix RPC method log format
commit bcc840c923c77f84bcd21ff85cea21e5d5739037
Merge: a5b9f60a be3578e2
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Sun Dec 31 14:51:12 2023 +0800
Merge pull request #642 from pocketnetteam/fix/check_update_url
fix: update GitHub API URL in PocketcoinApplication for fix checking updates
commit a5b9f60a57082027e9b41b0965b0f3258225e072
Merge: e01b8aca 7f075c4b
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Sun Dec 31 14:51:00 2023 +0800
Merge pull request #639 from pocketnetteam/feature/docker_tls
docs: expose tls ports in docker
commit e01b8acafe8e5a4097f28efe6710685cedc5b18f
Merge: cc546dc7 224a9b61
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Sun Dec 31 14:50:44 2023 +0800
Merge pull request #638 from pocketnetteam/fix/search_ids_of_posts
fix: search ranking bad sort and optional pagination arguments
commit a394978f6bc2ecbadffbcdce1fc18a38155a44be
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Dec 29 18:32:11 2023 +0800
Fix wrong JuryVerdict primary key
commit 9c12f8c2f17debbe1efa83da6fe7e93dd94d5c08
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Dec 29 17:35:32 2023 +0800
Filter feeds by active jury
commit be3067503c902f73bdb6263578f93a39a6f9d53e
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Dec 29 17:35:13 2023 +0800
Return contentId for getbans
commit 9eeba7d26ffd4d8eba2fa54de61e964344740603
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Dec 29 14:26:36 2023 +0800
Fix returned tx hash instead inner id
commit cf65350e6cfe447faff1f4b349a287094b8cdcd6
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Dec 29 14:24:11 2023 +0800
Added list of bans in getuserprofiles in short form
commit 6b2735e382f7669464c8a78284813647efbb3cf2
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Thu Dec 28 22:24:14 2023 +0800
Refactor WebRpcRepository.cpp to exclude posts
from banned users
commit 8ac373c79d04364b878e6f13603b6d2ef7daa21e
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Dec 26 18:04:34 2023 +0800
Remove unused IP addresses and update
chainparamsseeds.h
commit 07470165b4aaffdc69f7b4608738636a9acb9ee1
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Dec 26 18:04:02 2023 +0800
Request to add an IP address to the source code #569
commit be3578e2bcf2b3e0ac890ec14b444838645cc92f
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Dec 26 01:39:12 2023 +0800
Update GitHub API URL in PocketcoinApplication
class
commit 7f075c4b6c8914ee5d88eae1359da8a23b62c44a
Author: lostystyg <andrew300399@gmail.com>
Date: Thu Dec 21 10:18:44 2023 +0400
Expose tls ports in docker
commit 701417e208d729ab6ed684f2d3a5679fd294cc41
Author: lostystyg <andrew300399@gmail.com>
Date: Tue Dec 19 16:41:44 2023 +0400
List barteron offers not by tx hashes but by root tx hashes
commit cf2575f8fc9f06a191fec40ab1d5fb6f34f8c8e7
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Dec 18 20:39:42 2023 +0400
Restrict intermediate and target from the same address for getbarteroncomplexdeals
commit cf41cfc5e452c97af9476d6b5cdd165ebce22b62
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Dec 18 20:32:38 2023 +0400
Only last txs for getbarteroncomplexdeals
commit 224a9b613708dc5942d7600643daca3345308bfa
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Mon Dec 18 22:29:52 2023 +0800
Fix search ranking issue in SearchRepository.cpp
and optimize optional parameter parsing in
SearchRpc.cpp
commit b3d0c53b142b1e952c4ee789f427aa6599482807
Author: lostystyg <andrew300399@gmail.com>
Date: Thu Dec 14 15:13:56 2023 +0400
Allow to filter getbarterondeals by text in offer's description and title
commit 79770245f8f62f14ad821329e0130de0ee3ba656
Author: lostystyg <andrew300399@gmail.com>
Date: Wed Dec 13 09:22:55 2023 +0400
Allow to specify minimal price for getbarterondeals
commit 9b37f1c30f8e05604bb311ec9c85237b41e3eb55
Author: only1question <only1question@protonmail.com>
Date: Mon Dec 11 14:29:53 2023 +0300
Update transaction time handling in validation and mempool
The logic for handling transaction times has been restructured in both validation.cpp and txmempool.cpp. This includes differentiating between transactions with a nLockTime of 0 or greater, and adjusting transaction timings based on the nLockTime and the current state of the blockchain. It aims to ensure better handling and validation of transaction additions to the memory pool.
commit df60b31851f9dd98a8803d18c33795e481cf8037
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue Dec 5 23:31:53 2023 +0000
Bump tj-actions/branch-names from 6 to 7.0.7 in /.github/workflows
Bumps [tj-actions/branch-names](https://github.com/tj-actions/branch-names) from 6 to 7.0.7.
- [Release notes](https://github.com/tj-actions/branch-names/releases)
- [Changelog](https://github.com/tj-actions/branch-names/blob/main/HISTORY.md)
- [Commits](https://github.com/tj-actions/branch-names/compare/v6...v7.0.7)
---
updated-dependencies:
- dependency-name: tj-actions/branch-names
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
commit 81df29bbac1b64a9ec9f63161d7c130d6c88a813
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Dec 4 14:49:09 2023 +0400
ru_RU locale for migration logging
commit bae37ce5c4dee83a53fc023e2bac8e1095b32c2f
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Dec 4 12:33:14 2023 +0400
More informative logging on the 0.21 -> 0.22 migration process
commit f2c4fa2d39853bc7f89caf541f24bdcc9eea26da
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Fri Dec 1 23:39:22 2023 +0800
Add new REST endpoint - topaddresses
commit 9f59159d8a42d4040b3bc90b43aa546d2c6b0d62
Author: Andy Oknen <andy.oknen@yandex.ru>
Date: Tue Nov 28 23:50:20 2023 +0800
Fix private subscribers loop in RPC getmissedinfo
commit ff4adda89c338d9eecd6b057a23a2003ed2cd659
Author: lostystyg <andrew300399@gmail.com>
Date: Sat Dec 9 15:01:18 2023 +0400
Do not exclude offers without location if location filter is specified in getbarterondeals
commit 85cd219ec47f9d22f52ac1918e1fbf0ce2c77cd4
Author: only1question <only1question@protonmail.com>
Date: Thu Dec 7 12:12:24 2023 +0400
"Extend mempool expiry and add locktime handling in transactions"
This commit extends the expiration time for transactions in the memory pool from 26 hours to 168 hours in an effort to provide a more user-friendly process for managing transactions that may not be processed immediately due to network traffic.
We have also added locktime handling for transactions in PocketTransactionRpc.cpp. The locktime allows further control over when a transaction can be added to the blockchain, improving the capabilities of transaction scheduling.
In the validation.cpp file, we have extended the list of content types and adjusted the conditions for transaction acceptance into the memory pool. This change should increase the versatility of our transaction capabilities.
Furthermore, in the txmempool.cpp file, we have adjusted the conditions for transaction removal from the pool, considering the locktime value. This will prevent premature transaction expulsion and ensure a more predictable transaction life cycle.
commit d4d2f7803c385b606110cc670184b55d7bc88f38
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Dec 4 20:34:40 2023 +0400
fixup! fixup! Allow location filter for GetBarteronComplexDeals
commit 7b41e79a161a4d6af6bd52b686ad2aa89dca0f18
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Dec 4 19:45:00 2023 +0400
Fix typo
commit 72c0456f5cdb8589b511b0297a0266259406d982
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Dec 4 18:09:08 2023 +0400
fixup! Exclude possible one way offers from barteron complex deals
commit d7e3c898802b04dcd61326ae1c3655223fa86333
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Dec 4 17:58:23 2023 +0400
Exclude possible one way offers from barteron complex deals
commit 9d3a5a3535b762d89fd7d5829173e3e90fa307ca
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Dec 4 17:53:36 2023 +0400
Fix getbarteroncomplexdeals rpc name
commit a062858c634f9635b4924d9fef5a585b1acd2739
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Dec 4 16:04:05 2023 +0400
fixup! Allow location filter for GetBarteronComplexDeals
commit 310c5ee81f884b2b3dab0f85a40a986e4e95bef3
Author: lostystyg <andrew300399@gmail.com>
Date: Fri Dec 1 22:53:51 2023 +0400
Barteron user ratings in additional account info
commit 8938818abb895408b6361dced5e78e5884b627ad
Author: lostystyg <andrew300399@gmail.com>
Date: Tue Nov 28 17:50:09 2023 +0400
Allow location filter for GetBarteronComplexDeals
commit 1af239c6b93f8a9a0553c2800baf34b1dc527794
Author: lostystyg <andrew300399@gmail.com>
Date: Tue Nov 28 16:23:28 2023 +0400
Base GetBarteronComplexDeals (3-side search)
commit 3017f3b8c3ec2a6d7aed6340c06a240d31917b02
Author: lostystyg <andrew300399@gmail.com>
Date: Tue Nov 14 03:36:55 2023 +0400
cosmetics: renaming internal method
commit d42da2a31dc46d5feccca52fc343018b9c6dcf61
Author: lostystyg <andrew300399@gmail.com>
Date: Tue Nov 14 02:13:42 2023 +0400
fixup! Implement fetching additional data for barteron accounts
commit 8367e55ef8feb82f9f0a52494670eb48380e741d
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Nov 13 19:43:22 2023 +0400
Revert getbarteronfeed to answer only with offer txs
commit 634967df4704cd785c217b7e44585ac5e6f1c3cd
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Nov 13 18:03:08 2023 +0400
Change GetBarteronOffersDetails params naming: "scores" instead of "likes"
commit 67ded45c939ff91613fa36c483c7e8ad2286f4c4
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Nov 13 17:59:13 2023 +0400
Introduce GetBarteronOffersDetails rpc
commit 6a224cc3c292a3066985d9f6817f73169ff5f1ad
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Nov 13 17:55:45 2023 +0400
fixup! Simplify GetAccounts and rename it to GetAddresses
commit 8da48dd3a8fcf1c02f24e365ead2d4047f8ee8ed
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Nov 13 17:53:42 2023 +0400
Introduce GetAccountsIds for bastyon accounts
commit 766f530b7f5ce4f91bd2fbcfcee900b6661c17b5
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Nov 13 17:52:37 2023 +0400
Simplify GetAccounts and rename it to GetAddresses
commit f158f7fe2d082834a4cef7a9e21138df1f61eb41
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Nov 13 17:51:15 2023 +0400
fixup! Allow GetAccountsAdditionalInfo for any type of account (both bastyon and barteron)
commit 28ae37b0c8e0444e5ffb50e2ac049c26e002a16b
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Nov 13 15:06:51 2023 +0400
Allow GetAccountsAdditionalInfo for any type of account (both bastyon and barteron)
commit 95bbd44d6ee0231c6461e684145ed07f08eb139f
Author: lostystyg <andrew300399@gmail.com>
Date: Tue Nov 7 13:42:01 2023 +0400
Allow to pass multiple tags and addresses to getbarterondeals
commit 45bd5b51c6fe64c6d8318f519be6e43bb748ab9b
Author: lostystyg <andrew300399@gmail.com>
Date: Mon Nov 6 17:21:37 2023 +0400
Concrete parameters instead of offer_ids for getbarterondeals
commit 790cda34cb0655461fc3c5acff774309467f1e4c
Author: lostystyg <andrew300399@gmail.com>
Date: Fri Nov 3 18:30:53 2023 +0400
Extend getbarterondeals to be more general
commit 962a87c2a740aebf58f9f9cce2c9969bd9d6e365
Author: lostystyg <andrew300399@gmail.com>
Date: Wed Nov 1 17:45:11 2023 +0400
Collect ConsensusData for BarteronOffers before performing base checks
commit cd85514ca3a3f574871ee6f924af7a878eb09a20
Author: lostystyg <andrew300399@gmail.com>
Date: Wed Nov 1 17:44:42 2023 +0400
Increase ative_count limit for barteron offers on testnet
commit 32dec52ede784c99046655af41bbddab5cec3a2f
Author: lostystyg <andrew300399@gmail.com>
Date: Sat Oct 21 17:24:18 2023 +0400
Workaround for slow barteron scores and comments queries
commit 124f96de7b3811301d492660748f73087a9b7a55
Author: lostystyg <andrew300399@gmail.com>
Date: Fri Oct 20 20:22:59 2023 +0400
Rework barteron feed to handle scores and comments
commit a50e9702773c875b79d01dae0eb155ef69ea4c95
Author: lostystyg <andrew300399@gmail.com>
Date: Fri Oct 13 16:20:45 2023 +0400
Allow scores and comments to barteron offers
commit d623b70412ac3c02cbd8e0a3fea4efdf2d66bfc7
Author: lostystyg <andrew300399@gmail.com>
Date: Tue Oct 10 14:06:23 2023 +0400
Implement fetching additional data for barteron accounts
commit 8f780b64e85683706789eeb72f00678e4a0b27e7
Author: lostystyg <andrew300399@gmail.com>
Date: Tue Oct 10 12:11:01 2023 +0400
Index barteron_offer inside IndexContent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master (1e7564e) the depends build system, which is based on pure GNU Make, works, but it lacks robustness, and in some corner cases it fails. For example, see #22552.
Another bug in the depends build system has already become a problem at least two times in the past (#16883 (comment) and #24134). Each time the problem was solved with other means.
The initial solution had some discussion. Also it was discussed on the IRC meeting in #bitcoin-core-builds channel. This PR, actually, is a resurrection of it, as the bug silently struck pretty recently.
The bug is well described in #22719.
Here is another, a bit simpler description, which requires only basic shell (bash, dash etc) experience.
After creating targets by this code:
bitcoin/depends/funcs.mk
Line 280 in 1e7564e
$($(1)_config_env) $(call $(1)_config_cmds, $(1))becomes a shell command sequenceVAR1=foo VAR2=bar command1 && command2which is supposed to be executed in a new sub-shell.Please note that
VAR1=foo VAR2=barpart is visible for the firstcommand1only (for details see shell docs). Example:Using the
exportcommand is a trivial solution:As a new sub-shell is invoked for each line of the recipe, there are no side effects of using
export. It means this solution should not be considered invasive.Fixes #22719.
Also this PR removes no longer needed crutch from
qt.mk.