build, refactor: Improve package version usage #24276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dot is used as a separator in versions of other depends packages.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Feb 7, 2022
shaavan
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
ACK edc9a6a
The package version of boost is updated to the standard of displaying the package name. Other subsequent changes are made so that the package download path and file name remain unchanged.
The package version is also used correctly so that the download path of the expat remains unchanged.
I used the set of commands mentioned in the PR description to test this PR. The following screenshot compares Master's and PR's results, showing no visible differences.
Screenshot:
| Master | PR |
|---|---|
p.s.: The warning problem while running make expat_fetched on the PR branch seems unrelated to this PR.
Guix builds: |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 14, 2022
edc9a6a build, refactor: Reuse expat package version in its download path (Hennadii Stepanov) 4bb7821 build, refactor: Use conventional version notation for boost package (Hennadii Stepanov) Pull request description: `boost` package: - `.` is used as a separator in versions of other depends packages. `expat` package: - reuse package version in its download path --- The straightforward way to verify this PR: ``` $ cd depends $ make clean-all $ make boost_fetched $ make expat_fetched ``` ACKs for top commit: prusnak: ACK edc9a6a shaavan: ACK edc9a6a Tree-SHA512: c15d672fe34ac59850425d3d6a6eee5f720e16d227aad1332a563b218465879b7ee6fb865dd1bac06aedf356f9bb1c67112d9d88da8f877f04838b50a9dc97be
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boostpackage:.is used as a separator in versions of other depends packages.expatpackage:The straightforward way to verify this PR: