test: Fix failfast option for functional test runner #24195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Tested ACK a036358. I agree adding the |
pg156
approved these changes
Feb 5, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 7, 2022
…nner a036358 test: Repair failfast option for test runner (Martin Zumsande) Pull request description: Fixes bitcoin#23990 After bitcoin#23799, the `--failfast` option in the test runner for the functional tests stopped working, because a second outer loop was introduced, which would have needed a `break` too for the test runner to fail immediately. This also led to the errors reported in bitcoin#23990. This provides a straightforward fix for that. There is also bitcoin#23995 which is a larger refactor, but that hasn't been updated in a while to fix the failfast issue. ACKs for top commit: pg156: Tested ACK a036358. I agree adding the `all_passed` flag to break out of the outer loop when needed makes sense. The "failfast" option works after this change. Tree-SHA512: 3e2f775e36c13d180d32a05cd1cfe0883274e8615cdbbd4e069a9899e9b9ea1091066cf085e93f1c5326bd8ecc6ff524e0dad7c638f60dfdb169fefcdb26ee52
|
thanks!
…On Fri, Jan 28, 2022 at 4:01 PM Martin Zumsande ***@***.***> wrote:
Fixes #23990 <#23990>
After #23799 <#23799>, the
--failfast option in the test runner for the functional tests stopped
working, because a second outer loop was introduced, which would have
needed a break too for the test runner to fail immediately. This also led
to the errors reported in #23990
<#23990>.
This provides a straightforward fix for that.
There is also #23995 <#23995>
which is a larger refactor, but that hasn't been updated in a while to fix
the failfast issue.
------------------------------
You can view, comment on, or merge this pull request online at:
#24195
Commit Summary
- a036358
<a036358>
test: Repair failfast option for test runner
File Changes
(1 file <https://github.com/bitcoin/bitcoin/pull/24195/files>)
- *M* test/functional/test_runner.py
<https://github.com/bitcoin/bitcoin/pull/24195/files#diff-437d7f6e9f2229879b60aae574a8217f14c643bbf3cfa9225d8011d6d52df00c>
(6)
Patch Links:
- https://github.com/bitcoin/bitcoin/pull/24195.patch
- https://github.com/bitcoin/bitcoin/pull/24195.diff
—
Reply to this email directly, view it on GitHub
<#24195>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRS4WYTQYZN5XSZZJNSK3DUYKVTHANCNFSM5NA64R5Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23990
After #23799, the
--failfastoption in the test runner for the functional tests stopped working, because a second outer loop was introduced, which would have needed abreaktoo for the test runner to fail immediately. This also led to the errors reported in #23990.This provides a straightforward fix for that.
There is also #23995 which is a larger refactor, but that hasn't been updated in a while to fix the failfast issue.