Skip to content

test, bugfix: fix intermittent failure in getrawtransaction_tests #24113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2022
Merged

test, bugfix: fix intermittent failure in getrawtransaction_tests #24113

merged 1 commit into from
Jan 26, 2022

Conversation

jonatack
Copy link
Member

@jonatack jonatack commented Jan 20, 2022 •
edited
Loading

Easiest to review with colorMoved = dimmed-zebra and colorMovedWs = allow-indentation-change.

Resolves #23991

@jonatack
Copy link
Member Author

jonatack commented Jan 20, 2022 •
edited
Loading

@rajarshimaitra I added your commit from #22437 here. Edit: will do in the follow-up PR.

This was referenced Jan 20, 2022
Merged
Closed
@fanquake fanquake added the Tests label Jan 20, 2022
@jonatack jonatack force-pushed the rpc_rawtransaction-test-followups branch from 9a8a2b1 to b341378 Compare January 20, 2022 15:24
@jonatack jonatack changed the title test, refactor: add GetTransaction() coverage, part 2 test, refactor: GetTransaction() coverage, part 2 Jan 20, 2022
@maflcko
Copy link
Member

maflcko commented Jan 20, 2022

would it be possible to create a separate bugfix pr from the refactor pr to allow easier backporting/cherry-picking

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #23319 (rpc: Return fee and prevout (utxos) to getrawtransaction by dougEfresh)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@jonatack jonatack changed the title test, refactor: GetTransaction() coverage, part 2 test, bugfix: fix intermittent failure in getrawtransaction_tests Jan 20, 2022
@jonatack jonatack force-pushed the rpc_rawtransaction-test-followups branch from b341378 to 449dffc Compare January 20, 2022 20:16
@jonatack
Copy link
Member Author

would it be possible to create a separate bugfix pr from the refactor pr to allow easier backporting/cherry-picking

Sure, done here. Will open the refactor pull afterward.

@DrahtBot DrahtBot mentioned this pull request Jan 20, 2022
Merged
@maflcko maflcko merged commit 2935bd9 into bitcoin:master Jan 26, 2022
@maflcko
Copy link
Member

maflcko commented Jan 26, 2022

LGTM. Reviewed with --ignore-all-space -U8 --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space.

@jonatack jonatack deleted the rpc_rawtransaction-test-followups branch January 26, 2022 10:10
@jonatack
Copy link
Member Author

--ignore-all-space -U8 --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

Much better, noted, thanks!

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 28, 2022
Merge bitcoin#24113: test, bugfix: fix intermittent failure in getraw…
82ab7dd 
…transac…
@jonatack jonatack mentioned this pull request May 30, 2022
Merged
@bitcoin bitcoin locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rpc_rawtransaction.py issue
4 participants
@jonatack @maflcko @DrahtBot @fanquake