test: rest /tx with an invalid/unknown txid #24054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc73f53 to
a6376a8
Compare
jonatack
reviewed
Jan 13, 2022
There was a problem hiding this comment.
ACK a6376a8
A couple of (more self-documenting?) ideas for fun, feel free to ignore.
invalid_txid = "abc"
resp = self.test_rest_request(uri=f"/tx/{invalid_txid}", ret_type=RetType.OBJ, status=400)
assert_equal(resp.read().decode('utf-8').rstrip(), f"Invalid hash: {invalid_txid}")
unknown_txid ="0000000000000000000000000000000000000000000000000000000000000000"
resp = self.test_rest_request(uri=f"/tx/{unknown_txid}", ret_type=RetType.OBJ, status=404)
assert_equal(resp.read().decode('utf-8').rstrip(), f"{unknown_txid} not found") invalid_txid = "abc"
unknown_txid = "0000000000000000000000000000000000000000000000000000000000000000"
for tx in [{'id': invalid_txid, 'status': 400, 'error': f"Invalid hash: {invalid_txid}"},
{'id': unknown_txid, 'status': 404, 'error': f"{unknown_txid} not found"}]:
resp = self.test_rest_request(uri=f"/tx/{tx['id']}", status=tx['status'], ret_type=RetType.OBJ)
assert_equal(resp.read().decode('utf-8').rstrip(), tx['error'])a6376a8 to
6e3caa9
Compare
|
force-pushed addressing @jonatack's comment. Instead of creating |
jonatack
reviewed
Jan 13, 2022
6e3caa9 to
bd52684
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jan 14, 2022
kallewoof
reviewed
Jan 19, 2022
|
Posthumous ACK |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 20, 2022
bd52684 test: rest /tx with an invalid/unknown txid (brunoerg) Pull request description: This PR adds test coverage to the endpoint `/tx` (rest) passing an invalid and an unknown txid to test its return. Invalid -> should return status code 400 (bad request) Unknown -> should return status code 404 (not found) ACKs for top commit: kallewoof: ACK bd52684 Tree-SHA512: a7fbb63f30d06fc0855133a36e8317c7930ba13aa2b4a2dd1fc35079d59eacace72e1ffe7ae1b3e067066fe51792415940d72d923e83a659a0d5965e4110b32a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage to the endpoint
/tx(rest) passing an invalid and an unknown txid to test its return.Invalid -> should return status code 400 (bad request)
Unknown -> should return status code 404 (not found)