Skip to content

Conversation

ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Aug 17, 2018

Discussion in #13964 (comment) , fetch the latest port data before installing it.

Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, if this fixes the broken build.

Nit: Since you touch this file, might as well add a line version: '{branch}.{build}', so its easier to see which branch is built?

appveyor.yml Outdated
@@ -24,6 +24,8 @@ before_build:
$all_packages += $packages[$i] + ":" + $env:PLATFORM + "-windows-static "
}

git -C C:\Tools\vcpkg pull
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a trailing comment to this line, explaining that this is only temporary?

@maflcko maflcko added the Tests label Aug 17, 2018
@maflcko maflcko closed this Aug 17, 2018
@maflcko maflcko reopened this Aug 17, 2018
@maflcko
Copy link
Member

maflcko commented Aug 17, 2018

utACK ea16c2d

@maflcko maflcko merged commit ea16c2d into bitcoin:master Aug 17, 2018
maflcko pushed a commit that referenced this pull request Aug 17, 2018
ea16c2d appveyor: fetch the latest port data (Chun Kuan Lee)

Pull request description:

  Discussion in #13964 (comment) , fetch the latest port data before installing it.

Tree-SHA512: a3b95aeb3b298130ff0617a8dec5c97c0882cf7a3b72ce792e63d8f2c2ac4a297dfa0d3357878c2198a9fea62d0f24df56598293dde88963dd043e121be4dc3a
@ken2812221 ken2812221 deleted the patch-2 branch August 17, 2018 18:21
linuxsh2 pushed a commit to linuxsh2/dash that referenced this pull request Jul 29, 2021
ea16c2d appveyor: fetch the latest port data (Chun Kuan Lee)

Pull request description:

  Discussion in bitcoin#13964 (comment) , fetch the latest port data before installing it.

Tree-SHA512: a3b95aeb3b298130ff0617a8dec5c97c0882cf7a3b72ce792e63d8f2c2ac4a297dfa0d3357878c2198a9fea62d0f24df56598293dde88963dd043e121be4dc3a
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants