Skip to content

Call unicode API on Windows #13888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2018
Merged

Call unicode API on Windows #13888

merged 1 commit into from
Sep 13, 2018

Conversation

ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Aug 6, 2018 •
edited
Loading

Call Unicode API on Windows

@ken2812221 ken2812221 mentioned this pull request Aug 6, 2018
Closed
12 tasks
@laanwj laanwj added the Windows label Aug 6, 2018
donaloconnor
donaloconnor approved these changes Aug 11, 2018
View reviewed changes
Copy link
Contributor

@donaloconnor donaloconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 465f353

@alexeyneu
Copy link

i doubt that linker will change entry point coz of this . main to wmain change

@ken2812221
Copy link
Contributor Author

@alexeyneu How could that happen?

@alexeyneu
Copy link

unicode support means :

int wmain(int argc, wchar_t* argv[])

and /ENTRY:wmainCRTStartup in FLAGS . I strongly doubt that latter is added by gcc-msys-winlinux hybrid.
native unicode .exe makefile:
https://github.com/alexeyneu/json-demo/blob/master/makefile

@sipa
Copy link
Member

sipa commented Aug 12, 2018

@alexeyneu That seems to only affect whether or not command line arguments are passed in as wchar.

@ken2812221
Copy link
Contributor Author

ken2812221 commented Aug 12, 2018 •
edited
Loading

@alexeyneu You can see #13883 how I solve this. Since we are using mingw. The linker will link wmain only if you pass -municode to it, but I don't do this.

@alexeyneu
Copy link

alexeyneu commented Aug 12, 2018 •
edited
Loading

@ken2812221 yeah it does the trick in msys . I've thinkin that you pretend to solve whole issue mentioned
@sipa looks like it's command line related even in msvc

@laanwj
Copy link
Member

laanwj commented Sep 13, 2018

utACK d38bf91

@laanwj laanwj merged commit d38bf91 into bitcoin:master Sep 13, 2018
laanwj added a commit that referenced this pull request Sep 13, 2018
@laanwj
Merge #13888: Call unicode API on Windows
37b836a 
d38bf91 Call unicode API on Windows (Chun Kuan Lee)

Pull request description:

  Call Unicode API on Windows

Tree-SHA512: 93c290ee79c9d911fdada8ba45e184fc4f14d3cb56f33f39223286213878b08e8c4dd296a80099c57797d3b8589870e6cff622b22e76123d7452659d49dd8309
@ken2812221 ken2812221 deleted the windows-force-w branch September 13, 2018 10:15
@Bushstar Bushstar mentioned this pull request Oct 11, 2018
Merged
Warrows added a commit to Warrows/PIVX that referenced this pull request Oct 14, 2019
@Warrows
[Utils] Call unicode API on Windows
a7f5f32 
Backports bitcoin#13888
Warrows added a commit to Warrows/PIVX that referenced this pull request Nov 23, 2019
@Warrows
[Utils] Call unicode API on Windows
f5e69c3 
Backports bitcoin#13888
@bitcoin bitcoin deleted a comment from adrisys May 10, 2020
@furszy furszy mentioned this pull request Jun 24, 2021
Merged
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#13888: Call unicode API on Windows
63369d2 
d38bf91 Call unicode API on Windows (Chun Kuan Lee)

Pull request description:

  Call Unicode API on Windows

Tree-SHA512: 93c290ee79c9d911fdada8ba45e184fc4f14d3cb56f33f39223286213878b08e8c4dd296a80099c57797d3b8589870e6cff622b22e76123d7452659d49dd8309
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#13888: Call unicode API on Windows
9be6d3f 
d38bf91 Call unicode API on Windows (Chun Kuan Lee)

Pull request description:

  Call Unicode API on Windows

Tree-SHA512: 93c290ee79c9d911fdada8ba45e184fc4f14d3cb56f33f39223286213878b08e8c4dd296a80099c57797d3b8589870e6cff622b22e76123d7452659d49dd8309
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#13888: Call unicode API on Windows
b8787d6 
d38bf91 Call unicode API on Windows (Chun Kuan Lee)

Pull request description:

  Call Unicode API on Windows

Tree-SHA512: 93c290ee79c9d911fdada8ba45e184fc4f14d3cb56f33f39223286213878b08e8c4dd296a80099c57797d3b8589870e6cff622b22e76123d7452659d49dd8309
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#13888: Call unicode API on Windows
04152da 
d38bf91 Call unicode API on Windows (Chun Kuan Lee)

Pull request description:

  Call Unicode API on Windows

Tree-SHA512: 93c290ee79c9d911fdada8ba45e184fc4f14d3cb56f33f39223286213878b08e8c4dd296a80099c57797d3b8589870e6cff622b22e76123d7452659d49dd8309
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request Aug 5, 2021
@random-zebra
Merge #2449: Solve filename and command line encoding issues on Windows
61a098a 
63e0be6 [Remove] By-pass logprint-scanner restriction. (furszy)
280ced3 utils: Fix broken Windows filelock (Chun Kuan Lee)
be89860 utils: Convert Windows args to utf-8 string (Chun Kuan Lee)
e8cfa6e Call unicode API on Windows (Chun Kuan Lee)
1a02a8a tests: Add test case for std::ios_base::ate (Chun Kuan Lee)
2e57cd4 Move boost/std fstream to fsbridge (furszy)
9d8bcd4 utils: Add fsbridge fstream function wrapper (Chun Kuan Lee)
d59d48d utils: Convert fs error messages from multibyte to utf-8 (ken2812221)
9ef58cc Logging: use "fmterr" variable name for errors instead of general "e" that can be used by any other function. (furszy)
dd94241 utils: Use _wfopen and _wreopen on Windows (Chun Kuan Lee)
3993641 add unicode compatible file_lock for Windows (Chun Kuan Lee)
48349f8 Provide relevant error message if datadir is not writable. (murrayn)

Pull request description:

  As the software is currently using the ANSI encoding on Windows, the user's language settings could affect the proper functioning of the node/wallet, to the point of not be able to open some non-ASCII name files and directories.

  This solves the Windows encoding issues, completing the entire bitcoin#13869 work path (and some other required backports). Enabling for example users that use non-english characters in directories and file names to be accepted.

  Backported PRs:
  * bitcoin#12422.
  * bitcoin#12630.
  * bitcoin#13862.
  * bitcoin#13866.
  * bitcoin#13877.
  * bitcoin#13878.
  * bitcoin#13883.
  * bitcoin#13884.
  * bitcoin#13886.
  * bitcoin#13888.
  * bitcoin#14192.
  * bitcoin#13734.
  * bitcoin#14426.

  This is built on top of other two PRs that i have open #2423 and #2369.
  Solves old issues #940 and #2163.

  TODO:
  * Backport `assert_start_raises_init_error` and `ErrorMatch` in TestNode` (bitcoin#12718)

ACKs for top commit:
  Fuzzbawls:
    ACK 63e0be6
  random-zebra:
    ACK 63e0be6 and merging...

Tree-SHA512: cb1f7c23abb5b7b3af50bba18652cc2cad93fd7c2fca9c16ffd3fee34c4c152a3b666dfa87fe6b44c430064dcdee4367144dcb4a41203c91b0173b805bdb3d7d
@ryanofsky ryanofsky mentioned this pull request Oct 12, 2021
Merged
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 11, 2022
@ken2812221 @PiRK
Call unicode API on Windows
891d5ad 
Summary:
Rationale from issue [[bitcoin/bitcoin#13869 | core#13869]]:
> Currently Bitcoin uses the ANSI encoding on Windows so that it would affected by user's language settings, they might not able to open some non-ASCII name files.

This should unbreak the windows build, which was broken by D10801.

This is a backport of [[bitcoin/bitcoin#13888 | core#13888]]

Depends on D10816

Test Plan: @bot build-win64 gitian-win

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10815
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@donaloconnor donaloconnor donaloconnor approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ken2812221 @alexeyneu @sipa @laanwj @donaloconnor