Skip to content

qa: Extract rpc_timewait as test param #13837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2018
Merged

qa: Extract rpc_timewait as test param #13837

merged 1 commit into from
Aug 2, 2018

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Aug 1, 2018

Also increase it for wallet_dump and wallet_groups

qa: Extract rpc_timewait as test param
fa5b440 
Also increase it for wallet_dump and wallet_groups
@maflcko maflcko added the Tests label Aug 1, 2018
@maflcko maflcko added this to the 0.17.0 milestone Aug 1, 2018
@maflcko
Copy link
Member Author

maflcko commented Aug 1, 2018

Timeout in wallet_dump (observed on https://bitcoinperf.com/):

[1mwallet_dump.py[0m failed, Duration: 145 s[1mstdout:
[0m2018-08-01T16:16:03.257000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_test_runner_20180801_121146/wallet_dump_80
2018-08-01T16:17:28.529000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
 File "/tmp/bench-master-2018-08-01-1s9v29g9/bitcoin/test/functional/test_framework/authproxy.py", line 153, in _get_response
   http_response = self.__conn.getresponse()
 File "/usr/lib/python3.5/http/client.py", line 1198, in getresponse
   response.begin()
 File "/usr/lib/python3.5/http/client.py", line 297, in begin
   version, status, reason = self._read_status()
 File "/usr/lib/python3.5/http/client.py", line 258, in _read_status
   line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
 File "/usr/lib/python3.5/socket.py", line 576, in readinto
   return self._sock.recv_into(b)
socket.timeout: timed outDuring handling of the above exception, another exception occurred:Traceback (most recent call last):
 File "/tmp/bench-master-2018-08-01-1s9v29g9/bitcoin/test/functional/test_framework/test_framework.py", line 160, in main
   self.run_test()
 File "/tmp/bench-master-2018-08-01-1s9v29g9/bitcoin/test/functional/wallet_dump.py", line 153, in run_test
   self.nodes[0].importwallet(wallet_unenc_dump)
 File "/tmp/bench-master-2018-08-01-1s9v29g9/bitcoin/test/functional/test_framework/coverage.py", line 47, in __call__
   return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
 File "/tmp/bench-master-2018-08-01-1s9v29g9/bitcoin/test/functional/test_framework/authproxy.py", line 136, in __call__
   response = self._request('POST', self.__url.path, postdata.encode('utf-8'))
 File "/tmp/bench-master-2018-08-01-1s9v29g9/bitcoin/test/functional/test_framework/authproxy.py", line 107, in _request
   return self._get_response()
 File "/tmp/bench-master-2018-08-01-1s9v29g9/bitcoin/test/functional/test_framework/authproxy.py", line 160, in _get_response
   self.__conn.timeout)})
test_framework.authproxy.JSONRPCException: 'importwallet' RPC took longer than 60.000000 seconds. Consider using larger timeout for calls that take longer to return. (-344)

Timeout on wallet_groups (observed on macOS):

wallet_groups.py failed, Duration: 129 s
stdout:
2018-08-01T17:31:47.460000Z TestFramework (INFO): Initializing test directory /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/bitcoin_test_runner_20180801_172522/wallet_groups_46
2018-08-01T17:32:55.584000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/Users/travis/build/MarcoFalke/btc_nightly/bitcoin/test/functional/test_framework/authproxy.py", line 153, in _get_response
    http_response = self.__conn.getresponse()
  File "/usr/local/Cellar/python/3.6.5_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1331, in getresponse
    response.begin()
  File "/usr/local/Cellar/python/3.6.5_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "/usr/local/Cellar/python/3.6.5_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 258, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
  File "/usr/local/Cellar/python/3.6.5_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/socket.py", line 586, in readinto
    return self._sock.recv_into(b)
socket.timeout: timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/Users/travis/build/MarcoFalke/btc_nightly/bitcoin/test/functional/test_framework/test_framework.py", line 160, in main
    self.run_test()
  File "/Users/travis/build/MarcoFalke/btc_nightly/bitcoin/test/functional/wallet_groups.py", line 90, in run_test
    assert self.nodes[2].sendtoaddress(address=addr2[0], amount=5)
  File "/Users/travis/build/MarcoFalke/btc_nightly/bitcoin/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/Users/travis/build/MarcoFalke/btc_nightly/bitcoin/test/functional/test_framework/authproxy.py", line 136, in __call__
    response = self._request('POST', self.__url.path, postdata.encode('utf-8'))
  File "/Users/travis/build/MarcoFalke/btc_nightly/bitcoin/test/functional/test_framework/authproxy.py", line 107, in _request
    return self._get_response()
  File "/Users/travis/build/MarcoFalke/btc_nightly/bitcoin/test/functional/test_framework/authproxy.py", line 160, in _get_response
    self.__conn.timeout)})
test_framework.authproxy.JSONRPCException: 'sendtoaddress' RPC took longer than 60.000000 seconds. Consider using larger timeout for calls that take longer to return. (-344)

@jamesob
Copy link
Contributor

jamesob commented Aug 1, 2018

utACK fa5b440. Thanks!

jamesob
jamesob reviewed Aug 1, 2018
View reviewed changes
test/functional/test_framework/test_node.py
@@ -56,17 +56,13 @@ class TestNode():
To make things easier for the test writer, any unrecognised messages will
be dispatched to the RPC connection."""

def __init__(self, i, datadir, rpchost, timewait, bitcoind, bitcoin_cli, mocktime, coverage_dir, extra_conf=None, extra_args=None, use_cli=False):
def __init__(self, i, datadir, *, rpchost, timewait, bitcoind, bitcoin_cli, mocktime, coverage_dir, extra_conf=None, extra_args=None, use_cli=False):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: https://www.python.org/dev/peps/pep-3102/

@laanwj
Copy link
Member

laanwj commented Aug 2, 2018

utACK fa5b440

@laanwj laanwj merged commit fa5b440 into bitcoin:master Aug 2, 2018
laanwj added a commit that referenced this pull request Aug 2, 2018
@laanwj
Merge #13837: qa: Extract rpc_timewait as test param
990e182 
fa5b440 qa: Extract rpc_timewait as test param (MarcoFalke)

Pull request description:

  Also increase it for wallet_dump and wallet_groups

Tree-SHA512: 7367bc584228bda3010c453713a1505c54a8ef3d116be47dab9934d30594089dfeb27ffa862f7517fd0ec8b5dc07f4904d67ef2a53dd284cbe2a58982e410e2b
@maflcko maflcko deleted the Mf1808-qaRcpTimeWait branch August 2, 2018 12:38
@Bushstar Bushstar mentioned this pull request Aug 13, 2018
Merged
@furszy furszy mentioned this pull request Feb 18, 2021
Merged
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request Feb 21, 2021
@random-zebra
Merge #2207: Use non-atomic flushing with block replay
ac52366 
aab15d7 ReplayBlocks: use find instead of brackets operator to access to the element. (furszy)
e898353 [Refactoring] Use const CBlockIndex* where appropriate (random-zebra)
c76fa04 qa: Extract rpc_timewait as test param (furszy)
0f832e3 shutdown: Stop threads before resetting ptrs (MarcoFalke)
67aebbf http: Remove numThreads and ThreadCounter (Wladimir J. van der Laan)
e24c710 http: Remove WaitExit from WorkQueue (Wladimir J. van der Laan)
b8f7364 http: Join worker threads before deleting work queue (Wladimir J. van der Laan)
7d68769 rpc: further constrain the libevent workaround (Cory Fields)
75af065 rpc: work-around an upstream libevent bug (Cory Fields)
50e5833 Always return true if AppInitMain got to the end (Matt Corallo)
bd70dcc [qa] Test non-atomic chainstate writes (furszy)
8f04970 Dont create pcoinsTip until after ReplayBlocks. (Matt Corallo)
93f2b15 Random db flush crash simulator (Pieter Wuille)
72f3b17 Adapt memory usage estimation for flushing (Pieter Wuille)
8540113 Non-atomic flushing using the blockchain as replay journal (Pieter Wuille)
8d6625f [MOVEONLY] Move LastCommonAncestor to chain (Pieter Wuille)

Pull request description:

  > This patch adds an extra "head blocks" to the chainstate, which gives the range of blocks for writes may be incomplete. At the start of a flush, we write this record, write the dirty dbcache entries in 16 MiB batches, and at the end we remove the heads record again. If it is present at startup it means we crashed during flush, and we rollback/roll forward blocks inside of it to get a consistent tip on disk before proceeding.

  > If a flush completes succesfully, the resulting database is compatible with previous versions. If the node crashes in the middle of a flush, a version of the code with this patch is needed to recovery.

  An adaptation of the following PRs with further modifications to the `feature_dbcrash.py` test to be up-to-date with upstream and solve RPC related bugs.

  * bitcoin#10148.
  * Increase RPC wait time.
  * bitcoin#11831
  * bitcoin#11593
  * bitcoin#12366
  * bitcoin#13837
  * bitcoin#13894

ACKs for top commit:
  random-zebra:
    ACK aab15d7
  Fuzzbawls:
    ACK aab15d7

Tree-SHA512: 898806746f581a9eb8deb0155c558481abf4454c6f3b3c3ad505c557938d0700fe9796e98e36492286ae869378647072c3ad77ad65e9dd7075108ff96469ade1
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jun 29, 2021
@laanwj @UdjinM6
Merge bitcoin#13837: qa: Extract rpc_timewait as test param
e057c8c 
fa5b440 qa: Extract rpc_timewait as test param (MarcoFalke)

Pull request description:

  Also increase it for wallet_dump and wallet_groups

Tree-SHA512: 7367bc584228bda3010c453713a1505c54a8ef3d116be47dab9934d30594089dfeb27ffa862f7517fd0ec8b5dc07f4904d67ef2a53dd284cbe2a58982e410e2b
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jun 29, 2021
@laanwj @UdjinM6
Merge bitcoin#13837: qa: Extract rpc_timewait as test param
087c8c3 
fa5b440 qa: Extract rpc_timewait as test param (MarcoFalke)

Pull request description:

  Also increase it for wallet_dump and wallet_groups

Tree-SHA512: 7367bc584228bda3010c453713a1505c54a8ef3d116be47dab9934d30594089dfeb27ffa862f7517fd0ec8b5dc07f4904d67ef2a53dd284cbe2a58982e410e2b
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jul 1, 2021
@laanwj @UdjinM6
Merge bitcoin#13837: qa: Extract rpc_timewait as test param
8b757d0 
fa5b440 qa: Extract rpc_timewait as test param (MarcoFalke)

Pull request description:

  Also increase it for wallet_dump and wallet_groups

Tree-SHA512: 7367bc584228bda3010c453713a1505c54a8ef3d116be47dab9934d30594089dfeb27ffa862f7517fd0ec8b5dc07f4904d67ef2a53dd284cbe2a58982e410e2b
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jul 2, 2021
@laanwj @UdjinM6
Merge bitcoin#13837: qa: Extract rpc_timewait as test param
f371769 
fa5b440 qa: Extract rpc_timewait as test param (MarcoFalke)

Pull request description:

  Also increase it for wallet_dump and wallet_groups

Tree-SHA512: 7367bc584228bda3010c453713a1505c54a8ef3d116be47dab9934d30594089dfeb27ffa862f7517fd0ec8b5dc07f4904d67ef2a53dd284cbe2a58982e410e2b
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jul 2, 2021
@laanwj @UdjinM6
Merge bitcoin#13837: qa: Extract rpc_timewait as test param
d33dd31 
fa5b440 qa: Extract rpc_timewait as test param (MarcoFalke)

Pull request description:

  Also increase it for wallet_dump and wallet_groups

Tree-SHA512: 7367bc584228bda3010c453713a1505c54a8ef3d116be47dab9934d30594089dfeb27ffa862f7517fd0ec8b5dc07f4904d67ef2a53dd284cbe2a58982e410e2b
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jamesob jamesob jamesob left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@maflcko @jamesob @laanwj