depends: use MacOS friendly sed syntax in qt.mk #13750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With all these MacOS specific exceptions popping up recently, I almost wonder if it would not be more beneficial to "expect" (or even enforce) brew GNU versions of tools to be installed rather than the archaic pseudo-BSD MacOS versions? |
|
This line goes away again in #13696 by the way. |
Maybe, but apparently OpenBSB often encounters the same issues (cc @laanwj), so macOS devs help catch problems there this way :-) |
|
This is not the first time should work fine? |
|
@fanquake yes, my comment stems from knowing that (in general) there are some differences between MacOS |
|
@fanquake I'll try |
|
@Fuzzbawls Sure, sorry if I sounded dismissive. There definitely are some differences, i.e something like #13514 which I stumbled on when playing around with iOS depends builds. |
735a2b9 to
12c93cb
Compare
|
@fanquake hey no worries mate! I myself don't even know all the (seemingly stupid) differences between MacOS tools and GNU (or even more recent BSD). I just know there are differences...and those differences may ore may not ever apply here...and if they do...lets make sure they are exclusive to MacOS and exclude them for being archaic (require brew GNU equivilent in this case) rather than cater to such exclusions. |
|
utACK 12c93cb |
|
utACK 12c93cb |
maflcko
pushed a commit
that referenced
this pull request
Jul 25, 2018
12c93cb depends: use MacOS friendly sed syntax in qt.mk (Sjors Provoost) Pull request description: I just got this error on master: ``` make clean-all make -j5 [...] /bitcoin/depends/sources/qttools-opensource-src-5.9.6.tar.xz: OK Preprocessing qt... sed: 1: "qtbase/mkspecs/bitcoin- ...": extra characters at the end of q command make: *** /bitcoin/depends/work/build/x86_64-apple-darwin17.7.0/qt/5.9.6-b48df1b490b/.stamp_preprocessed] Error 1 ``` Tree-SHA512: 1eaee535c0d637a67801c7dd48e9cd5a037823f4e162a6f50e375787045fdb95929f409a88c7d000d8781a4edc497b5ccb1fd23a24e29324ec633157fadd371e
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jul 26, 2020
12c93cb depends: use MacOS friendly sed syntax in qt.mk (Sjors Provoost) Pull request description: I just got this error on master: ``` make clean-all make -j5 [...] /bitcoin/depends/sources/qttools-opensource-src-5.9.6.tar.xz: OK Preprocessing qt... sed: 1: "qtbase/mkspecs/bitcoin- ...": extra characters at the end of q command make: *** /bitcoin/depends/work/build/x86_64-apple-darwin17.7.0/qt/5.9.6-b48df1b490b/.stamp_preprocessed] Error 1 ``` Tree-SHA512: 1eaee535c0d637a67801c7dd48e9cd5a037823f4e162a6f50e375787045fdb95929f409a88c7d000d8781a4edc497b5ccb1fd23a24e29324ec633157fadd371e
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jul 27, 2020
12c93cb depends: use MacOS friendly sed syntax in qt.mk (Sjors Provoost) Pull request description: I just got this error on master: ``` make clean-all make -j5 [...] /bitcoin/depends/sources/qttools-opensource-src-5.9.6.tar.xz: OK Preprocessing qt... sed: 1: "qtbase/mkspecs/bitcoin- ...": extra characters at the end of q command make: *** /bitcoin/depends/work/build/x86_64-apple-darwin17.7.0/qt/5.9.6-b48df1b490b/.stamp_preprocessed] Error 1 ``` Tree-SHA512: 1eaee535c0d637a67801c7dd48e9cd5a037823f4e162a6f50e375787045fdb95929f409a88c7d000d8781a4edc497b5ccb1fd23a24e29324ec633157fadd371e
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jul 27, 2020
12c93cb depends: use MacOS friendly sed syntax in qt.mk (Sjors Provoost) Pull request description: I just got this error on master: ``` make clean-all make -j5 [...] /bitcoin/depends/sources/qttools-opensource-src-5.9.6.tar.xz: OK Preprocessing qt... sed: 1: "qtbase/mkspecs/bitcoin- ...": extra characters at the end of q command make: *** /bitcoin/depends/work/build/x86_64-apple-darwin17.7.0/qt/5.9.6-b48df1b490b/.stamp_preprocessed] Error 1 ``` Tree-SHA512: 1eaee535c0d637a67801c7dd48e9cd5a037823f4e162a6f50e375787045fdb95929f409a88c7d000d8781a4edc497b5ccb1fd23a24e29324ec633157fadd371e
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 27, 2020
12c93cb depends: use MacOS friendly sed syntax in qt.mk (Sjors Provoost) Pull request description: I just got this error on master: ``` make clean-all make -j5 [...] /bitcoin/depends/sources/qttools-opensource-src-5.9.6.tar.xz: OK Preprocessing qt... sed: 1: "qtbase/mkspecs/bitcoin- ...": extra characters at the end of q command make: *** /bitcoin/depends/work/build/x86_64-apple-darwin17.7.0/qt/5.9.6-b48df1b490b/.stamp_preprocessed] Error 1 ``` Tree-SHA512: 1eaee535c0d637a67801c7dd48e9cd5a037823f4e162a6f50e375787045fdb95929f409a88c7d000d8781a4edc497b5ccb1fd23a24e29324ec633157fadd371e
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 28, 2020
12c93cb depends: use MacOS friendly sed syntax in qt.mk (Sjors Provoost) Pull request description: I just got this error on master: ``` make clean-all make -j5 [...] /bitcoin/depends/sources/qttools-opensource-src-5.9.6.tar.xz: OK Preprocessing qt... sed: 1: "qtbase/mkspecs/bitcoin- ...": extra characters at the end of q command make: *** /bitcoin/depends/work/build/x86_64-apple-darwin17.7.0/qt/5.9.6-b48df1b490b/.stamp_preprocessed] Error 1 ``` Tree-SHA512: 1eaee535c0d637a67801c7dd48e9cd5a037823f4e162a6f50e375787045fdb95929f409a88c7d000d8781a4edc497b5ccb1fd23a24e29324ec633157fadd371e
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Jul 2, 2021
12c93cb depends: use MacOS friendly sed syntax in qt.mk (Sjors Provoost) Pull request description: I just got this error on master: ``` make clean-all make -j5 [...] /bitcoin/depends/sources/qttools-opensource-src-5.9.6.tar.xz: OK Preprocessing qt... sed: 1: "qtbase/mkspecs/bitcoin- ...": extra characters at the end of q command make: *** /bitcoin/depends/work/build/x86_64-apple-darwin17.7.0/qt/5.9.6-b48df1b490b/.stamp_preprocessed] Error 1 ``` Tree-SHA512: 1eaee535c0d637a67801c7dd48e9cd5a037823f4e162a6f50e375787045fdb95929f409a88c7d000d8781a4edc497b5ccb1fd23a24e29324ec633157fadd371e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just got this error on master: