Skip to content

Conversation

AkioNak
Copy link
Contributor

@AkioNak AkioNak commented Jul 19, 2018

This PR adds benchmarks for the unserialization of the prevector.

Note: Separated from #12324.

t0.resize(28);
for (auto x = 0; x < 1001; ++x) {
s0 << t0;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review: To closing to actual condition, it would be better to include the case where the size exceeds the initial capacity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@fanquake fanquake added the Tests label Jul 19, 2018
This patch adds 2 benchmarks to measure for performance of
the unserialization of prevector.
@AkioNak AkioNak force-pushed the add_bench_unserialize branch from 72b2a49 to 46340b3 Compare July 20, 2018 08:58
Copy link
Contributor

@kallewoof kallewoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 46340b3

@maflcko maflcko merged commit 46340b3 into bitcoin:master Jul 27, 2018
maflcko pushed a commit that referenced this pull request Jul 27, 2018
46340b3 [bench] Add benchmark for unserialize prevector (Akio Nakamura)

Pull request description:

  This PR adds benchmarks for the unserialization of the prevector.

  Note: Separated from #12324.

Tree-SHA512: c055a283328cc2634c01eb60f26604a8665939bbf77d367b6ba6b4e01e77d4511fab69cc3ddb1e62969adb3c48752ed870f45ceba153eee192302601341e18a7
@AkioNak AkioNak deleted the add_bench_unserialize branch August 13, 2018 01:08
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 29, 2020
46340b3 [bench] Add benchmark for unserialize prevector (Akio Nakamura)

Pull request description:

  This PR adds benchmarks for the unserialization of the prevector.

  Note: Separated from bitcoin#12324.

Tree-SHA512: c055a283328cc2634c01eb60f26604a8665939bbf77d367b6ba6b4e01e77d4511fab69cc3ddb1e62969adb3c48752ed870f45ceba153eee192302601341e18a7
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jul 1, 2021
46340b3 [bench] Add benchmark for unserialize prevector (Akio Nakamura)

Pull request description:

  This PR adds benchmarks for the unserialization of the prevector.

  Note: Separated from bitcoin#12324.

Tree-SHA512: c055a283328cc2634c01eb60f26604a8665939bbf77d367b6ba6b4e01e77d4511fab69cc3ddb1e62969adb3c48752ed870f45ceba153eee192302601341e18a7
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants