Remove redundant variables, statements and forward declarations #13691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unsure on 1d45dcd and dc0996f because they serve to help document the code. |
dc0996f to
ea01d65
Compare
|
Agree with @Empact |
|
@Empact Thanks for the quick review! I've now excluded dc0996f15ab99c8307bf63efd339cad20ddcb562 from this PR – I see your point. Regarding 1d45dcd67dbb7319e9acd6dd36ce7106727cb18a, what does that add from a documentation viewpoint? |
|
@practicalswift the value is modest, but the declaration makes the default explicit, removing an otherwise-required unit of knowledge for the reader. Avoids the risk of an inappropriate expectation or assumption, particularly relevant since |
ea01d65 to
3dee4cc
Compare
|
@Empact I see your point. I've now excluded that commit. @Empact @MarcoFalke Please re-review :-) |
|
utACK 3dee4cc. |
|
utACK 3dee4cc |
|
utACK 3dee4cc |
|
utACK 3dee4cc |
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
maflcko
pushed a commit
that referenced
this pull request
Jul 22, 2018
…arations 3dee4cc Remove redundant statement (practicalswift) 99be644 Remove redundant unused variables (practicalswift) 66ed242 Remove redundant forward declaration (practicalswift) Pull request description: Remove redundant … * ~access modifiers,~ * forward declarations, * unused variables, * statements, and * ~return types from lambdas.~ Tree-SHA512: 328bb7d9c45398e44ecbee32095b6376879470dfddbc2180e037620d8390d524b51d7fda112fd58a078715e04432b24dd6998a2459f3550aa0498aa68de866d4
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 27, 2019
Summary: Remove redundant … * ~access modifiers,~ * forward declarations, * unused variables, * statements, and * ~return types from lambdas.~ Backport of Bitcoin Core PR13691 bitcoin/bitcoin#13691 Test Plan: ``` make check-all ``` Reviewers: Fabien, #bitcoin_abc, deadalnix, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Subscribers: jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D4142
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 2, 2021
…rd declarations 3dee4cc Remove redundant statement (practicalswift) 99be644 Remove redundant unused variables (practicalswift) 66ed242 Remove redundant forward declaration (practicalswift) Pull request description: Remove redundant … * ~access modifiers,~ * forward declarations, * unused variables, * statements, and * ~return types from lambdas.~ Tree-SHA512: 328bb7d9c45398e44ecbee32095b6376879470dfddbc2180e037620d8390d524b51d7fda112fd58a078715e04432b24dd6998a2459f3550aa0498aa68de866d4
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 4, 2021
…rd declarations 3dee4cc Remove redundant statement (practicalswift) 99be644 Remove redundant unused variables (practicalswift) 66ed242 Remove redundant forward declaration (practicalswift) Pull request description: Remove redundant … * ~access modifiers,~ * forward declarations, * unused variables, * statements, and * ~return types from lambdas.~ Tree-SHA512: 328bb7d9c45398e44ecbee32095b6376879470dfddbc2180e037620d8390d524b51d7fda112fd58a078715e04432b24dd6998a2459f3550aa0498aa68de866d4
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 27, 2022
…rd declarations 3dee4cc Remove redundant statement (practicalswift) 99be644 Remove redundant unused variables (practicalswift) 66ed242 Remove redundant forward declaration (practicalswift) Pull request description: Remove redundant … * ~access modifiers,~ * forward declarations, * unused variables, * statements, and * ~return types from lambdas.~ Tree-SHA512: 328bb7d9c45398e44ecbee32095b6376879470dfddbc2180e037620d8390d524b51d7fda112fd58a078715e04432b24dd6998a2459f3550aa0498aa68de866d4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant …
access modifiers,return types from lambdas.