[moveonly] Extract CWallet::MarkInputsDirty, and privatize AddToWalletIfInvolvingMe #13651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
reviewed
Jul 13, 2018
| @@ -703,9 +703,27 @@ class CWallet final : public CCryptoKeyStore, public CValidationInterface | |||
| void AddToSpends(const COutPoint& outpoint, const uint256& wtxid); | |||
| void AddToSpends(const uint256& wtxid); | |||
|
|
|||
| /** | |||
| * Add a transaction to the wallet, or update it. pIndex and posInBlock should | |||
There was a problem hiding this comment.
... if belongs to the wallet?
There was a problem hiding this comment.
Going to leave as moveonly.
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
| Needs rebase |
To avoid repeated implementations.
And document in the header.
de381c6 to
17e6aa8
Compare
|
Rebased for #12944 |
|
(re)utACK 17e6aa8. |
|
utACK 17e6aa8 |
|
utACK 17e6aa8 |
sipa
added a commit
that referenced
this pull request
Jul 14, 2018
…ize AddToWalletIfInvolvingMe 17e6aa8 Privatize CWallet::AddToWalletIfInvolvingMe (Ben Woosley) b7f5650 Extract CWallet::MarkInputsDirty (Ben Woosley) Pull request description: Thus reducing code and surface area of CWallet. Tree-SHA512: 31a99acc77ef3438ef9b95d60030972b707bd69d6e7b1498a5f776b219d9aabc83464f75bfec7bad5cb635d0b2d686c389914e5cc57a4bb0b93c47bd82ca608c
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 29, 2021
… privatize AddToWalletIfInvolvingMe 17e6aa8 Privatize CWallet::AddToWalletIfInvolvingMe (Ben Woosley) b7f5650 Extract CWallet::MarkInputsDirty (Ben Woosley) Pull request description: Thus reducing code and surface area of CWallet. Tree-SHA512: 31a99acc77ef3438ef9b95d60030972b707bd69d6e7b1498a5f776b219d9aabc83464f75bfec7bad5cb635d0b2d686c389914e5cc57a4bb0b93c47bd82ca608c
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 29, 2021
… privatize AddToWalletIfInvolvingMe 17e6aa8 Privatize CWallet::AddToWalletIfInvolvingMe (Ben Woosley) b7f5650 Extract CWallet::MarkInputsDirty (Ben Woosley) Pull request description: Thus reducing code and surface area of CWallet. Tree-SHA512: 31a99acc77ef3438ef9b95d60030972b707bd69d6e7b1498a5f776b219d9aabc83464f75bfec7bad5cb635d0b2d686c389914e5cc57a4bb0b93c47bd82ca608c
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jul 1, 2021
… privatize AddToWalletIfInvolvingMe 17e6aa8 Privatize CWallet::AddToWalletIfInvolvingMe (Ben Woosley) b7f5650 Extract CWallet::MarkInputsDirty (Ben Woosley) Pull request description: Thus reducing code and surface area of CWallet. Tree-SHA512: 31a99acc77ef3438ef9b95d60030972b707bd69d6e7b1498a5f776b219d9aabc83464f75bfec7bad5cb635d0b2d686c389914e5cc57a4bb0b93c47bd82ca608c
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jul 2, 2021
… privatize AddToWalletIfInvolvingMe 17e6aa8 Privatize CWallet::AddToWalletIfInvolvingMe (Ben Woosley) b7f5650 Extract CWallet::MarkInputsDirty (Ben Woosley) Pull request description: Thus reducing code and surface area of CWallet. Tree-SHA512: 31a99acc77ef3438ef9b95d60030972b707bd69d6e7b1498a5f776b219d9aabc83464f75bfec7bad5cb635d0b2d686c389914e5cc57a4bb0b93c47bd82ca608c
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jul 2, 2021
… privatize AddToWalletIfInvolvingMe 17e6aa8 Privatize CWallet::AddToWalletIfInvolvingMe (Ben Woosley) b7f5650 Extract CWallet::MarkInputsDirty (Ben Woosley) Pull request description: Thus reducing code and surface area of CWallet. Tree-SHA512: 31a99acc77ef3438ef9b95d60030972b707bd69d6e7b1498a5f776b219d9aabc83464f75bfec7bad5cb635d0b2d686c389914e5cc57a4bb0b93c47bd82ca608c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus reducing code and surface area of CWallet.