Skip to content

build: add missing leveldb defines #13659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2018
Merged

build: add missing leveldb defines #13659

merged 1 commit into from
Jul 14, 2018

Conversation

theuni
Copy link
Member

@theuni theuni commented Jul 13, 2018 •
edited
Loading

Fixes #13585.

src/leveldb/build_detect_platform shows how upstream defines them.

These platform may not be able to fully build or run Bitcoin Core, but defining all known to leveldb saves future hassle.

Now that all possible platforms are enumerated, specifying an unknown one is an error.

@theuni
build: add missing leveldb defines
768981c 
src/leveldb/build_detect_platform shows how upstream defines them.

These platform may not be able to fully build or run Bitcoin, but defining all
known to leveldb saves future hassle.

Now that all possible platforms are enumerated, specifying an unknown one is an
error.
@maflcko
Copy link
Member

maflcko commented Jul 13, 2018

ACK 768981c (built src/bitcoind on SmartOS, which wasn't possible previously. Didn't check anything else)

@sipa
Copy link
Member

sipa commented Jul 13, 2018

utACK 768981c

@Empact
Copy link
Contributor

Empact commented Jul 13, 2018 •
edited
Loading

Noticed leveldb includes a build_detect_platform script, which includes these and other settings (e.g. handling of cygwin, -D_REENTRANT for various), should we be using the script directly instead?
https://github.com/bitcoin/bitcoin/blob/master/src/leveldb/build_detect_platform

utACK 768981c

@sipa
Copy link
Member

sipa commented Jul 13, 2018

@Empact Read the history here (#7911) about why we moved away from using LevelDB's own build system.

@fanquake
Copy link
Member

utACK 768981c

@sipa sipa merged commit 768981c into bitcoin:master Jul 14, 2018
sipa added a commit that referenced this pull request Jul 14, 2018
@sipa
Merge #13659: build: add missing leveldb defines
90b1c7e 
768981c build: add missing leveldb defines (Cory Fields)

Pull request description:

  Fixes #13585.

  src/leveldb/build_detect_platform shows how upstream defines them.

  These platform may not be able to fully build or run Bitcoin Core, but defining all known to leveldb saves future hassle.

  Now that all possible platforms are enumerated, specifying an unknown one is an error.

Tree-SHA512: 89adfb8867248e50d713cb84485c72a398df8b2af467599cf292132342b5b47f01be3a298ca33e382e210004123aa72a6338bc911d38d40d8ceaef5083e0b025
@Bushstar Bushstar mentioned this pull request Jul 16, 2018
Merged
@theuni theuni mentioned this pull request Jul 19, 2018
Closed
greenaddress pushed a commit to greenaddress/bitcoin_ndk that referenced this pull request Jul 20, 2018
remove patch for leveldb thanks to bitcoin/bitcoin#13659
c41866b
greenaddress pushed a commit to greenaddress/bitcoin_ndk that referenced this pull request Jul 20, 2018
update for 0.17.x/master and remove patch for leveldb thanks
0766c6f 
to bitcoin/bitcoin#13659
also remove ifaddr patches thanks
to theuni/bitcoin@6c32dd0
greenaddress pushed a commit to greenaddress/bitcoin_ndk that referenced this pull request Jul 20, 2018
update for 0.17.x/master and remove patch for leveldb thanks
b2de467 
to bitcoin/bitcoin#13659
also reduce ifaddr patches thanks
to theuni/bitcoin@6c32dd0
greenaddress pushed a commit to greenaddress/bitcoin_ndk that referenced this pull request Aug 22, 2018
update for 0.17.0rc2 and remove patch for leveldb thanks
1331b77 
to bitcoin/bitcoin#13659
also reduce ifaddr patches thanks
to theuni/bitcoin@6c32dd0
greenaddress pushed a commit to greenaddress/bitcoin_ndk that referenced this pull request Aug 22, 2018
update for 0.17.0rc2 and remove patch for leveldb thanks
5339318 
to bitcoin/bitcoin#13659
also reduce ifaddr patches thanks
to theuni/bitcoin@6c32dd0
greenaddress pushed a commit to greenaddress/bitcoin_ndk that referenced this pull request Aug 22, 2018
update for 0.17.0rc2 and remove patch for leveldb thanks
be2036c 
to bitcoin/bitcoin#13659
also reduce ifaddr patches thanks
to theuni/bitcoin@6c32dd0
greenaddress pushed a commit to greenaddress/bitcoin_ndk that referenced this pull request Aug 22, 2018
update for 0.17.0rc2 and remove patch for leveldb thanks
d7ded83 
to bitcoin/bitcoin#13659
also reduce ifaddr patches thanks
to theuni/bitcoin@6c32dd0
greenaddress pushed a commit to greenaddress/bitcoin_ndk that referenced this pull request Aug 23, 2018
update for 0.17.0rc2 and remove patch for leveldb thanks
1b7e273 
to bitcoin/bitcoin#13659
also reduce ifaddr patches thanks
to theuni/bitcoin@6c32dd0
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 19, 2020
@sipa @PastaPastaPasta
Merge bitcoin#13659: build: add missing leveldb defines
92a6550 
768981c build: add missing leveldb defines (Cory Fields)

Pull request description:

  Fixes bitcoin#13585.

  src/leveldb/build_detect_platform shows how upstream defines them.

  These platform may not be able to fully build or run Bitcoin Core, but defining all known to leveldb saves future hassle.

  Now that all possible platforms are enumerated, specifying an unknown one is an error.

Tree-SHA512: 89adfb8867248e50d713cb84485c72a398df8b2af467599cf292132342b5b47f01be3a298ca33e382e210004123aa72a6338bc911d38d40d8ceaef5083e0b025
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 24, 2020
@sipa @PastaPastaPasta
Merge bitcoin#13659: build: add missing leveldb defines
db8327c 
768981c build: add missing leveldb defines (Cory Fields)

Pull request description:

  Fixes bitcoin#13585.

  src/leveldb/build_detect_platform shows how upstream defines them.

  These platform may not be able to fully build or run Bitcoin Core, but defining all known to leveldb saves future hassle.

  Now that all possible platforms are enumerated, specifying an unknown one is an error.

Tree-SHA512: 89adfb8867248e50d713cb84485c72a398df8b2af467599cf292132342b5b47f01be3a298ca33e382e210004123aa72a6338bc911d38d40d8ceaef5083e0b025
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 27, 2020
@sipa @PastaPastaPasta
Merge bitcoin#13659: build: add missing leveldb defines
a1c8cac 
768981c build: add missing leveldb defines (Cory Fields)

Pull request description:

  Fixes bitcoin#13585.

  src/leveldb/build_detect_platform shows how upstream defines them.

  These platform may not be able to fully build or run Bitcoin Core, but defining all known to leveldb saves future hassle.

  Now that all possible platforms are enumerated, specifying an unknown one is an error.

Tree-SHA512: 89adfb8867248e50d713cb84485c72a398df8b2af467599cf292132342b5b47f01be3a298ca33e382e210004123aa72a6338bc911d38d40d8ceaef5083e0b025
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jul 27, 2020
@sipa @UdjinM6
Merge bitcoin#13659: build: add missing leveldb defines
e443c34 
768981c build: add missing leveldb defines (Cory Fields)

Pull request description:

  Fixes bitcoin#13585.

  src/leveldb/build_detect_platform shows how upstream defines them.

  These platform may not be able to fully build or run Bitcoin Core, but defining all known to leveldb saves future hassle.

  Now that all possible platforms are enumerated, specifying an unknown one is an error.

Tree-SHA512: 89adfb8867248e50d713cb84485c72a398df8b2af467599cf292132342b5b47f01be3a298ca33e382e210004123aa72a6338bc911d38d40d8ceaef5083e0b025
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jul 27, 2020
@sipa @UdjinM6
Merge bitcoin#13659: build: add missing leveldb defines
545d157 
768981c build: add missing leveldb defines (Cory Fields)

Pull request description:

  Fixes bitcoin#13585.

  src/leveldb/build_detect_platform shows how upstream defines them.

  These platform may not be able to fully build or run Bitcoin Core, but defining all known to leveldb saves future hassle.

  Now that all possible platforms are enumerated, specifying an unknown one is an error.

Tree-SHA512: 89adfb8867248e50d713cb84485c72a398df8b2af467599cf292132342b5b47f01be3a298ca33e382e210004123aa72a6338bc911d38d40d8ceaef5083e0b025
@str4d str4d mentioned this pull request Jan 25, 2021
Merged
zkbot added a commit to zcash/zcash that referenced this pull request Jan 25, 2021
@zkbot
Auto merge of #4961 - str4d:leveldb-1.22-prep, r=str4d
ce5d8da 
Prepare for LevelDB 1.22 update

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#7944
- bitcoin/bitcoin#8604
  - Only the first commit (we removed the upstream build documentation).
- bitcoin/bitcoin#12294
  - Only the third commit.
- bitcoin/bitcoin#13659
- bitcoin/bitcoin#16110
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jun 26, 2021
@sipa
Merge bitcoin#13659: build: add missing leveldb defines
6ecfacd 
768981c build: add missing leveldb defines (Cory Fields)

Pull request description:

  Fixes bitcoin#13585.

  src/leveldb/build_detect_platform shows how upstream defines them.

  These platform may not be able to fully build or run Bitcoin Core, but defining all known to leveldb saves future hassle.

  Now that all possible platforms are enumerated, specifying an unknown one is an error.

Tree-SHA512: 89adfb8867248e50d713cb84485c72a398df8b2af467599cf292132342b5b47f01be3a298ca33e382e210004123aa72a6338bc911d38d40d8ceaef5083e0b025
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@sipa @PastaPastaPasta
Merge bitcoin#13659: build: add missing leveldb defines
727caa8 
768981c build: add missing leveldb defines (Cory Fields)

Pull request description:

  Fixes bitcoin#13585.

  src/leveldb/build_detect_platform shows how upstream defines them.

  These platform may not be able to fully build or run Bitcoin Core, but defining all known to leveldb saves future hassle.

  Now that all possible platforms are enumerated, specifying an unknown one is an error.

Tree-SHA512: 89adfb8867248e50d713cb84485c72a398df8b2af467599cf292132342b5b47f01be3a298ca33e382e210004123aa72a6338bc911d38d40d8ceaef5083e0b025
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@sipa @PastaPastaPasta
Merge bitcoin#13659: build: add missing leveldb defines
b8a2358 
768981c build: add missing leveldb defines (Cory Fields)

Pull request description:

  Fixes bitcoin#13585.

  src/leveldb/build_detect_platform shows how upstream defines them.

  These platform may not be able to fully build or run Bitcoin Core, but defining all known to leveldb saves future hassle.

  Now that all possible platforms are enumerated, specifying an unknown one is an error.

Tree-SHA512: 89adfb8867248e50d713cb84485c72a398df8b2af467599cf292132342b5b47f01be3a298ca33e382e210004123aa72a6338bc911d38d40d8ceaef5083e0b025
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@sipa @PastaPastaPasta
Merge bitcoin#13659: build: add missing leveldb defines
1aaa509 
768981c build: add missing leveldb defines (Cory Fields)

Pull request description:

  Fixes bitcoin#13585.

  src/leveldb/build_detect_platform shows how upstream defines them.

  These platform may not be able to fully build or run Bitcoin Core, but defining all known to leveldb saves future hassle.

  Now that all possible platforms are enumerated, specifying an unknown one is an error.

Tree-SHA512: 89adfb8867248e50d713cb84485c72a398df8b2af467599cf292132342b5b47f01be3a298ca33e382e210004123aa72a6338bc911d38d40d8ceaef5083e0b025
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't compile bitcoin for SmartOS - recipe for target 'leveldb/util/leveldb_libleveldb_a-env_posix.o' failed
5 participants
@theuni @maflcko @sipa @Empact @fanquake