build: Detect if char equals int8_t #13580

ken2812221 · 2018-07-01T14:11:32Z

Probably fixes #13576. I'm not able to test this. @stacepellegrino, can you test this?

stacepellegrino · 2018-07-01T14:48:03Z

Just testing changes now. Performing build to see if it fixes https://github.com/bitcoin/bitcoin/issues/13576

stacepellegrino · 2018-07-01T15:00:15Z

Did not fix the problem...

# make
Making all in src
make[1]: Entering directory '/opt/local/src/bitcoin/src'
make[2]: Entering directory '/opt/local/src/bitcoin/src'
make[3]: Entering directory '/opt/local/src/bitcoin'
make[3]: Leaving directory '/opt/local/src/bitcoin'
  CXX      crypto/libbitcoinconsensus_la-aes.lo
  CXX      crypto/libbitcoinconsensus_la-chacha20.lo
  CXX      crypto/libbitcoinconsensus_la-hmac_sha256.lo
  CXX      crypto/libbitcoinconsensus_la-hmac_sha512.lo
  CXX      crypto/libbitcoinconsensus_la-ripemd160.lo
  CXX      crypto/libbitcoinconsensus_la-sha1.lo
  CXX      crypto/libbitcoinconsensus_la-sha256.lo
  CXX      crypto/libbitcoinconsensus_la-sha512.lo
  CXX      crypto/libbitcoinconsensus_la-sha256_sse4.lo
  CXX      libbitcoinconsensus_la-arith_uint256.lo
  CXX      consensus/libbitcoinconsensus_la-merkle.lo
In file included from ./script/script.h:11:0,
                 from ./primitives/transaction.h:11,
                 from ./consensus/merkle.h:11,
                 from consensus/merkle.cpp:5:
./serialize.h:195:39: error: redefinition of 'template<class Stream> void Serialize(Stream&, int8_t)'
 template<typename Stream> inline void Serialize(Stream& s, int8_t a  ) { ser_wr
                                       ^
./serialize.h:193:39: note: 'template<class Stream> void Serialize(Stream&, char)' previously declared here
 template<typename Stream> inline void Serialize(Stream& s, char a    ) { ser_wr
                                       ^
In file included from ./script/script.h:11:0,
                 from ./primitives/transaction.h:11,
                 from ./consensus/merkle.h:11,
                 from consensus/merkle.cpp:5:
./serialize.h:213:39: error: redefinition of 'template<class Stream> void Unserialize(Stream&, int8_t&)'
 template<typename Stream> inline void Unserialize(Stream& s, int8_t& a  ) { a =
                                       ^
./serialize.h:211:39: note: 'template<class Stream> void Unserialize(Stream&, char&)' previously declared here
 template<typename Stream> inline void Unserialize(Stream& s, char& a    ) { a =
                                       ^
Makefile:8138: recipe for target 'consensus/libbitcoinconsensus_la-merkle.lo' failed
make[2]: *** [consensus/libbitcoinconsensus_la-merkle.lo] Error 1
make[2]: Leaving directory '/opt/local/src/bitcoin/src'
Makefile:9824: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/opt/local/src/bitcoin/src'
Makefile:757: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1

stacepellegrino · 2018-07-01T15:06:44Z

The configure script generates the following as part of its output...

checking for if type char equals int8_t... no

ken2812221 · 2018-07-01T15:09:03Z

Can you provide your config.log?

stacepellegrino · 2018-07-01T15:26:25Z

Here it is...

config.log

ken2812221 · 2018-07-01T15:42:13Z

I forgot to specify the error message for static_assert, would u mind to test this again?

stacepellegrino · 2018-07-01T16:03:17Z

That works! Please update the main branch of source with this change.

However, my build failed with...

CXX compat/libbitcoin_util_a-glibc_sanity.o
In file included from compat/glibc_sanity.cpp:12:0:
compat/glibc_sanity.cpp: In function 'bool {anonymous}::sanity_test_fdelt()':
compat/glibc_sanity.cpp:53:5: error: 'memset' was not declared in this scope
FD_ZERO(&fds);
^
Makefile:6248: recipe for target 'compat/libbitcoin_util_a-glibc_sanity.o' failed
make[2]: *** [compat/libbitcoin_util_a-glibc_sanity.o] Error 1
make[2]: Leaving directory '/opt/local/src/bitcoin/src'
Makefile:9824: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/opt/local/src/bitcoin/src'
Makefile:757: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1

Shall I open this as a new issue?

stacepellegrino · 2018-07-01T16:39:22Z

Checking for type char equals int8_t fixed.

Opened a new build issue #13581

Empact · 2018-07-01T19:06:22Z

configure.ac

+AC_MSG_CHECKING(for if type char equals int8_t)
+AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <stdint.h>
+  #include <type_traits>]],
+ [[ static_assert(std::is_same<int8_t, char>::value, ""); ]])],


nit: may as well provide a message for the static_assert?

Empact · 2018-07-01T19:06:46Z

utACK 49d1f4c

jb55

utACK 49d1f4c

laanwj · 2018-07-04T09:43:24Z

Can someone please explain why this is needed? I've been compiling bitcoin core on platforms that have char=uint8_t (such as ARM) as well as char=int8_t (such as x86) for years without needing any special define logic for this. What is different on this platform?

luke-jr · 2018-07-04T10:12:22Z

Apparently ARM and x86 have int8_t = signed char, whereas SunOS has int8_t = char?

laanwj · 2018-07-05T11:16:56Z

Thanks @luke-jr, I understand then.
utACK 49d1f4c

laanwj · 2018-07-05T11:20:46Z

src/serialize.h

@@ -189,7 +189,9 @@ template<typename X> const X& ReadWriteAsHelper(const X& x) { return x; }
        SerializationOp(s, CSerActionUnserialize());                  \
    }

+#ifndef CHAR_EQUALS_INT8
 template<typename Stream> inline void Serialize(Stream& s, char a    ) { ser_writedata8(s, a); } // TODO Get rid of bare char


I like the TODO here - not sure its still the goal, certainly not in this PR, would have to carefully consider the consequences for serialization.

@stacepellegrino

49d1f4c Detect if char equals int8_t (Chun Kuan Lee) Pull request description: Probably fixes #13576. I'm not able to test this. @stacepellegrino, can you test this? Tree-SHA512: b750e00e11e6b6f6341fec668ec2254cc101c8ebdd4878f320d6cb3b07cf326761146e4ceff0b6405b7e503ff64c093a8274bd524a097e2c49382dc296972c4f

@stacepellegrino

49d1f4c Detect if char equals int8_t (Chun Kuan Lee) Pull request description: Probably fixes bitcoin#13576. I'm not able to test this. @stacepellegrino, can you test this? Tree-SHA512: b750e00e11e6b6f6341fec668ec2254cc101c8ebdd4878f320d6cb3b07cf326761146e4ceff0b6405b7e503ff64c093a8274bd524a097e2c49382dc296972c4f

@stacepellegrino

49d1f4c Detect if char equals int8_t (Chun Kuan Lee) Pull request description: Probably fixes bitcoin#13576. I'm not able to test this. @stacepellegrino, can you test this? Tree-SHA512: b750e00e11e6b6f6341fec668ec2254cc101c8ebdd4878f320d6cb3b07cf326761146e4ceff0b6405b7e503ff64c093a8274bd524a097e2c49382dc296972c4f

@stacepellegrino

49d1f4c Detect if char equals int8_t (Chun Kuan Lee) Pull request description: Probably fixes bitcoin#13576. I'm not able to test this. @stacepellegrino, can you test this? Tree-SHA512: b750e00e11e6b6f6341fec668ec2254cc101c8ebdd4878f320d6cb3b07cf326761146e4ceff0b6405b7e503ff64c093a8274bd524a097e2c49382dc296972c4f

@stacepellegrino

49d1f4c Detect if char equals int8_t (Chun Kuan Lee) Pull request description: Probably fixes bitcoin#13576. I'm not able to test this. @stacepellegrino, can you test this? Tree-SHA512: b750e00e11e6b6f6341fec668ec2254cc101c8ebdd4878f320d6cb3b07cf326761146e4ceff0b6405b7e503ff64c093a8274bd524a097e2c49382dc296972c4f

fanquake added the Build system label Jul 1, 2018

Detect if char equals int8_t

49d1f4c

stacepellegrino mentioned this pull request Jul 1, 2018

Can't compile bitcoin for SmartOS - recipe for target 'compat/libbitcoin_util_a-glibc_sanity.o' failed #13581

Closed

Empact reviewed Jul 1, 2018

View reviewed changes

jb55 approved these changes Jul 3, 2018

View reviewed changes

laanwj requested a review from theuni July 4, 2018 09:43

laanwj reviewed Jul 5, 2018

View reviewed changes

laanwj merged commit 49d1f4c into bitcoin:master Jul 5, 2018

ken2812221 deleted the int8_t-char-is_same branch July 5, 2018 11:39

Bushstar mentioned this pull request Jul 9, 2018

commits from bitcoin/master FeatherCoin/Feathercoin#353

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build: Detect if char equals int8_t #13580

build: Detect if char equals int8_t #13580

Uh oh!

ken2812221 commented Jul 1, 2018

Uh oh!

stacepellegrino commented Jul 1, 2018

Uh oh!

stacepellegrino commented Jul 1, 2018

Uh oh!

stacepellegrino commented Jul 1, 2018

Uh oh!

ken2812221 commented Jul 1, 2018

Uh oh!

stacepellegrino commented Jul 1, 2018

Uh oh!

ken2812221 commented Jul 1, 2018

Uh oh!

stacepellegrino commented Jul 1, 2018

Uh oh!

stacepellegrino commented Jul 1, 2018 •

edited

Loading

Uh oh!

Empact Jul 1, 2018

Uh oh!

Empact commented Jul 1, 2018

Uh oh!

jb55 left a comment

Uh oh!

laanwj commented Jul 4, 2018

Uh oh!

luke-jr commented Jul 4, 2018

Uh oh!

laanwj commented Jul 5, 2018

Uh oh!

laanwj Jul 5, 2018

Uh oh!

Uh oh!

build: Detect if char equals int8_t #13580

build: Detect if char equals int8_t #13580

Uh oh!

Conversation

ken2812221 commented Jul 1, 2018

Uh oh!

stacepellegrino commented Jul 1, 2018

Uh oh!

stacepellegrino commented Jul 1, 2018

Uh oh!

stacepellegrino commented Jul 1, 2018

Uh oh!

ken2812221 commented Jul 1, 2018

Uh oh!

stacepellegrino commented Jul 1, 2018

Uh oh!

ken2812221 commented Jul 1, 2018

Uh oh!

stacepellegrino commented Jul 1, 2018

Uh oh!

stacepellegrino commented Jul 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Empact Jul 1, 2018

Choose a reason for hiding this comment

Uh oh!

Empact commented Jul 1, 2018

Uh oh!

jb55 left a comment

Choose a reason for hiding this comment

Uh oh!

laanwj commented Jul 4, 2018

Uh oh!

luke-jr commented Jul 4, 2018

Uh oh!

laanwj commented Jul 5, 2018

Uh oh!

laanwj Jul 5, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stacepellegrino commented Jul 1, 2018 •

edited

Loading