Scripts and tools: Obsolete #!/bin/bash shebang #13510

DesWurstes · 2018-06-20T12:12:23Z

#!/bin/bash assumes it is always installed to /bin/ which can cause issues
#!/usr/bin/env bash searches the user's PATH to find the bash binary

Details: https://github.com/dylanaraps/pure-bash-bible#obsolete-syntax

I'm open to comments: Should I also fix #!/bin/sh?

ken2812221

utACK 0000000

promag · 2018-06-20T13:23:48Z

utACK 0000000.

luke-jr · 2018-06-20T17:13:15Z

Did you bruteforce that hash? What did you use as the nonce?

maflcko · 2018-06-20T17:21:22Z

@luke-jr

git log --format=fuller 0000000 -1
commit 000000035b20402dea3e8168165cd4eefdc97539
Author:     DesWurstes <DesWurstes@users.noreply.github.com>
AuthorDate: Wed Jun 20 12:54:54 2018 +0300
Commit:     DesWurstes <DesWurstes@users.noreply.github.com>
CommitDate: Wed Jun 20 11:12:41 2018 +0300

    Obsolete #!/bin/bash shebang

DesWurstes · 2018-06-20T17:22:33Z

Timestamp, it is two hours earlier than the actual commit time.

practicalswift · 2018-06-20T21:01:14Z

utACK 0000000

Nice hash!

Empact · 2018-06-22T17:45:43Z

utACK 0000000

laanwj · 2018-06-24T14:29:32Z

Agree that this is better. BSD ports tend to install bash to /usr/local, for example.

I'm open to comments: Should I also fix #!/bin/sh?

I'd say, no. /bin/sh is by definition the system shell. Use of the system shell has its own issues (like the script having to be compatible with 80's shell dialect, the lowest common denominator of all shells), but the location is not one of them.

utACK 0000000

0000000 Obsolete #!/bin/bash shebang (DesWurstes) Pull request description: > `#!/bin/bash` assumes it is always installed to `/bin/` which can cause issues > `#!/usr/bin/env bash` searches the user's `PATH` to find the `bash` binary Details: https://github.com/dylanaraps/pure-bash-bible#obsolete-syntax I'm open to comments: Should I also fix `#!/bin/sh`? Tree-SHA512: b47bb4828116aa119f1899c68fee081270d51a898535490b9c616bf0f3660ad953f29c361eafc759bc64cdd54ee6eeecb2d79e9fdb5291a996a515c719805476

…ad of #!/bin/bash. 688f665 Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes. (vim88) Pull request description: As it was discussed in [bitcoin#13510](bitcoin#13510), it is better to use `#!/usr/bin/env bash` instead of `#!/bin/bash`. Tree-SHA512: 25f71eb9a6a0cdc91568b5c6863205c5fe095f77a69e633503a2ac7805bd9013af8538e538c0c666ce96a28e3f43ce7a8df5f08d4ff007723bb588d85674f2da

0000000 Obsolete #!/bin/bash shebang (DesWurstes) Pull request description: > `#!/bin/bash` assumes it is always installed to `/bin/` which can cause issues > `#!/usr/bin/env bash` searches the user's `PATH` to find the `bash` binary Details: https://github.com/dylanaraps/pure-bash-bible#obsolete-syntax I'm open to comments: Should I also fix `#!/bin/sh`? Tree-SHA512: b47bb4828116aa119f1899c68fee081270d51a898535490b9c616bf0f3660ad953f29c361eafc759bc64cdd54ee6eeecb2d79e9fdb5291a996a515c719805476

…ad of #!/bin/bash. 688f665 Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes. (vim88) Pull request description: As it was discussed in [bitcoin#13510](bitcoin#13510), it is better to use `#!/usr/bin/env bash` instead of `#!/bin/bash`. Tree-SHA512: 25f71eb9a6a0cdc91568b5c6863205c5fe095f77a69e633503a2ac7805bd9013af8538e538c0c666ce96a28e3f43ce7a8df5f08d4ff007723bb588d85674f2da

…sh instead of #!/bin/bash. 688f665 Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes. (vim88) Pull request description: As it was discussed in [bitcoin#13510](bitcoin#13510), it is better to use `#!/usr/bin/env bash` instead of `#!/bin/bash`. Tree-SHA512: 25f71eb9a6a0cdc91568b5c6863205c5fe095f77a69e633503a2ac7805bd9013af8538e538c0c666ce96a28e3f43ce7a8df5f08d4ff007723bb588d85674f2da

Obsolete #!/bin/bash shebang

0000000

fanquake added the Scripts and tools label Jun 20, 2018

ken2812221 approved these changes Jun 20, 2018

View reviewed changes

laanwj merged commit 0000000 into bitcoin:master Jun 24, 2018

Bushstar mentioned this pull request Jun 25, 2018

commits from bitcoin/master FeatherCoin/Feathercoin#349

Merged

This was referenced Nov 28, 2018

Scripts and tools: Use #!/usr/bin/env bash instead of #!/bin/bash. #14831

Merged

Docs: Adds development guidelines about Scripts shebang to developer-notes.md. #14846

Closed

str4d mentioned this pull request Oct 27, 2020

Backport useful lints from upstream zcash/zcash#4829

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Scripts and tools: Obsolete #!/bin/bash shebang #13510

Scripts and tools: Obsolete #!/bin/bash shebang #13510

Uh oh!

DesWurstes commented Jun 20, 2018

Uh oh!

ken2812221 left a comment •

edited

Loading

Uh oh!

promag commented Jun 20, 2018

Uh oh!

luke-jr commented Jun 20, 2018

Uh oh!

maflcko commented Jun 20, 2018

Uh oh!

DesWurstes commented Jun 20, 2018

Uh oh!

practicalswift commented Jun 20, 2018

Uh oh!

Empact commented Jun 22, 2018

Uh oh!

laanwj commented Jun 24, 2018 •

edited

Loading

Uh oh!

Uh oh!

Scripts and tools: Obsolete #!/bin/bash shebang #13510

Scripts and tools: Obsolete #!/bin/bash shebang #13510

Uh oh!

Conversation

DesWurstes commented Jun 20, 2018

Uh oh!

ken2812221 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

promag commented Jun 20, 2018

Uh oh!

luke-jr commented Jun 20, 2018

Uh oh!

maflcko commented Jun 20, 2018

Uh oh!

DesWurstes commented Jun 20, 2018

Uh oh!

practicalswift commented Jun 20, 2018

Uh oh!

Empact commented Jun 22, 2018

Uh oh!

laanwj commented Jun 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ken2812221 left a comment •

edited

Loading

laanwj commented Jun 24, 2018 •

edited

Loading