Skip to content

doc: Remove note to install all boost dev packages #13460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2018
Merged

doc: Remove note to install all boost dev packages #13460

merged 1 commit into from
Jun 14, 2018

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jun 13, 2018

Those notes are for systems that are EOL. Also, those instructions would pull in a ton of additional dependencies such as python2.

Can be reviewed with git diff HEAD~ --word-diff

@maflcko maflcko added the Docs label Jun 13, 2018
@promag
Copy link
Contributor

promag commented Jun 14, 2018

Travis failed with same error as #13461 (comment)

  CXXLD    bitcoin-cli
  CXXLD    bitcoin-tx
  CXXLD    test/test_bitcoin
  CXXLD    bench/bench_bitcoin
  OBJCXXLD qt/bitcoin-qt
/bin/mkdir -p Bitcoin-Qt.app/Contents/MacOS
STRIPPROG="/home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11/share/../native/bin/x86_64-apple-darwin11-strip" /bin/bash /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-apple-darwin11/build-aux/install-sh -c -s  src/qt/bitcoin-qt Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-apple-darwin11/build-aux/install-sh: src/qt/bitcoin-qt does not exist.
Makefile:1214: recipe for target 'Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt' failed
make: *** [Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt] Error 1
make: *** Waiting for unfinished jobs....

promag
promag reviewed Jun 14, 2018
View reviewed changes
doc/build-unix.md
2. If that doesn't work, you can install all boost development packages with:

sudo apt-get install libboost-all-dev
sudo apt-get install build-essential libtool autotools-dev automake pkg-config libssl-dev libevent-dev bsdmainutils python3 libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-program-options-dev libboost-test-dev libboost-thread-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultra nit sort packages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why bsdmainutils?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promag hexdump

@bitcoin bitcoin deleted a comment from martinpgaunt Jun 14, 2018
@laanwj
Copy link
Member

laanwj commented Jun 14, 2018

utACK fa3d39e

@Empact Empact mentioned this pull request Jun 14, 2018
Closed
@practicalswift
Copy link
Contributor

utACK fa3d39e

@maflcko maflcko merged commit fa3d39e into bitcoin:master Jun 14, 2018
maflcko pushed a commit that referenced this pull request Jun 14, 2018
Merge #13460: doc: Remove note to install all boost dev packages
1939536 
fa3d39e doc: Remove note to install all boost dev packages (MarcoFalke)

Pull request description:

  Those notes are for systems that are EOL. Also, those instructions would pull in a ton of additional dependencies such as `python2`.

  Can be reviewed with `git diff HEAD~ --word-diff`

Tree-SHA512: 7e379b3f0b7fe88452baed8860438a7867a025e650a265ed0cd5d47076983f4176545b7d96a4b7f25ae9fcb325f0116d909f3ffb6ff2d7573fddd777fe5b4c79
@maflcko maflcko deleted the Mf1806-docBuildUbuntu branch June 14, 2018 20:39
@Bushstar Bushstar mentioned this pull request Jun 15, 2018
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laanwj laanwj laanwj left review comments

+1 more reviewer

@promag promag promag left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maflcko @promag @laanwj @practicalswift