Skip to content

When build fails due to lib missing, indicate which one #13435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2018
Merged

When build fails due to lib missing, indicate which one #13435

merged 1 commit into from
Jun 13, 2018

Conversation

Empact
Copy link
Contributor

@Empact Empact commented Jun 11, 2018

A failure of "lib missing" has limited utility.

@laanwj laanwj requested a review from theuni June 11, 2018 12:27
@laanwj
Copy link
Member

laanwj commented Jun 11, 2018

Concept ACK (tagged @theuni for review)

can you paste an example error before and after this change if a lib is missing?

promag
promag reviewed Jun 11, 2018
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, it's a useful detail.

Nit, same format as

bitcoin/configure.ac

Line 1054 in 3f0f394

AC_CHECK_LIB([event],[main],EVENT_LIBS=-levent,AC_MSG_ERROR(libevent missing))

@practicalswift
Copy link
Contributor

Concept ACK

Nice usability improvement!

@Empact
When build fails due to lib missing, indicate which one
51cd508 
A failure of "lib missing" has limited utility.
@Empact
Copy link
Contributor Author

Empact commented Jun 11, 2018

Updated format

@practicalswift
Copy link
Contributor

utACK 51cd508

@Empact
Copy link
Contributor Author

Empact commented Jun 11, 2018 •
edited
Loading

Before this change:

$ ./configure --enable-glibc-back-compat
checking build system type... x86_64-apple-darwin17.5.0
[...]
checking for __attribute__((visibility))... no
checking for __attribute__((dllexport))... no
checking for __attribute__((dllimport))... no
checking for clock_gettime in -lrt... no
configure: error: lib missing

After this change:

$ make clean
$ ./configure --enable-glibc-back-compat
checking build system type... x86_64-apple-darwin17.5.0
[...]
checking for __attribute__((visibility))... no
checking for __attribute__((dllexport))... no
checking for __attribute__((dllimport))... no
checking for clock_gettime in -lrt... no
configure: error: librt missing

theuni
theuni approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 51cd508

@maflcko
Copy link
Member

maflcko commented Jun 12, 2018

utACK 51cd508

ken2812221
ken2812221 approved these changes Jun 13, 2018
View reviewed changes
Copy link
Contributor

@ken2812221 ken2812221 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 51cd508

@laanwj laanwj merged commit 51cd508 into bitcoin:master Jun 13, 2018
laanwj added a commit that referenced this pull request Jun 13, 2018
@laanwj
Merge #13435: When build fails due to lib missing, indicate which one
cf7ca60 
51cd508 When build fails due to lib missing, indicate which one (Ben Woosley)

Pull request description:

  A failure of "lib missing" has limited utility.

Tree-SHA512: de77c077ea223bb862a6261fd99e9ddc533e28ed42837ac4262a1c0f24d73add4d2baae6be5cb5ef2012be32bcc3ae587dbc1eab0c42b633bea8eec64b18a249
@Bushstar Bushstar mentioned this pull request Jun 15, 2018
Merged
@Empact Empact deleted the lib-missing branch July 14, 2018 20:40
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 7, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#13435: When build fails due to lib missing, indicate wh…
8a78e4f 
…ich one

51cd508 When build fails due to lib missing, indicate which one (Ben Woosley)

Pull request description:

  A failure of "lib missing" has limited utility.

Tree-SHA512: de77c077ea223bb862a6261fd99e9ddc533e28ed42837ac4262a1c0f24d73add4d2baae6be5cb5ef2012be32bcc3ae587dbc1eab0c42b633bea8eec64b18a249
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jun 28, 2021
@laanwj @gades
Merge bitcoin#13435: When build fails due to lib missing, indicate wh…
a3f0d0e 
…ich one

51cd508 When build fails due to lib missing, indicate which one (Ben Woosley)

Pull request description:

  A failure of "lib missing" has limited utility.

Tree-SHA512: de77c077ea223bb862a6261fd99e9ddc533e28ed42837ac4262a1c0f24d73add4d2baae6be5cb5ef2012be32bcc3ae587dbc1eab0c42b633bea8eec64b18a249
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
3 more reviewers

@promag promag promag left review comments

@theuni theuni theuni approved these changes

@ken2812221 ken2812221 ken2812221 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Empact @laanwj @practicalswift @maflcko @theuni @promag @ken2812221 @fanquake