RPC Docs: gettxout*: clarify bestblock and unspent counts #13184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3dec5da to
2fa92ff
Compare
|
Concept ACK |
2fa92ff to
f30e9be
Compare
|
Travis failure seems unrelated. |
|
utACK f30e9be |
1 similar comment
|
utACK f30e9be |
maflcko
pushed a commit
that referenced
this pull request
May 7, 2018
f30e9be RPC Docs: gettxout*: clarify bestblock and unspent counts (David A. Harding) Pull request description: Expounds on two things I've seen confuse inexperienced users: - transactions/outputs in `gettxoutsetinfo`: a user thought this was the total number of transactions or outputs ever seen on the chain, whereas it's only the number in the UTXO. - bestblock in `gettxout`: a user thought this was the block that included the output, not realizing it was the tip of the current best block chain. I also copied this text to `gettxoutsetinfo` for congruency. I skimmed other uses of "bestblock" in the RPC docs and they seemed clear to me. Tree-SHA512: c2161c497bef5fe15ee9f1e2a4413fa099b5baa36205ba1ba4b3822885b3ccd1badb9c118a0334f47ba6fa7fff5818ac359cfac6a1108c6847a876b1a251bb7c
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
May 17, 2018
GitHub-Pull: bitcoin#13184 Rebased-From: f30e9be
laanwj
added a commit
that referenced
this pull request
May 24, 2018
acdf433 Hold cs_main while calling UpdatedBlockTip() and ui.NotifyBlockTip (Jesse Cohen) 5ff571e [wallet] [tests] Test disallowed multiwallet params (John Newbery) 4c14e7b [wallet] Fix zapwallettxes/multiwallet interaction. (John Newbery) 4087dd0 RPC Docs: gettxout*: clarify bestblock and unspent counts (David A. Harding) b8aacd6 [qa] Handle disconnect_node race (Suhas Daftuar) Pull request description: Backports: - #13201 [qa] Handle disconnect_node race - #13184 RPC Docs: gettxout*: clarify bestblock and unspent counts - #13030 [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. - #12988 Hold cs_main while calling UpdatedBlockTip() signal to the 0.16 branch. Tree-SHA512: 8f65002bbafaf9c436f89051b2d79bf6a668fbd07bd317c64af238ed4a7c8efe776864b739a7f2869f1e3daa16f2f4366a85f41b188f9c454879d2c7b309be50
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Jun 29, 2018
GitHub-Pull: bitcoin#13184 Rebased-From: f30e9be
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 3, 2020
…nt counts f30e9be RPC Docs: gettxout*: clarify bestblock and unspent counts (David A. Harding) Pull request description: Expounds on two things I've seen confuse inexperienced users: - transactions/outputs in `gettxoutsetinfo`: a user thought this was the total number of transactions or outputs ever seen on the chain, whereas it's only the number in the UTXO. - bestblock in `gettxout`: a user thought this was the block that included the output, not realizing it was the tip of the current best block chain. I also copied this text to `gettxoutsetinfo` for congruency. I skimmed other uses of "bestblock" in the RPC docs and they seemed clear to me. Tree-SHA512: c2161c497bef5fe15ee9f1e2a4413fa099b5baa36205ba1ba4b3822885b3ccd1badb9c118a0334f47ba6fa7fff5818ac359cfac6a1108c6847a876b1a251bb7c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expounds on two things I've seen confuse inexperienced users:
transactions/outputs in
gettxoutsetinfo: a user thought this was the total number of transactions or outputs ever seen on the chain, whereas it's only the number in the UTXO.bestblock in
gettxout: a user thought this was the block that included the output, not realizing it was the tip of the current best block chain. I also copied this text togettxoutsetinfofor congruency. I skimmed other uses of "bestblock" in the RPC docs and they seemed clear to me.