GCC-7 and glibc-2.27 back compat code #13177

ken2812221 · 2018-05-06T16:08:48Z

The __divmoddi4 code was modified from https://github.com/gcc-mirror/gcc/blob/master/libgcc/libgcc2.c . I manually find the older glibc version of log2f by objdump, use .symver to specify the certain version.

ken2812221 · 2018-05-06T23:50:57Z

Still have some probleams. Why doesn't it be allowed to export these symbols.

bitcoin-cli: export of symbol stdout not allowed
bitcoin-cli: export of symbol stderr not allowed
bitcoin-tx: export of symbol stdout not allowed
bitcoin-tx: export of symbol stdin not allowed
bitcoin-tx: export of symbol stderr not allowed
qt/bitcoin-qt: export of symbol stdout not allowed
qt/bitcoin-qt: export of symbol in6addr_any not allowed
qt/bitcoin-qt: export of symbol stderr not allowed

laanwj · 2018-05-07T09:29:27Z

Still have some probleams. Why doesn't it be allowed to export these symbols.

Because it's an executable - it's unnecessary to export any symbols, so if that happens that usually points towards a problem during linking that can cause weird issues with shared libraries later on.
(however, maybe there's a good reason for these then they could be added to the exceptions)

ken2812221 · 2018-05-07T10:31:32Z

I actually don't know this too much, but I think thery all need to be exported.

0000000002537398 g    D  .bss   0000000000000000  Base        _end
000000000251ca40 g    DO .bss   0000000000000008  GLIBC_2.2.5 stdout
000000000251ca30 g    D  .data  0000000000000000  Base        _edata
00000000024a7d00  w   DO .data.rel.ro   0000000000000010  GLIBC_2.2.5 in6addr_any
000000000251ca30 g    D  .bss   0000000000000000  Base        __bss_start
000000000251ca60 g    DO .bss   0000000000000008  GLIBC_2.2.5 stderr
000000000014a690 g    DF .init  0000000000000000  Base        _init
00000000016596b0 g    DF .fini  0000000000000000  Base        _fini

laanwj · 2018-05-07T10:42:39Z

_end _fini and such are harmless to export. I don't think they're strictly necessary for execution, but they're just part of the linking process, and delimit the various sections.
Not sure about the rest, though.
stdout/stderr/in6addr_any sound like they should be exported from the C library, not our executable.
I'll look into it as well when I get around to playing around with Ubuntu 18.04 (I guess that's where you find this combination?).

FYI @theuni.

theuni · 2018-05-08T13:36:39Z

@laanwj Thanks.

Those are interesting. in6addr_any is weak-linked for some reason. If necessary we could just define a new constant. No clue about stdout/stderr, I'll have to play with that as well.

@ken2812221 Is it not sufficient to define the replacements with their own symbol names? Why use __wrap__?

theuni · 2018-05-08T14:35:04Z

This should take care of in6addr_any:

--- a/src/net.cpp
+++ b/src/net.cpp
@@ -2254,7 +2254,7 @@ bool CConnman::InitBinds(const std::vector<CService>& binds, const std::vector<C
     if (binds.empty() && whiteBinds.empty()) {
         struct in_addr inaddr_any;
         inaddr_any.s_addr = INADDR_ANY;
-        fBound |= Bind(CService(in6addr_any, GetListenPort()), BF_NONE);
+        fBound |= Bind(CService((in6_addr)IN6ADDR_ANY_INIT, GetListenPort()), BF_NONE);
         fBound |= Bind(CService(inaddr_any, GetListenPort()), !fBound ? BF_REPORT_ERROR : BF_NONE);
     }
     return fBound;

ken2812221 · 2018-05-08T17:12:34Z

This should take care of in6addr_any:

Thanks. That does work.

Is it not sufficient to define the replacements with their own symbol names? Why use wrap?

I thought it would conflict with the library, so I didn't try that before. ~~But it works now.~~ No. it doesn't, this would cause a segfault on Travis.

ken2812221 · 2018-06-02T18:01:13Z

I couldn't find any way not to export stdin, stdout, stderr. Also, it is harmless to export them since glibc is versioned, so I just ignore them in symbol-check.py.

Sjors · 2018-07-12T10:59:06Z

This improves #13604 such that it produces ARM binaries that work on Xenial when cross-compiling on Bionic.

laanwj · 2018-07-12T14:26:38Z

utACK 253f592

253f592 Add stdin, stdout, stderr to ignored export list (Chun Kuan Lee) fc6a9f2 Use IN6ADDR_ANY_INIT instead of in6addr_any (Cory Fields) 908c1d7 GCC-7 and glibc-2.27 compat code (Chun Kuan Lee) Pull request description: The `__divmoddi4` code was modified from https://github.com/gcc-mirror/gcc/blob/master/libgcc/libgcc2.c . I manually find the older glibc version of log2f by objdump, use `.symver` to specify the certain version. Tree-SHA512: e8d875652003618c73e019ccc420e7a25d46f4eaff1c7a1a6bfc1770b3b46f074b368b2cb14df541b5ab124cca41dede4e28fe863a670589b834ef6b8713f9c4

theuni · 2018-07-12T17:50:15Z

Sorry for the late review...

I really dislike the use of wrap here. I suspect it will get in the way of things like sanitizers and lto, and it really shouldn't be necessary since the other compat stubs manage to work without it.

I'll follow up with another PR if I can come up with a working solution without wrapping.

ken2812221 · 2018-07-12T17:55:26Z

It caused a segfault on travis for qt 4. But qt 4 has gone now. I am not sure if we should get rid of wrap.

c1afe32 Change gitian-descriptors to use bionic instead (Chun Kuan Lee) Pull request description: I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol: ``` test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0 test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27 qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0 qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27 ``` I think this should be fixed in `./configure --enable-glibc-back-compat` Should not be merged before bitcoin#13177 devrandom/gitian-builder#178 Close bitcoin#12511 Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f

253f5929097548fb10ef995002dedbb8dadb6a0d Add stdin, stdout, stderr to ignored export list (Chun Kuan Lee) fc6a9f2ab18ca8466d65d14c263c4f78f9ccebbf Use IN6ADDR_ANY_INIT instead of in6addr_any (Cory Fields) 908c1d7745f0ed117b0374fcc8486f83bf743bfc GCC-7 and glibc-2.27 compat code (Chun Kuan Lee) Pull request description: The `__divmoddi4` code was modified from https://github.com/gcc-mirror/gcc/blob/master/libgcc/libgcc2.c . I manually find the older glibc version of log2f by objdump, use `.symver` to specify the certain version. Tree-SHA512: e8d875652003618c73e019ccc420e7a25d46f4eaff1c7a1a6bfc1770b3b46f074b368b2cb14df541b5ab124cca41dede4e28fe863a670589b834ef6b8713f9c4

* repair depends system this fixes the incorrectly named files in the depends build process, as well as updates the QT repo location so that depends build are sucessful * Merge #13177: GCC-7 and glibc-2.27 back compat code 253f5929097548fb10ef995002dedbb8dadb6a0d Add stdin, stdout, stderr to ignored export list (Chun Kuan Lee) fc6a9f2ab18ca8466d65d14c263c4f78f9ccebbf Use IN6ADDR_ANY_INIT instead of in6addr_any (Cory Fields) 908c1d7745f0ed117b0374fcc8486f83bf743bfc GCC-7 and glibc-2.27 compat code (Chun Kuan Lee) Pull request description: The `__divmoddi4` code was modified from https://github.com/gcc-mirror/gcc/blob/master/libgcc/libgcc2.c . I manually find the older glibc version of log2f by objdump, use `.symver` to specify the certain version. Tree-SHA512: e8d875652003618c73e019ccc420e7a25d46f4eaff1c7a1a6bfc1770b3b46f074b368b2cb14df541b5ab124cca41dede4e28fe863a670589b834ef6b8713f9c4

c1afe32 Change gitian-descriptors to use bionic instead (Chun Kuan Lee) Pull request description: I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol: ``` test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0 test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27 qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0 qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27 ``` I think this should be fixed in `./configure --enable-glibc-back-compat` Should not be merged before bitcoin#13177 devrandom/gitian-builder#178 Close bitcoin#12511 Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f

* Add stdin, stdout, stderr to ignored export list * Merge bitcoin#13171: Change gitian-descriptors to use bionic instead c1afe32 Change gitian-descriptors to use bionic instead (Chun Kuan Lee) Pull request description: I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol: ``` test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0 test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27 qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0 qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27 ``` I think this should be fixed in `./configure --enable-glibc-back-compat` Should not be merged before bitcoin#13177 devrandom/gitian-builder#178 Close bitcoin#12511 Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f * Use IN6ADDR_ANY_INIT instead of in6addr_any This is the same fix as bitcoin@fc6a9f2 Couldn't backport the original commit as we are missing some refactorings.

* CSS margin for pages, sendcoins relocated structure, code cleaning * CSS sendcoins dialog form modified and bug fixed with purging overview CSS sendcoins dialog form modified removing a label from overview which is now in private * Bug fixed a not found font was being referenced * Removing unused code * Loading arrows and Fix for earlier versions of QT * CSS sendcoins dialog and entry modified * CSS sendcoinsdialog, sendcoinsentry, receivecoins and QDialog styles backgrounds dark color and transparencies * Styles changed for overview and statubar Unit display color on status bar Overview page: layout and USD labels * Private view layout and some style * Header section for socket message ui, testing Still testing ui overview css class implemented * Info icon on Private and Overview * Combo box style * Styles of combo box and gitignore updated Combo box not invading the tables, and disable mode * Header bar for socket message and testing ui for button * CSS header profile picture, still testing * SpinBox style and Table style * CSS recent transactions and dynamic text colors depending on theme If pac theme is set the white color will be the default for text. other wise it will be a dark text * Transaction bar at top of the tables * Personalized fonts and CSS Personalized fonts added and text colors for tables and lists * Private (background, button style), Send coins page (alignment). * CSS receivecoinsdialog positions and styles modified also tableview text color is now set as white * Send Coins page layout 90% * New customized fonts VolteRounded font for PAC * Bug fixed: Mistake writing qrc fixed * Send coins choose transaction fee moved and added a scroll area * Typography implemented on the code Volte Rounded * Default typography changed and new header bar Header bar for messages and profile picture implemented CSS, images, and elements ready to be programmed Application typography Volte Rounded is now the default for the wallet * Layout alignment * UI modifications Specific details * Receive Page background * Layout for bigger screens, checkbox added * Toolbar and headerbar Size modifed, CSS CSS of QToolButtons: - background when selected has changed - height and width QToolBar width Main Pac Icon modified and centered HeaderBar spacer added and select image changed * Proposal table layouts, private button and layout * custom ScrollBar implemented * Spinbox arrows layout, controls colors. * Global Button style fixed Border now transparent * Private colors and shadow, send margin * Receive coins link buttons and layout modifed spaces and margins * Background of dialog when closing app * Private_Overview functionality fix * Adding commas to make more easy to read large numbers * Re sorting buttons of tool bar menu and fixing disabled push button * Progress, unfinished components masternodes tab navigation label of masternodes addressbookpage table columns to be tested * remove border of Disabled link buttons * Private (info button, and sizes), SendPage (balance working) * Commas instead of spaces on bitcoinunits fixed bug there was a bug in where the negative quantities where not being converted properly * AddressBookPage and EditAddressDialog styles table styles modified inputs to fit with UI design * Receive layout and tables headers color * Masternodes and other css style * Table separations and overview layout test * No longer posible to set old theme "light" with GUI * Overview icon spacing, masternode lineedit style * new typography implemented gotham and Volte rounded Volte rounded: light, medium, semibold and bold gotham: medium and bold. * merge * style fixed with Gotham Medium typography family font was wrong * clocks and eyes icons * Overview info button * Checkbox and Radio button disable icon * Backend for the balance on the receive page * fix toolbar button height * Receive coins re-formulated * Image Picker beta 1 still testing * Receive page front end balance, and responsive layout * Combobox fix, overlay style, possible fix on receive send page * Merging headers on bitcoingui * Image picker now storage the image inside Paccoincore folder depending in each plataform the program will copy and paste the image selected, overwrite it if it exist and then each time the wallet loads it will choose the image from that path. The image will be copied where the .conf is located without file extention. Only allowed .xmp and .jpg images since .png files can't be loaded (QT bug apparently) * Bug fixed: img picker when cancelling button clicked if you were about to select an image from the file picker and decided to not select anything. When clicking cancel button the button would set the image as black. Now it keeps the last image. * Fix to the Private and overview displays * Amount on receive and send rearrange * New background, fix to info doubleclicked * Bug Fixed: AccentButton lost shape with small screens Sending coins page * Icons replaced accurate style and color correction * CSS Code optimization and combobox color fixed removing innecesary code and code that was being repeated CSS: - table header height fixed - arrow for sorting customized * Socket news connected only the half * Socket news working * Replaced icon editpaste * css header table * Getting the PAC USD value * QRC header file fix * Overview message info and PAC value send to the wallet frame * PAC value send to walletview * UI Fixes for small screens (send and receive page) * Unused code * PAC value using QSettings * QRCode implementation and restyle * Code mistake fixed forgot to delete it * QRCode on receivecoins size fixed * Show the USD value of your PACs * Overview message updated * USD PAC conversion validated * UI receive page minor fix for small screens * Wallet without sockets * QRC fix * make include FIX * Bitcoin amount field FIX Not working with commas. * update-deps * add patches * PACtoUSD removal * BugFixed with BitcoinAmountField comma the spinner was not detecting the amount with the comma. It was removed from this control * Amperson removed from ui * RCC was not finding the icons and assets It should work now * completion * Add dmg background * macdeploy missing files * Change tar.gz name * update-deps * add patches * completion * Add dmg background * macdeploy missing files * Change tar.gz name * Migrate macdeploy to python3 * Change tar.gz name on gitian descriptors. * Auto stash before merge of "socket_semoval" and "origin/socket_semoval" * Change windows setup filename * asset correction removed unused image. Replaced format jpg to png on background * UI BugFixed Style now is default. Removed unused code. Button icons removed from linux and windows. * jpg to png background fix * profile img removed from make.qt.include * Auto stash before merge of "socket_semoval" and "origin/socket_semoval" * asset correction removed unused image. Replaced format jpg to png on background * UI BugFixed Style now is default. Removed unused code. Button icons removed from linux and windows. * jpg to png background fix * profile img removed from make.qt.include * News message deleted * Icons on Windows deleted * Scrollbar horizontal ui fixed * BugFixed a comma unwanted * restoring cross platform functionality of icons on buttons was already disabled * Overview info updated and dialog URI background changed * MyMasternodes table style fix * GCC-7 and glibc-2.27 compat code * Add stdin, stdout, stderr to ignored export list * Backport move to Ubuntu Bionic and GCC7 in Gitian builds (dashpay#2225) * Add stdin, stdout, stderr to ignored export list * Merge bitcoin#13171: Change gitian-descriptors to use bionic instead c1afe32 Change gitian-descriptors to use bionic instead (Chun Kuan Lee) Pull request description: I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol: ``` test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0 test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27 qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0 qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27 ``` I think this should be fixed in `./configure --enable-glibc-back-compat` Should not be merged before bitcoin#13177 devrandom/gitian-builder#178 Close bitcoin#12511 Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f * Use IN6ADDR_ANY_INIT instead of in6addr_any This is the same fix as bitcoin@fc6a9f2 Couldn't backport the original commit as we are missing some refactorings. * BugFixed: Table borders on windows and linux now transparent border:none; * Private page tool tip fix * BugFixed UI send and receive coins When coins control dialog open. right colum was getting small. Sendcoins page: coins control re located. Table of history requested coins was too small in height. QRCode address otput implementation (pending to finish) * Sign/Verify message, base for news with an API * CSS Qtooltip custom style * CSS QProgressBar and QuickButton class rounded corners. * Receive coins Address hidden for default, visible after requesting payment. Copy to clipboard button. * BugFixed: Toolbar can't be hide now It was able to be hide without being able to show it again * proposal table> Fixing width of the tables width of first column of tables was too small. * BugFixed: href color changed to easy read * Animated QRCode and Address UX in order to make the user able to notice when is changing. Tableview row will be focused too * Syncing with master branch (#1) * Delayed block penalization and new reward percentages (#66) * Delayed block penalization (#62) - Delayed block penalization - Reset regtest - Change protocol version - Update blockdelay RPC test. - Fix min chain work on regtest chain params. - Add chain penalization field to getchaintips method. - Fix log formating * New reward percentages 70215 (#63) Changing the reward percentages, miners now get 15% and masternodes get 65%. * Change activation block height for new rewards * Bump min protocol and new checkpoint (#65) - Min protocol version is now 70215 - Bumped the version on the masternode update scripts. - Added a checkpoint, block `#216000`. * Update README.md, adding the PacNodesUpdater instructions (#67) * Update README.md * Added PacNodesUpdater script * Update README.md * Update README.md * Update README.md * Update README.md * Update PAC_update.sh (#68) Changed the update complete text to get people to start from cold wallet. * Update pac-update.sh (#69) * CSS UI BugFixed Buttons width larger to fit content text, LineEdit for pac address larger for easy to read (on requesting coins). * UI send and receive coins spacer for the hidden fees features so it fits the scrollarea. Buttons size and margins LineEdit class changed * Fixes and News/pac-usd -Update news -Update pac-usd value (only overview) -info on overview updated of where we get the pac-usd value -Copy news button -Unused code deleted * UI fixed * Update send and receive labels for USD * Options dialog label warning fixed size * html <a> href style from blue to yellow * News pointing to the right API * Tooltips for copy and refresh news * Background and selection bar colors * General backgrounds and text inputs colors changed To have a better contrast on the elements and text. * CSS send coins, progressbar, check and radiobutton merging branches v1.2 to 1.3 radiobutton, checkbutton with spaces layouts modified * Top bar color darker * Qslider customized and sendcoinsdialog * Fix typo * "Pay to" recipient separator * new mined icon * Tables have more colors to make it prettier * Qslider css, recent transactions font size, pac to usd width * Optimizing CSS, layouts fixed removing btnCopyNews and btnRefreshNews styles, using QuickButton instead. Replaced QPushButton to QToolButton * Unnecessary code * Masternode table white text * Master nodes Table not enabled text to red * Pixel Size font trying to fix windows dpi font issues * CSS and layout fixing QRCode and other forms layout now fixed sizes in order to fit properly * Button to copy the conversion of USD-PAC * AddressBookPage table fix text color * Private page advance mode ui fixes Red color to bright, buttons not align and progress bar not center. * Masternodes Page tabs color and size change * Coin control dialog UI fixes Style of the table, white borders, and cut labels. * Translations fix German and Spanish * SendCoins CoinControl scrollbar and better displaying * Possible fix for windows On preferences the tabs go out on the left * User can now select typography cuz it was hurting users eyes * Custom Font Typo Now the user can select any typography installed on the system. In addition to the default ones for the UI * News feed can show a longer text * Radio button color change * Some documentation for the code * Code reorganization and comments * Merge, QFont, QRCode QRcode will resize on small and big screens * QRCode BugFixed it was stretching a lot. Now it will respect the layout * QRCode resized fixed When the button was clicked it was not setting the window. height * Light theme start of typo and backgrounds. * CSS and UI Bug fixed - Background Image now resize keeping aspect ratio. - Profile Image button now is capable of restoring original pac logo/changing the current image. - purging code (removing std::cout debbugers) - BugFixed: sendcoinsentry address typography was different, now it takes the selected font for the wallet. - BugFixed: receive coins page, the form was being cropped on small screens, changed the layouts and min height. - * Test * Private Page message corrupting the view on small devices. * Modal Overlay UI modification * margin on private page label * profile img button bug fixed it was starting blank (attempting) * Tab bar and color palette changed * Trying to fix Font problems default pac font to be selected automatically * Font size now medium in order to make it more readable * Fix of my failed merge * trying to fix font default * Custom Font Bug Fixed Now the font will be medium. Code optimized. * Using alias and CSS Black and grey * Bug Fixed> The checkboxes on receive coins page were squeezing * Fixing contrast of ui elements including the toolbar selected button and the inputs * SendCoins page "Fee" fix decimals * Micro sign on Overview fix * Micro sign on Private Page fix * bitcoinamount field changed in order to be fixed on height * separator implemented On send coins page -> the text inputs were too close. A separator should fix this issue presented only on windows. * ui fixed * Typography fixing * Fig compilation error due to qt version this property can not be compiled * New icon colors, images added on css now and table colors change * UI enhancement * CSS Light theme changes * Revert "Merge branch 'new-ui_v1.5white' into new-ui_v1.4" This reverts commit 2e2c5de.

* Add stdin, stdout, stderr to ignored export list * Merge bitcoin#13171: Change gitian-descriptors to use bionic instead c1afe32 Change gitian-descriptors to use bionic instead (Chun Kuan Lee) Pull request description: I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol: ``` test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0 test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27 qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0 qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27 ``` I think this should be fixed in `./configure --enable-glibc-back-compat` Should not be merged before bitcoin#13177 devrandom/gitian-builder#178 Close bitcoin#12511 Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f * Use IN6ADDR_ANY_INIT instead of in6addr_any This is the same fix as bitcoin/bitcoin@fc6a9f2 Couldn't backport the original commit as we are missing some refactorings.

Implemented a version of these pull requests from upstream: bitcoin/bitcoin#13177 bitcoin/bitcoin#13171

ken2812221 changed the title ~~GCC-7 and glibc-2.27 compat code~~ WIP[]GCC-7 and glibc-2.27 compat code May 6, 2018

ken2812221 changed the title ~~WIP[]GCC-7 and glibc-2.27 compat code~~ [WIP]GCC-7 and glibc-2.27 compat code May 6, 2018

ken2812221 changed the title ~~[WIP]GCC-7 and glibc-2.27 compat code~~ [WIP]GCC-7 and glibc-2.27 back compat code May 7, 2018

meshcollider added the Build system label May 7, 2018

ken2812221 mentioned this pull request May 7, 2018

Change gitian-descriptors to use bionic instead #13171

Merged

maflcko added this to the 0.17.0 milestone May 31, 2018

ken2812221 changed the title ~~[WIP]GCC-7 and glibc-2.27 back compat code~~ GCC-7 and glibc-2.27 back compat code Jun 2, 2018

ken2812221 and others added 3 commits June 2, 2018 19:18

GCC-7 and glibc-2.27 compat code

908c1d7

Use IN6ADDR_ANY_INIT instead of in6addr_any

fc6a9f2

Add stdin, stdout, stderr to ignored export list

253f592

TheCharlatan mentioned this pull request Jul 7, 2018

Add depends 32-bit arm support for bitcoin-qt #13604

Merged

DrahtBot mentioned this pull request Jul 9, 2018

Audit string.h inclusion #13584

Closed

maflcko assigned theuni Jul 11, 2018

laanwj merged commit 253f592 into bitcoin:master Jul 12, 2018

ken2812221 deleted the compat branch July 12, 2018 15:50

Bushstar mentioned this pull request Jul 13, 2018

commits from bitcoin/master FeatherCoin/Feathercoin#354

Merged

Fuzzbawls mentioned this pull request Aug 27, 2018

[Build] GCC-7 and glibc-2.27 back compat PIVX-Project/PIVX#704

Merged

sickpig mentioned this pull request Jan 28, 2019

Propaedeutic changes needed to move the gitian build to Ubuntu 18.04 BitcoinUnlimited/BitcoinUnlimited#1574

Merged

CryptAxe added a commit to DriveNetTESTDRIVE/DriveNet that referenced this pull request Jun 10, 2019

Update gitian build, glibc back compat, cleanup

240b580

Implemented a version of these pull requests from upstream: bitcoin/bitcoin#13177 bitcoin/bitcoin#13171

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GCC-7 and glibc-2.27 back compat code #13177

GCC-7 and glibc-2.27 back compat code #13177

Uh oh!

ken2812221 commented May 6, 2018 •

edited

Loading

Uh oh!

ken2812221 commented May 6, 2018 •

edited

Loading

Uh oh!

laanwj commented May 7, 2018

Uh oh!

ken2812221 commented May 7, 2018

Uh oh!

laanwj commented May 7, 2018

Uh oh!

theuni commented May 8, 2018

Uh oh!

theuni commented May 8, 2018

Uh oh!

ken2812221 commented May 8, 2018 •

edited

Loading

Uh oh!

ken2812221 commented Jun 2, 2018

Uh oh!

Sjors commented Jul 12, 2018

Uh oh!

laanwj commented Jul 12, 2018

Uh oh!

theuni commented Jul 12, 2018

Uh oh!

ken2812221 commented Jul 12, 2018 •

edited

Loading

Uh oh!

Uh oh!

GCC-7 and glibc-2.27 back compat code #13177

GCC-7 and glibc-2.27 back compat code #13177

Uh oh!

Conversation

ken2812221 commented May 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ken2812221 commented May 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented May 7, 2018

Uh oh!

ken2812221 commented May 7, 2018

Uh oh!

laanwj commented May 7, 2018

Uh oh!

theuni commented May 8, 2018

Uh oh!

theuni commented May 8, 2018

Uh oh!

ken2812221 commented May 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ken2812221 commented Jun 2, 2018

Uh oh!

Sjors commented Jul 12, 2018

Uh oh!

laanwj commented Jul 12, 2018

Uh oh!

theuni commented Jul 12, 2018

Uh oh!

ken2812221 commented Jul 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ken2812221 commented May 6, 2018 •

edited

Loading

ken2812221 commented May 6, 2018 •

edited

Loading

ken2812221 commented May 8, 2018 •

edited

Loading

ken2812221 commented Jul 12, 2018 •

edited

Loading