Skip to content

[tests] Fix race in rpc_deprecated.py #13130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2018
Merged

[tests] Fix race in rpc_deprecated.py #13130

merged 1 commit into from
Apr 30, 2018

Conversation

jnewbery
Copy link
Contributor

Fixes a block generation race introduced in 3576ab1.

@jnewbery
[tests] Fix race in rpc_deprecated.py
a95bf64 
Fixes a block generation race.
@maflcko
Copy link
Member

maflcko commented Apr 30, 2018

utACK a95bf64

@maflcko maflcko added the Tests label Apr 30, 2018
jamesob
jamesob approved these changes Apr 30, 2018
View reviewed changes
Copy link
Contributor

@jamesob jamesob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a95bf64

Though note that some of the recent rpc_deprecated failures are due to the bug(s) outlined in #13092.

@maflcko maflcko merged commit a95bf64 into bitcoin:master Apr 30, 2018
maflcko pushed a commit that referenced this pull request Apr 30, 2018
Merge #13130: [tests] Fix race in rpc_deprecated.py
3186ad4 
a95bf64 [tests] Fix race in rpc_deprecated.py (John Newbery)

Pull request description:

  Fixes a block generation race introduced in 3576ab1.

Tree-SHA512: 044d7cff5087d0e5e950fa80d20dec6427416697820e8748bc30f4d4e6f7ff0753a44eed398432f8c33ed79948a42fb65f9f5926aa6fbd14224e8bf6b12a54ed
@jnewbery jnewbery deleted the fix_rpc_deprecated branch April 30, 2018 17:30
@Bushstar Bushstar mentioned this pull request May 1, 2018
Merged
@markblundeberg markblundeberg mentioned this pull request Dec 11, 2019
Merged
xdustinface pushed a commit to xdustinface/dash that referenced this pull request Dec 22, 2020
@xdustinface
Merge bitcoin#13130: [tests] Fix race in rpc_deprecated.py
b1ee5d7 
a95bf64 [tests] Fix race in rpc_deprecated.py (John Newbery)

Pull request description:

  Fixes a block generation race introduced in 3576ab1.

Tree-SHA512: 044d7cff5087d0e5e950fa80d20dec6427416697820e8748bc30f4d4e6f7ff0753a44eed398432f8c33ed79948a42fb65f9f5926aa6fbd14224e8bf6b12a54ed
xdustinface pushed a commit to xdustinface/dash that referenced this pull request Dec 22, 2020
@xdustinface
Merge bitcoin#13130: [tests] Fix race in rpc_deprecated.py
856c18c 
a95bf64 [tests] Fix race in rpc_deprecated.py (John Newbery)

Pull request description:

  Fixes a block generation race introduced in 3576ab1.

Tree-SHA512: 044d7cff5087d0e5e950fa80d20dec6427416697820e8748bc30f4d4e6f7ff0753a44eed398432f8c33ed79948a42fb65f9f5926aa6fbd14224e8bf6b12a54ed
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jamesob jamesob jamesob approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnewbery @maflcko @jamesob