Skip to content

[tests] Remove accounts from wallet_importprunedfunds.py #13138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2018
Merged

[tests] Remove accounts from wallet_importprunedfunds.py #13138

merged 1 commit into from
Jul 14, 2018

Conversation

jnewbery
Copy link
Contributor

@jnewbery jnewbery commented May 1, 2018 •
edited
Loading

This was split from #13075 to not block review/merge of that PR.

@jnewbery jnewbery changed the title [tests] Remove accounts from wallet_importprunedfunds.py [Do not merge] [tests] Remove accounts from wallet_importprunedfunds.py May 1, 2018
@fanquake fanquake added the Tests label May 1, 2018
@jnewbery jnewbery mentioned this pull request Jun 11, 2018
Closed
6 tasks
@maflcko
Copy link
Member

maflcko commented Jun 18, 2018

@jnewbery Mind doing a rebase on master, since the last travis run (https://travis-ci.org/bitcoin/bitcoin/builds/373612454) was about two months ago.

@jnewbery jnewbery force-pushed the remove_account_wallet_importprunedfunds branch from 5268a10 to 38040c3 Compare June 18, 2018 17:14
@jnewbery
Copy link
Contributor Author

Rebased on master. I can no longer repro the OOM locally (tried running the test 100 times), and Travis passes. @MarcoFalke - can you try running this locally?

I'm removing the [Do not merge] tag, since if this runs reliably it's ready for merge.

@jnewbery jnewbery changed the title [Do not merge] [tests] Remove accounts from wallet_importprunedfunds.py [tests] Remove accounts from wallet_importprunedfunds.py Jun 18, 2018
@maflcko
Copy link
Member

maflcko commented Jun 18, 2018

@jnewbery Good to hear your tested ack on 0882406 ;)

@maflcko
Copy link
Member

maflcko commented Jun 18, 2018

Concept ACK 38040c3

Going to take a closer look later

@maflcko
Copy link
Member

maflcko commented Jul 14, 2018

utACK 38040c3

@maflcko maflcko merged commit 38040c3 into bitcoin:master Jul 14, 2018
maflcko pushed a commit that referenced this pull request Jul 14, 2018
Merge #13138: [tests] Remove accounts from wallet_importprunedfunds.py
8803c91 
38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from #13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
@Bushstar Bushstar mentioned this pull request Jul 16, 2018
Merged
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Dec 6, 2019
Merge #13138: [tests] Remove accounts from wallet_importprunedfunds.py
57b370d 
Summary:
38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from #13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab

Backport of Core PR13138
bitcoin/bitcoin#13138

Depends on D4540

Test Plan:
  test_runner.py wallet_importprunedfunds

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4541
@Fuzzbawls Fuzzbawls mentioned this pull request Jun 25, 2020
Closed
11 tasks
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 19, 2020
@PastaPastaPasta
Merge bitcoin#13138: [tests] Remove accounts from wallet_importpruned…
ffe575a 
…funds.py

38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from bitcoin#13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 24, 2020
@PastaPastaPasta
Merge bitcoin#13138: [tests] Remove accounts from wallet_importpruned…
5a1ca94 
…funds.py

38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from bitcoin#13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 27, 2020
@PastaPastaPasta
Merge bitcoin#13138: [tests] Remove accounts from wallet_importpruned…
f8fb77a 
…funds.py

38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from bitcoin#13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jul 27, 2020
@UdjinM6
Merge bitcoin#13138: [tests] Remove accounts from wallet_importpruned…
24cc9b8 
…funds.py

38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from bitcoin#13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jul 27, 2020
@UdjinM6
Merge bitcoin#13138: [tests] Remove accounts from wallet_importpruned…
72a56e3 
…funds.py

38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from bitcoin#13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@PastaPastaPasta
Merge bitcoin#13138: [tests] Remove accounts from wallet_importpruned…
3dad55f 
…funds.py

38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from bitcoin#13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@PastaPastaPasta
Merge bitcoin#13138: [tests] Remove accounts from wallet_importpruned…
9ce89a7 
…funds.py

38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from bitcoin#13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@PastaPastaPasta
Merge bitcoin#13138: [tests] Remove accounts from wallet_importpruned…
afd1189 
…funds.py

38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from bitcoin#13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@PastaPastaPasta
Merge bitcoin#13138: [tests] Remove accounts from wallet_importpruned…
d9eb524 
…funds.py

38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from bitcoin#13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@PastaPastaPasta
Merge bitcoin#13138: [tests] Remove accounts from wallet_importpruned…
526b4ed 
…funds.py

38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from bitcoin#13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@PastaPastaPasta
Merge bitcoin#13138: [tests] Remove accounts from wallet_importpruned…
15a65ab 
…funds.py

38040c3 [tests] Remove accounts from wallet_importprunedfunds.py (John Newbery)

Pull request description:

  This was split from bitcoin#13075 to not block review/merge of that PR.

Tree-SHA512: 631d7139ed2bda5222ec395cc75720261e2e1f741dba04723d09fe04ef6cf92222a3679d886026ec33e2db2d1e2fa1a0f36c2451581d0f733a9939a98c7118ab
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnewbery @maflcko @fanquake