logging: bypass timestamp formatting when not logging #12970

theuni · 2018-04-12T21:26:51Z

As suggested by @laanwj on IRC:

<cfields> whoa
<cfields> Leaving test case "knapsack_solver_test"; testing time: 358694ms
<cfields> i386 + old wine ^^
<cfields> Leaving test case "knapsack_solver_test"; testing time: 6781ms
<cfields> ^^ same, but with the LogPrint commented out
...
<wumpus> if both log-to-file and log-to-console is disabled, it should probably bypass all logging

Edit: The painful line commented out being the LogPrintf in CWallet::AddToWallet.

laanwj · 2018-04-12T21:35:44Z

utACK 8ca1f6ecba5efc278927fd34eb04f6a4254dfe03

theuni · 2018-04-12T21:41:00Z

Wine i686 build down to 11 min :)

maflcko · 2018-04-12T21:41:13Z

utACK 8ca1f6e (Run time seems to be about the same or slightly faster than with the wine-hq)

theuni · 2018-04-12T22:14:42Z

While this is an easy win for tests, we should still track down why LogTimestampStr() is so painful.

laanwj · 2018-04-12T22:23:05Z

While this is an easy win for tests, we should still track down why LogTimestampStr() is so painful.

It looks inefficient too:

std::string DateTimeStrFormat(const char* pszFormat, int64_t nTime)
{
    static std::locale classic(std::locale::classic());
    // std::locale takes ownership of the pointer
    std::locale loc(classic, new boost::posix_time::time_facet(pszFormat));
    std::stringstream ss;
    ss.imbue(loc);
    ss << boost::posix_time::from_time_t(nTime);
    return ss.str();
}

laanwj · 2018-04-12T22:25:30Z

src/util.cpp

@@ -339,6 +339,10 @@ int LogPrintStr(const std::string &str)
    int ret = 0; // Returns total number of characters written
    static std::atomic_bool fStartedNewLine(true);

+    if (!fPrintToConsole && !fPrintToDebugLog) {


nit: might be even more efficient to do this check in util.h already, before calling tfm::format.

Good point, done.

This leads to massive speedups under Wine.

jimpo · 2018-04-13T01:18:57Z

utACK 339730a

sipa · 2018-04-13T01:27:21Z

utACK 339730a

fanquake · 2018-04-13T01:30:54Z

utACK 339730a

@laanwj

339730a logging: bypass timestamp formatting when not logging (Cory Fields) Pull request description: As suggested by @laanwj on IRC: ``` <cfields> whoa <cfields> Leaving test case "knapsack_solver_test"; testing time: 358694ms <cfields> i386 + old wine ^^ <cfields> Leaving test case "knapsack_solver_test"; testing time: 6781ms <cfields> ^^ same, but with the LogPrint commented out ... <wumpus> if both log-to-file and log-to-console is disabled, it should probably bypass all logging ``` Edit: The painful line commented out being the LogPrintf in CWallet::AddToWallet. Tree-SHA512: bc6da67dcdf05e9164fff7a7e9980de897e6f1b0d3f6e1ebde2162cbcba7d54a6ec94283534eb5a1ebde7134533d7fe7e496aa35ea3128c567ed6483eae5212c

practicalswift · 2018-04-13T05:18:30Z

utACK 339730a

Impressive! Very nice find!

@laanwj

1527015 Avoid std::locale/imbue in DateTimeStrFormat (Pieter Wuille) Pull request description: And replace them with just hardcoded ISO8601 strings and `gmtime_r`. Pointed out by @laanwj here: #12970 (comment) Tree-SHA512: a459758b42ca56f8462115aefe8e6377c1319fce509ea64dbb767f3f087c9b848335954cb684e5896c38008847684045505a3e1559fb3e83b8e80e10b003d1e7

This leads to massive speedups under Wine. Github-Pull: bitcoin#12970 Rebased-From: 339730a

@laanwj

…gging 339730a logging: bypass timestamp formatting when not logging (Cory Fields) Pull request description: As suggested by @laanwj on IRC: ``` <cfields> whoa <cfields> Leaving test case "knapsack_solver_test"; testing time: 358694ms <cfields> i386 + old wine ^^ <cfields> Leaving test case "knapsack_solver_test"; testing time: 6781ms <cfields> ^^ same, but with the LogPrint commented out ... <wumpus> if both log-to-file and log-to-console is disabled, it should probably bypass all logging ``` Edit: The painful line commented out being the LogPrintf in CWallet::AddToWallet. Tree-SHA512: bc6da67dcdf05e9164fff7a7e9980de897e6f1b0d3f6e1ebde2162cbcba7d54a6ec94283534eb5a1ebde7134533d7fe7e496aa35ea3128c567ed6483eae5212c

@laanwj

…gging 339730a logging: bypass timestamp formatting when not logging (Cory Fields) Pull request description: As suggested by @laanwj on IRC: ``` <cfields> whoa <cfields> Leaving test case "knapsack_solver_test"; testing time: 358694ms <cfields> i386 + old wine ^^ <cfields> Leaving test case "knapsack_solver_test"; testing time: 6781ms <cfields> ^^ same, but with the LogPrint commented out ... <wumpus> if both log-to-file and log-to-console is disabled, it should probably bypass all logging ``` Edit: The painful line commented out being the LogPrintf in CWallet::AddToWallet. Tree-SHA512: bc6da67dcdf05e9164fff7a7e9980de897e6f1b0d3f6e1ebde2162cbcba7d54a6ec94283534eb5a1ebde7134533d7fe7e496aa35ea3128c567ed6483eae5212c

@laanwj

…gging 339730a logging: bypass timestamp formatting when not logging (Cory Fields) Pull request description: As suggested by @laanwj on IRC: ``` <cfields> whoa <cfields> Leaving test case "knapsack_solver_test"; testing time: 358694ms <cfields> i386 + old wine ^^ <cfields> Leaving test case "knapsack_solver_test"; testing time: 6781ms <cfields> ^^ same, but with the LogPrint commented out ... <wumpus> if both log-to-file and log-to-console is disabled, it should probably bypass all logging ``` Edit: The painful line commented out being the LogPrintf in CWallet::AddToWallet. Tree-SHA512: bc6da67dcdf05e9164fff7a7e9980de897e6f1b0d3f6e1ebde2162cbcba7d54a6ec94283534eb5a1ebde7134533d7fe7e496aa35ea3128c567ed6483eae5212c

@laanwj

…rmat 1527015 Avoid std::locale/imbue in DateTimeStrFormat (Pieter Wuille) Pull request description: And replace them with just hardcoded ISO8601 strings and `gmtime_r`. Pointed out by @laanwj here: bitcoin#12970 (comment) Tree-SHA512: a459758b42ca56f8462115aefe8e6377c1319fce509ea64dbb767f3f087c9b848335954cb684e5896c38008847684045505a3e1559fb3e83b8e80e10b003d1e7

@laanwj

…rmat 1527015 Avoid std::locale/imbue in DateTimeStrFormat (Pieter Wuille) Pull request description: And replace them with just hardcoded ISO8601 strings and `gmtime_r`. Pointed out by @laanwj here: bitcoin#12970 (comment) Tree-SHA512: a459758b42ca56f8462115aefe8e6377c1319fce509ea64dbb767f3f087c9b848335954cb684e5896c38008847684045505a3e1559fb3e83b8e80e10b003d1e7

@laanwj

…rmat 1527015 Avoid std::locale/imbue in DateTimeStrFormat (Pieter Wuille) Pull request description: And replace them with just hardcoded ISO8601 strings and `gmtime_r`. Pointed out by @laanwj here: bitcoin#12970 (comment) Tree-SHA512: a459758b42ca56f8462115aefe8e6377c1319fce509ea64dbb767f3f087c9b848335954cb684e5896c38008847684045505a3e1559fb3e83b8e80e10b003d1e7

@laanwj

…rmat 1527015 Avoid std::locale/imbue in DateTimeStrFormat (Pieter Wuille) Pull request description: And replace them with just hardcoded ISO8601 strings and `gmtime_r`. Pointed out by @laanwj here: bitcoin#12970 (comment) Tree-SHA512: a459758b42ca56f8462115aefe8e6377c1319fce509ea64dbb767f3f087c9b848335954cb684e5896c38008847684045505a3e1559fb3e83b8e80e10b003d1e7

@laanwj

…gging 339730a logging: bypass timestamp formatting when not logging (Cory Fields) Pull request description: As suggested by @laanwj on IRC: ``` <cfields> whoa <cfields> Leaving test case "knapsack_solver_test"; testing time: 358694ms <cfields> i386 + old wine ^^ <cfields> Leaving test case "knapsack_solver_test"; testing time: 6781ms <cfields> ^^ same, but with the LogPrint commented out ... <wumpus> if both log-to-file and log-to-console is disabled, it should probably bypass all logging ``` Edit: The painful line commented out being the LogPrintf in CWallet::AddToWallet. Tree-SHA512: bc6da67dcdf05e9164fff7a7e9980de897e6f1b0d3f6e1ebde2162cbcba7d54a6ec94283534eb5a1ebde7134533d7fe7e496aa35ea3128c567ed6483eae5212c

theuni mentioned this pull request Apr 12, 2018

Use winehq debs for win32 tests #12931

Closed

maflcko added the Refactoring label Apr 12, 2018

laanwj reviewed Apr 12, 2018

View reviewed changes

theuni force-pushed the slow-tests branch from 8ca1f6e to 416f134 Compare April 12, 2018 22:33

logging: bypass timestamp formatting when not logging

339730a

This leads to massive speedups under Wine.

theuni force-pushed the slow-tests branch from 416f134 to 339730a Compare April 12, 2018 22:33

sipa merged commit 339730a into bitcoin:master Apr 13, 2018

sipa mentioned this pull request Apr 13, 2018

Avoid std::locale/imbue madness in DateTimeStrFormat #12973

Merged

theuni mentioned this pull request May 3, 2018

Use thread names in logs and deadlock diagnostics #13099

Closed

maflcko mentioned this pull request May 21, 2018

Travis: Build tests on Ubuntu 18.04 with docker #13215

Merged

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request May 29, 2018

logging: bypass timestamp formatting when not logging

b3cf3ad

This leads to massive speedups under Wine. Github-Pull: bitcoin#12970 Rebased-From: 339730a

HashUnlimited mentioned this pull request Sep 5, 2018

Avoid std::locale/imbue in DateTimeStrFormat chaincoin/chaincoin#220

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

logging: bypass timestamp formatting when not logging #12970

logging: bypass timestamp formatting when not logging #12970

Uh oh!

theuni commented Apr 12, 2018 •

edited

Loading

Uh oh!

laanwj commented Apr 12, 2018

Uh oh!

theuni commented Apr 12, 2018

Uh oh!

maflcko commented Apr 12, 2018

Uh oh!

theuni commented Apr 12, 2018

Uh oh!

laanwj commented Apr 12, 2018 •

edited

Loading

Uh oh!

laanwj Apr 12, 2018

Uh oh!

theuni Apr 12, 2018

Uh oh!

jimpo commented Apr 13, 2018

Uh oh!

sipa commented Apr 13, 2018

Uh oh!

fanquake commented Apr 13, 2018

Uh oh!

practicalswift commented Apr 13, 2018

Uh oh!

Uh oh!

logging: bypass timestamp formatting when not logging #12970

logging: bypass timestamp formatting when not logging #12970

Uh oh!

Conversation

theuni commented Apr 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Apr 12, 2018

Uh oh!

theuni commented Apr 12, 2018

Uh oh!

maflcko commented Apr 12, 2018

Uh oh!

theuni commented Apr 12, 2018

Uh oh!

laanwj commented Apr 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj Apr 12, 2018

Choose a reason for hiding this comment

Uh oh!

theuni Apr 12, 2018

Choose a reason for hiding this comment

Uh oh!

jimpo commented Apr 13, 2018

Uh oh!

sipa commented Apr 13, 2018

Uh oh!

fanquake commented Apr 13, 2018

Uh oh!

practicalswift commented Apr 13, 2018

Uh oh!

Uh oh!

theuni commented Apr 12, 2018 •

edited

Loading

laanwj commented Apr 12, 2018 •

edited

Loading