Trivial: Add logging line in init.cpp that was accidentally removed with #10762 #12845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moneyball
commented
Mar 30, 2018
src/init.cpp
Outdated
| @@ -88,7 +88,8 @@ class DummyWalletInit : public WalletInitInterface { | |||
| void Close() override {} | |||
| }; | |||
|
|
|||
| std::unique_ptr<WalletInitInterface> g_wallet_init_interface(new DummyWalletInit); | |||
| static DummyWalletInit g_dymmy_wallet_init; | |||
There was a problem hiding this comment.
Is this a typo? Should it be g_dummy_wallet_init?
|
Needs rebase. |
|
This is based on #12836. Will review when that PR is merged/rejected and this PR can be rebased. |
442db68 to
0af6a95
Compare
|
#12845 has been merged. Please rebase! |
|
tACK 0af6a95 |
0af6a95 to
23abfb7
Compare
|
Tested ACK 23abfb7 |
|
I have rebased to master. I also re-tested as follows:
For both of the above configurations, I made sure 'make check' tests passed. |
|
utACK 23abfb7 |
maflcko
pushed a commit
that referenced
this pull request
Apr 9, 2018
…ally removed with #10762 23abfb7 added logging line back that was accidentally removed with #10762 (Steve Lee) Pull request description: I made the change based off of the DummyWalletInit refactor commit. I can rebase once that is merged. I built with wallet disabled and debug enabled. I then confirmed in the debug output that the logging line I added back indeed printed. Tree-SHA512: 94133aa3add9c73fa33fcc51b89fe0bc58344ab8a0ca63898961932a57b1f14b79e8113d3aeae116e0b91809f5660c636a565ea4681368c7ba85890a30e70589
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 16, 2020
…ccidentally removed with bitcoin#10762 23abfb7 added logging line back that was accidentally removed with bitcoin#10762 (Steve Lee) Pull request description: I made the change based off of the DummyWalletInit refactor commit. I can rebase once that is merged. I built with wallet disabled and debug enabled. I then confirmed in the debug output that the logging line I added back indeed printed. Tree-SHA512: 94133aa3add9c73fa33fcc51b89fe0bc58344ab8a0ca63898961932a57b1f14b79e8113d3aeae116e0b91809f5660c636a565ea4681368c7ba85890a30e70589
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 18, 2020
…ccidentally removed with bitcoin#10762 23abfb7 added logging line back that was accidentally removed with bitcoin#10762 (Steve Lee) Pull request description: I made the change based off of the DummyWalletInit refactor commit. I can rebase once that is merged. I built with wallet disabled and debug enabled. I then confirmed in the debug output that the logging line I added back indeed printed. Tree-SHA512: 94133aa3add9c73fa33fcc51b89fe0bc58344ab8a0ca63898961932a57b1f14b79e8113d3aeae116e0b91809f5660c636a565ea4681368c7ba85890a30e70589
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the change based off of the DummyWalletInit refactor commit. I can rebase once that is merged.
I built with wallet disabled and debug enabled. I then confirmed in the debug output that the logging line I added back indeed printed.