test: Use wait_until to ensure ping goes out #12545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we instead get rid of the time.sleep with an arbitrary argument? That is just terrible practice. If it is necessary to wait on some predicate, you might use the wait_until helper function. |
|
Sounds good to me, hadn't seen |
Intermittent failure evident here: https://travis-ci.org/bitcoin/bitcoin/jobs/344021180
|
Switched to using |
|
Tested 0eb84f3 ACK. I also saw this issue last week, thanks for fix. |
achow101
pushed a commit
to achow101/bitcoin
that referenced
this pull request
Mar 13, 2018
0eb84f3 test: Use wait_until to ensure ping goes out (Ben Woosley) Pull request description: Intermittent failure evident here: https://travis-ci.org/bitcoin/bitcoin/jobs/344021180 Tree-SHA512: 8d3cbc55563160390d3918eb0b22348990cd81ad35c0563033f19142cb43b86a150fecc7df2196209ba00aaa805c67285451e582f387f8dac22d5e44d54e8a0d
|
utACK 0eb84f3 |
laanwj
added a commit
that referenced
this pull request
Mar 19, 2018
9d7f839 test: Use os.path.join consistently in feature_pruning tests (Ben Woosley) 81b0822 test: Use wait_until in tests where time was used for polling (Ben Woosley) Pull request description: This is prompted by and builds on #12545, a nice cleanup / consolidation of patterns. In cases where the exception message was meaningful, I tried to represent it as well in a comment. I expect #12545 will go in first, but I'm happy to squash them if that's preferred. Tree-SHA512: 7a861244001c87fd6b59b6bc248ee741ac8178f7255d6f1fda39bc693c5ff3b7de5f53d13afe9829aef6ea69153481edb0a9d5bc07c36c4f66b4315edd180bb4
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 20, 2018
Intermittent failure evident here: https://travis-ci.org/bitcoin/bitcoin/jobs/344021180 Github-Pull: bitcoin#12545 Rebased-From: 0eb84f3
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
May 13, 2018
Intermittent failure evident here: https://travis-ci.org/bitcoin/bitcoin/jobs/344021180 Github-Pull: bitcoin#12545 Rebased-From: 0eb84f3
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Oct 22, 2019
0eb84f3 test: Use wait_until to ensure ping goes out (Ben Woosley) Pull request description: Intermittent failure evident here: https://travis-ci.org/bitcoin/bitcoin/jobs/344021180 Tree-SHA512: 8d3cbc55563160390d3918eb0b22348990cd81ad35c0563033f19142cb43b86a150fecc7df2196209ba00aaa805c67285451e582f387f8dac22d5e44d54e8a0d
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jan 22, 2020
0eb84f3 test: Use wait_until to ensure ping goes out (Ben Woosley) Pull request description: Intermittent failure evident here: https://travis-ci.org/bitcoin/bitcoin/jobs/344021180 Tree-SHA512: 8d3cbc55563160390d3918eb0b22348990cd81ad35c0563033f19142cb43b86a150fecc7df2196209ba00aaa805c67285451e582f387f8dac22d5e44d54e8a0d
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 14, 2020
9d7f839 test: Use os.path.join consistently in feature_pruning tests (Ben Woosley) 81b0822 test: Use wait_until in tests where time was used for polling (Ben Woosley) Pull request description: This is prompted by and builds on bitcoin#12545, a nice cleanup / consolidation of patterns. In cases where the exception message was meaningful, I tried to represent it as well in a comment. I expect bitcoin#12545 will go in first, but I'm happy to squash them if that's preferred. Tree-SHA512: 7a861244001c87fd6b59b6bc248ee741ac8178f7255d6f1fda39bc693c5ff3b7de5f53d13afe9829aef6ea69153481edb0a9d5bc07c36c4f66b4315edd180bb4
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 19, 2020
9d7f839 test: Use os.path.join consistently in feature_pruning tests (Ben Woosley) 81b0822 test: Use wait_until in tests where time was used for polling (Ben Woosley) Pull request description: This is prompted by and builds on bitcoin#12545, a nice cleanup / consolidation of patterns. In cases where the exception message was meaningful, I tried to represent it as well in a comment. I expect bitcoin#12545 will go in first, but I'm happy to squash them if that's preferred. Tree-SHA512: 7a861244001c87fd6b59b6bc248ee741ac8178f7255d6f1fda39bc693c5ff3b7de5f53d13afe9829aef6ea69153481edb0a9d5bc07c36c4f66b4315edd180bb4
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 21, 2020
9d7f839 test: Use os.path.join consistently in feature_pruning tests (Ben Woosley) 81b0822 test: Use wait_until in tests where time was used for polling (Ben Woosley) Pull request description: This is prompted by and builds on bitcoin#12545, a nice cleanup / consolidation of patterns. In cases where the exception message was meaningful, I tried to represent it as well in a comment. I expect bitcoin#12545 will go in first, but I'm happy to squash them if that's preferred. Tree-SHA512: 7a861244001c87fd6b59b6bc248ee741ac8178f7255d6f1fda39bc693c5ff3b7de5f53d13afe9829aef6ea69153481edb0a9d5bc07c36c4f66b4315edd180bb4
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 24, 2020
9d7f839 test: Use os.path.join consistently in feature_pruning tests (Ben Woosley) 81b0822 test: Use wait_until in tests where time was used for polling (Ben Woosley) Pull request description: This is prompted by and builds on bitcoin#12545, a nice cleanup / consolidation of patterns. In cases where the exception message was meaningful, I tried to represent it as well in a comment. I expect bitcoin#12545 will go in first, but I'm happy to squash them if that's preferred. Tree-SHA512: 7a861244001c87fd6b59b6bc248ee741ac8178f7255d6f1fda39bc693c5ff3b7de5f53d13afe9829aef6ea69153481edb0a9d5bc07c36c4f66b4315edd180bb4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermittent failure evident here:
https://travis-ci.org/bitcoin/bitcoin/jobs/344021180