[Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server #12490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
4 tasks
dec8bd4 to
6f21090
Compare
6f21090 to
47aa910
Compare
|
rebased |
f43f11c to
1158feb
Compare
maflcko
reviewed
Aug 6, 2018
src/rpc/misc.cpp
Outdated
| std::string currentAddress = EncodeDestination(dest); | ||
| ret.pushKV("address", currentAddress); | ||
| CScript scriptPubKey = GetScriptForDestination(dest); | ||
| ret.pushKV("scriptPubKey", HexStr(scriptPubKey.begin(), scriptPubKey.end()));; |
There was a problem hiding this comment.
nit: No need for double semicolon?
1158feb to
25bf889
Compare
|
V0.17 has been branched. This is ready for review/merge |
Merged
createmultisig() was updated in V0.16 to not use the wallet. Warning text was included to warn the user. Remove that now.
25bf889 to
f7e9e70
Compare
|
rebased |
|
re-utACK f7e9e70 |
|
utACK f7e9e70. |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Sep 7, 2018
…ures from bitcoin_server f7e9e70 [rpc] Remove deprecated sigrawtransaction rpc method. (John Newbery) 90c8340 [RPC] Remove warning about wallet addresses in createmultisig() (John Newbery) df905e3 [rpc] Remove deprecated validateaddress usage. (John Newbery) Pull request description: The following rpc features were deprecated in V0.17: - `validateaddress` returning wallet information about an address - `signrawtransaction` This PR fully removes those features. It can be merged once V0.17 has been branched from master. Tree-SHA512: 28293d218cf7e348632081e362f8775f243d091f49aed54c354f017d4a12ae92b87b99f81ee592a1bbf4aebd5d8cd5119278141edde7a0399ff82917ed68b9f6
|
What was the reasoning behind this? It seems unnecessary. |
|
@ptyx11 This is part of the separation of the wallet from the node. Those RPCs were node RPCs which involved wallet things, so they needed to be removed. They have been deprecated for at least one major version with replacement RPCs already available. |
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 20, 2020
Summary: Looks like this was partially done in D3978. Partial backport of Core [[bitcoin/bitcoin#12490 | PR12490]] Test Plan: cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF .. ninja ninja check ninja check-functional ./bitcoind ./bitcoin-cli getnewaddress Verify rpc fails because there is no wallet. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5520
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
May 19, 2020
Summary: Looks like this was partially done in D3978. Partial backport of Core [[bitcoin/bitcoin#12490 | PR12490]] Test Plan: cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF .. ninja ninja check ninja check-functional ./bitcoind ./bitcoin-cli getnewaddress Verify rpc fails because there is no wallet. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5520
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Aug 30, 2021
…ures from bitcoin_server f7e9e70 [rpc] Remove deprecated sigrawtransaction rpc method. (John Newbery) 90c8340 [RPC] Remove warning about wallet addresses in createmultisig() (John Newbery) df905e3 [rpc] Remove deprecated validateaddress usage. (John Newbery) Pull request description: The following rpc features were deprecated in V0.17: - `validateaddress` returning wallet information about an address - `signrawtransaction` This PR fully removes those features. It can be merged once V0.17 has been branched from master. Tree-SHA512: 28293d218cf7e348632081e362f8775f243d091f49aed54c354f017d4a12ae92b87b99f81ee592a1bbf4aebd5d8cd5119278141edde7a0399ff82917ed68b9f6
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Aug 30, 2021
…ures from bitcoin_server f7e9e70 [rpc] Remove deprecated sigrawtransaction rpc method. (John Newbery) 90c8340 [RPC] Remove warning about wallet addresses in createmultisig() (John Newbery) df905e3 [rpc] Remove deprecated validateaddress usage. (John Newbery) Pull request description: The following rpc features were deprecated in V0.17: - `validateaddress` returning wallet information about an address - `signrawtransaction` This PR fully removes those features. It can be merged once V0.17 has been branched from master. Tree-SHA512: 28293d218cf7e348632081e362f8775f243d091f49aed54c354f017d4a12ae92b87b99f81ee592a1bbf4aebd5d8cd5119278141edde7a0399ff82917ed68b9f6
PastaPastaPasta
pushed a commit
to dashpay/dash
that referenced
this pull request
Sep 1, 2021
…ures from bitcoin_server (#4380) f7e9e70 [rpc] Remove deprecated sigrawtransaction rpc method. (John Newbery) 90c8340 [RPC] Remove warning about wallet addresses in createmultisig() (John Newbery) df905e3 [rpc] Remove deprecated validateaddress usage. (John Newbery) Pull request description: The following rpc features were deprecated in V0.17: - `validateaddress` returning wallet information about an address - `signrawtransaction` This PR fully removes those features. It can be merged once V0.17 has been branched from master. Tree-SHA512: 28293d218cf7e348632081e362f8775f243d091f49aed54c354f017d4a12ae92b87b99f81ee592a1bbf4aebd5d8cd5119278141edde7a0399ff82917ed68b9f6 Co-authored-by: MarcoFalke <falke.marco@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following rpc features were deprecated in V0.17:
validateaddressreturning wallet information about an addresssignrawtransactionThis PR fully removes those features. It can be merged once V0.17 has been branched from master.