Skip to content

Declare CMutableTransaction a struct in rawtransaction.h #12494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2018
Merged

Declare CMutableTransaction a struct in rawtransaction.h #12494

merged 1 commit into from
Feb 21, 2018

Conversation

Empact
Copy link
Contributor

@Empact Empact commented Feb 20, 2018 •
edited
Loading

Because it's a struct.

Fix for #10579 - this was called out in code review. #10579 (comment)

@promag
Copy link
Contributor

promag commented Feb 20, 2018

ACK eacc5b2.

@fanquake
Copy link
Member

tACK eacc5b2
Fixes:

  CXX      wallet/libbitcoin_wallet_a-crypter.o
In file included from rpc/rawtransaction.cpp:20:
./rpc/rawtransaction.h:9:1: warning: class 'CMutableTransaction' was previously declared as a struct [-Wmismatched-tags]
class CMutableTransaction;
^
./primitives/transaction.h:362:8: note: previous use is here
struct CMutableTransaction
       ^
./rpc/rawtransaction.h:9:1: note: did you mean struct here?
class CMutableTransaction;
^~~~~
struct
  CXX      wallet/libbitcoin_wallet_a-db.o

@theuni
Copy link
Member

theuni commented Feb 21, 2018

Obvious utACK eacc5b2

@achow101
Copy link
Member

ACK eacc5b2

@maflcko maflcko merged commit eacc5b2 into bitcoin:master Feb 21, 2018
maflcko pushed a commit that referenced this pull request Feb 21, 2018
Merge #12494: Declare CMutableTransaction a struct in rawtransaction.h
e4ffcac 
eacc5b2 Declare CMutableTransaction a struct in rawtransaction.h (Ben Woosley)

Pull request description:

  Because it's a struct.

  Fix for #10579 - this was called out in code review. #10579 (comment)

Tree-SHA512: 10758a667218481de6f50b5ed874e92eb350c621f7a6355fba7da6ab42b09e1764f827e89491c8663e554fcfd23f124b299f968237c6ad1ff7819e211bd7e521
@Empact Empact deleted the mutabletransaction-struct branch February 21, 2018 23:52
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 11, 2020
@PastaPastaPasta
Merge bitcoin#12494: Declare CMutableTransaction a struct in rawtrans…
a320bf9 
…action.h

eacc5b2 Declare CMutableTransaction a struct in rawtransaction.h (Ben Woosley)

Pull request description:

  Because it's a struct.

  Fix for bitcoin#10579 - this was called out in code review. bitcoin#10579 (comment)

Tree-SHA512: 10758a667218481de6f50b5ed874e92eb350c621f7a6355fba7da6ab42b09e1764f827e89491c8663e554fcfd23f124b299f968237c6ad1ff7819e211bd7e521
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 12, 2020
@PastaPastaPasta
Merge bitcoin#12494: Declare CMutableTransaction a struct in rawtrans…
0d87d00 
…action.h

eacc5b2 Declare CMutableTransaction a struct in rawtransaction.h (Ben Woosley)

Pull request description:

  Because it's a struct.

  Fix for bitcoin#10579 - this was called out in code review. bitcoin#10579 (comment)

Tree-SHA512: 10758a667218481de6f50b5ed874e92eb350c621f7a6355fba7da6ab42b09e1764f827e89491c8663e554fcfd23f124b299f968237c6ad1ff7819e211bd7e521
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 12, 2020
@PastaPastaPasta
Merge bitcoin#12494: Declare CMutableTransaction a struct in rawtrans…
af917fe 
…action.h

eacc5b2 Declare CMutableTransaction a struct in rawtransaction.h (Ben Woosley)

Pull request description:

  Because it's a struct.

  Fix for bitcoin#10579 - this was called out in code review. bitcoin#10579 (comment)

Tree-SHA512: 10758a667218481de6f50b5ed874e92eb350c621f7a6355fba7da6ab42b09e1764f827e89491c8663e554fcfd23f124b299f968237c6ad1ff7819e211bd7e521
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 15, 2020
@PastaPastaPasta
Merge bitcoin#12494: Declare CMutableTransaction a struct in rawtrans…
5574b51 
…action.h

eacc5b2 Declare CMutableTransaction a struct in rawtransaction.h (Ben Woosley)

Pull request description:

  Because it's a struct.

  Fix for bitcoin#10579 - this was called out in code review. bitcoin#10579 (comment)

Tree-SHA512: 10758a667218481de6f50b5ed874e92eb350c621f7a6355fba7da6ab42b09e1764f827e89491c8663e554fcfd23f124b299f968237c6ad1ff7819e211bd7e521
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 15, 2020
@PastaPastaPasta
Merge bitcoin#12494: Declare CMutableTransaction a struct in rawtrans…
d72f7c8 
…action.h

eacc5b2 Declare CMutableTransaction a struct in rawtransaction.h (Ben Woosley)

Pull request description:

  Because it's a struct.

  Fix for bitcoin#10579 - this was called out in code review. bitcoin#10579 (comment)

Tree-SHA512: 10758a667218481de6f50b5ed874e92eb350c621f7a6355fba7da6ab42b09e1764f827e89491c8663e554fcfd23f124b299f968237c6ad1ff7819e211bd7e521
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 18, 2020
@PastaPastaPasta
Merge bitcoin#12494: Declare CMutableTransaction a struct in rawtrans…
1d90698 
…action.h

eacc5b2 Declare CMutableTransaction a struct in rawtransaction.h (Ben Woosley)

Pull request description:

  Because it's a struct.

  Fix for bitcoin#10579 - this was called out in code review. bitcoin#10579 (comment)

Tree-SHA512: 10758a667218481de6f50b5ed874e92eb350c621f7a6355fba7da6ab42b09e1764f827e89491c8663e554fcfd23f124b299f968237c6ad1ff7819e211bd7e521
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
RPC/REST/ZMQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Empact @promag @fanquake @theuni @achow101 @maflcko